From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20DF6CD11C2 for ; Wed, 10 Apr 2024 11:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1T6d9zVD13+toqBQuKEfmwj/E2Vo7CECMVapYsVnKc=; b=A8X3B/qtBRqy+H n3ZjaVz/B4q/yFfNite1/Lk2Iewh1FyrFB3z2pcj4/mCTkoDDLLJ5jKPehJuDZaFpV9vz/8HjN0cF zhM8X/UvGomIzuy0/red/NQs1ZzEFv9V7Dp+6wMKZSWP6DEDLOy2XIDU0triwt/I/ppAeebj3ggPv v82KKspXwljTA2b1tps8NZyJM3QKCJNv3ekTjo7LvpmxVO+NARrVN6Uvwam4zANJvoyeOUHtL7WfR h7090X9U7ddDySOhLSVennvMvqV2emAqGkm2dhpenJQtJs0Fo/TyemBSmDo++mffKYiEgpt9ifPY4 a7CVjvoXTR7NAmpBHTUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4w-00000006bJ7-2wCO; Wed, 10 Apr 2024 11:25:22 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4f-00000006b73-2CoT for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Q2XuHTnpBIWpyQZNHPcbLppoXDYJ4UpElNhcDdmY5jE=; b=bT56KS qE/8jdTPtzKVw2Ql1egR3fsIujU6yyooIfip4LLJuwCIwiFEVnYf4cJk3MF5AgG1 lViwoGWmMBRNYcFlrDHP8D4F1gA7UiHBIJXqw/xL592owDRZJvvZA6mJnXea7zER RU4D3At3BuQwZXPGy/dEhD7KSR8RhtmzgrSEEF5VCgPT5fxIjYjCHXAab+1g71nL wkhCFyxZkp9dG0SQNjR5ZsyuYEKtHBZ5xzWufQAhPK7SHvc7noOMJdUrgbDH3otw RXKQ0TH9Uw/dKTgvDYtZUDAqliK8B2DgNx2tQq7L3KL4p8YUrgE0rcuTn0CiiyZp fRh8SaupDeeDUvng== Received: (qmail 521390 invoked from network); 10 Apr 2024 13:25:00 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:00 +0200 X-UD-Smtp-Session: l3s3148p1@xiz9SbwVCgdtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/18] i2c: bcm-iproc: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:16 +0200 Message-ID: <20240410112418.6400-22-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042506_614818_D983975E X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index e905734c26a0..133d02899c6b 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -811,8 +811,6 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i2c_dev *iproc_i2c, } if (!time_left && !iproc_i2c->xfer_is_done) { - dev_err(iproc_i2c->device, "transaction timed out\n"); - /* flush both TX/RX FIFOs */ val = BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel