linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/18] i2c: nomadik: remove printout on handled timeouts
Date: Wed, 10 Apr 2024 13:24:23 +0200	[thread overview]
Message-ID: <20240410112418.6400-29-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>

I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-nomadik.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 4f41a3c7824d..45c6df26fcbf 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -542,12 +542,9 @@ static int read_i2c(struct nmk_i2c_dev *priv, u16 flags)
 
 	xfer_done = nmk_i2c_wait_xfer_done(priv);
 
-	if (!xfer_done) {
-		/* Controller timed out */
-		dev_err(&priv->adev->dev, "read from slave 0x%x timed out\n",
-			priv->cli.slave_adr);
+	if (!xfer_done)
 		status = -ETIMEDOUT;
-	}
+
 	return status;
 }
 
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-04-10 11:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 11:24 [PATCH 00/18] i2c: remove printout on handled timeouts Wolfram Sang
2024-04-10 11:24 ` [PATCH 01/18] i2c: at91-master: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 02/18] i2c: bcm-iproc: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 03/18] i2c: bcm2835: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 04/18] i2c: cadence: " Wolfram Sang
2024-04-11  7:09   ` Michal Simek
2024-04-10 11:24 ` [PATCH 05/18] i2c: davinci: " Wolfram Sang
2024-04-10 11:24 ` Wolfram Sang [this message]
2024-04-12  8:39   ` [PATCH 09/18] i2c: nomadik: " Linus Walleij
2024-04-10 11:24 ` [PATCH 13/18] i2c: rk3x: " Wolfram Sang
2024-04-11 18:59   ` Heiko Stuebner
2024-04-12 21:12   ` Dragan Simic
2024-04-13  6:38     ` Wolfram Sang
2024-04-13  6:44       ` Dragan Simic
2024-04-13  7:10         ` Wolfram Sang
2024-04-13  8:07           ` Dragan Simic
2024-04-13  7:58         ` Heiko Stübner
2024-04-13  8:12           ` Dragan Simic
2024-04-13 14:35           ` Wolfram Sang
2024-04-16 19:02             ` Andi Shyti
2024-04-10 11:24 ` [PATCH 15/18] i2c: st: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 17/18] i2c: uniphier-f: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 18/18] i2c: uniphier: " Wolfram Sang
2024-04-22 22:50 ` [PATCH 00/18] i2c: " Andi Shyti
     [not found] ` <ZihNbtiVDkxgUDGk@surfacebook.localdomain>
2024-04-24  9:00   ` Wolfram Sang
2024-04-24 12:41     ` Andy Shevchenko
2024-04-24 12:44       ` Andy Shevchenko
2024-04-27 18:03         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410112418.6400-29-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).