From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864E6CD128A for ; Wed, 10 Apr 2024 11:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7iuvB+IZtJDhj3K0tycRBityyOhYknjg7xziuax6Qqw=; b=KQDkFNe2yHpr85 iyk8S5iLu4MItKkCSKh3yqoG3c4d8gO5bypAM60LQQvuDNwZSWNzS60coP2WRKuNgDsBAN4t3Ori0 80Qc0bSdEotaDmD6mYADD0HsbU3oGrVlX3LIGaoZN5CFmfOmtWPJkytNPukf6UXKUxueJGqgpPumv Lf1/txkEhB+LTu/2pOgowMG/Hi6Cf5P1UzGKawIepPOpTO4diIEaJmzVoe0b0EsvOT6wKG72jJ5Bh CnjHnwzY96t3O/7NXwkjTLFW+8knZlvMSDSOX/FViG+5W/+lcOWQELnu5WT/K2H338xSnCt+dQDvw 04ojBGgNMWwZdUXmEIlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5X-00000006bkc-0hKt; Wed, 10 Apr 2024 11:25:59 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4w-00000006bHk-0E2T for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=X7d+g6GmFE6xmFhmuPXFDnzDcw798Dd53vujZTSLEyU=; b=PKAMFF 2dGmeXmjkFQh4VLGO9ahOzd7m3cQAUQF27XMFlDxU2MFkPjfPwebZM/2DObDBa0Z LeRpedKIml6vzuUsJGQVa35jts19EyAcml/wUVHDGxDue5BMe/AaBrTrLc5EpqwI wsXlvha5j/soHtNQ9s5+t8aBrbNQiBOw1MM5thC+WHeBXkqomwlM7UfRmCalc++Q w37nbeaKUNpocTlHK65IQOQbcZCpQ0uWSJUZyoILOgoZE5JMNKN2IeF978hvP5fH 0IcZuO9tczGuL7Aer1RI4as0VaM4cbtUwD5wrsxZsGqHK/894Df8sprTkyTxifOq q6utamIoTepr1SuA== Received: (qmail 521909 invoked from network); 10 Apr 2024 13:25:16 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:16 +0200 X-UD-Smtp-Session: l3s3148p1@oQz1SrwVMHttKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Patrice Chotard , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/18] i2c: st: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:29 +0200 Message-ID: <20240410112418.6400-35-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042522_434151_CDDF0916 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-st.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index ce2333408904..dbb93394ff94 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -689,11 +689,8 @@ static int st_i2c_xfer_msg(struct st_i2c_dev *i2c_dev, struct i2c_msg *msg, i2c_dev->adap.timeout); ret = c->result; - if (!timeout) { - dev_err(i2c_dev->dev, "Write to slave 0x%x timed out\n", - c->addr); + if (!timeout) ret = -ETIMEDOUT; - } i2c = SSC_I2C_STOPG | SSC_I2C_REPSTRTG; st_i2c_clr_bits(i2c_dev->base + SSC_I2C, i2c); -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel