From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B839ECD128A for ; Wed, 10 Apr 2024 14:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VpbBfRWGhbZwSq7T0oLDFvdkB3tUI6xkTXxl70Vw/So=; b=0j/Tb/2QQkFyLb LYOGXAfYbuToKNmaBznm75EgyNDC2Agr96tWVUJFCYCF5CLsli3CR7MxybPTgQ2iPxatpLtOnNSB8 NN5rzO+mRtflrzjCQaEwtUJx4LW5x3IZ+ASLkxBTZvs/db5OOv/oDDnT+1t5d6BDmerOzzTPe/XbB CAQrufa35a9FvWZxfLQIsSOWX6hLcSwlqZaXhLEYjhvpaYsC8bwc9Qvo+hRjP0K+ANYYaSSfqMaGo 3qvG2x3uz93dsWHu7RL8qizNSf5XU/N5GST+r0jqdJ4p/EjFJ/p1/9slVLwPiQvDI8CH8F2qVBKLV 7+MaubpdowvHwpLQcoOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruZBn-00000007XsR-3sTw; Wed, 10 Apr 2024 14:44:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruZBi-00000007XoK-0kvp for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 14:44:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6802A61DC7; Wed, 10 Apr 2024 14:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B7D9C433C7; Wed, 10 Apr 2024 14:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712760273; bh=/K5USd0NBdotcljjFwf7xqKH8dXK5hCEaoHws5cvcGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=umyEgEWjX2jEZwX58idH08F8L7TgWw02BUER80VH8LwBKppeGa7sHoJj8kxdfdPjq F5wYa3FIRwltdk3/u1n4HonDPW+ZvSzklIRe1Uj0rDqy4edZb+MuGT/s41Id0HSnKI OjttCfQDAlwncYwpVg9CAHzY6E161dfrist79mi+Uq8OZJ3jM4NIt1v1eg1NlksRPG +wx7EjSGOF1pNGwiJ1PTUX4QC/XqPCc+4oIRHTLfRhrREqSXAUkYh7xZVNknNcVS+u Tn6rwRREbeCBianWr7N+I4fuK3aW+IKdi4m6QjD1uyERL2wo7HcvY+GouaK08ENhlA tfa0sI294ftZw== Date: Wed, 10 Apr 2024 15:44:25 +0100 From: Will Deacon To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Lu Baolu , Eric Auger , Jean-Philippe Brucker , Joerg Roedel , Kevin Tian , kernel test robot , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Mostafa Saleh , Tony Zhu , Yi Liu , Zhangfei Gao Subject: Re: [PATCH v6 06/29] iommu/arm-smmu-v3: Add an ops indirection to the STE code Message-ID: <20240410144425.GA24887@willie-the-truck> References: <0-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> <6-v6-228e7adf25eb+4155-smmuv3_newapi_p2_jgg@nvidia.com> <20240409124007.GA23088@willie-the-truck> <20240409235512.GK5383@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240409235512.GK5383@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_074434_632175_96314E67 X-CRM114-Status: GOOD ( 25.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2024 at 08:55:12PM -0300, Jason Gunthorpe wrote: > On Tue, Apr 09, 2024 at 01:40:08PM +0100, Will Deacon wrote: > > On Wed, Mar 27, 2024 at 03:07:52PM -0300, Jason Gunthorpe wrote: > > > Prepare to put the CD code into the same mechanism. Add an ops indirection > > > around all the STE specific code and make the worker functions independent > > > of the entry content being processed. > > > > > > get_used and sync ops are provided to hook the correct code. > > > > > > Signed-off-by: Michael Shavit > > > Reviewed-by: Michael Shavit > > > Tested-by: Nicolin Chen > > > Tested-by: Shameer Kolothum > > > Signed-off-by: Jason Gunthorpe > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 170 ++++++++++++-------- > > > 1 file changed, 102 insertions(+), 68 deletions(-) > > > > Any chance we can pull the STE testing stuff forward from Michael once > > we have the entry writing ops indirection, please? It would be nice to > > land that before adding the CD support, I think. > > Yes, I can. There is a bit more work because the CD testing is still > not finished, but I can probably do that. > > How about this, I split part 2 into half and the first half ends at > "iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd()" (it > finishes changing the CD programming to look like the STE). I'll pull > forward the selftest patch into that series. That is another 9 patches > from what you have taken so far. > > The second half is all about "building a generic pasid layer". > > Those 8 patches have all been looked at now, so if we pick them up > soonish we can more easially focus on the latter patches. > > Agree? Yes, please, that would be really good. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel