From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 918EFCD128A for ; Thu, 11 Apr 2024 12:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/XHbF7WrYle7+e/2roJ76f475qoj/ZPoNqLwjdlh7zU=; b=1pNXn/r0fw2vUD g1qsPmT/dFlshAcWOjIfux0wfHsssgtn9DoAbfb2BwyjFza5brnKYY9P4+UaLOM/e4bSBewnRuDHD 8qjyxb7kBc0KnjiI0aBAWocfiXaZ8qsQwqQLu+cYu9pyFIpdbzZrMDMOvsV5Uco9RA18bfz5irxrq dQj2Eqj2zOrBwavh0o2Fd03O/1gbEwq0xOLG91m3C0KX2qnaQ2HwCqpqvDYRQpAGEqcs5XEWjtTfL JkqaRnZjSUGrF4gJzY1d1f09GygF9rW9ND96Q5siNtGMgPiR0BF+cAjC+YEr+M7YL9/Q7R/gg6Gox AmXN9HKNRj94kGmXHUOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rut9n-0000000BrQf-3Fxb; Thu, 11 Apr 2024 12:03:55 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rut9k-0000000BrOu-08Pb for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 12:03:53 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4647561DD5; Thu, 11 Apr 2024 12:03:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B608C433C7; Thu, 11 Apr 2024 12:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712837030; bh=oltkbgJz/lUcQWtwkLke/qM0DU1bwDW6wogBIn+i780=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dKYDMK3iUyUAOAqGAdXCtZqI4PHO1hUEa+vVgCaVnZbP7/HZax/WvuruCdVXLpiZ+ fITLONyNAJrOiKejW9o5JiBe6r4Usq9A7jldYoqRvOgU2Gker3Xf+qBKZhsG5F6NFY ZDQkPjOsDABS8Kmf+z23LoZuYVWxnhMHXfdm2XqM= Date: Thu, 11 Apr 2024 14:03:47 +0200 From: Greg Kroah-Hartman To: Ayush Singh Cc: linux-kernel@vger.kernel.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH v3 6/8] greybus: Add mikroBUS manifest types Message-ID: <2024041103-nimbly-pounce-aa36@gregkh> References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-7-ayushdevel1325@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240315184908.500352-7-ayushdevel1325@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240411_050352_207868_50F20915 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 16, 2024 at 12:19:04AM +0530, Ayush Singh wrote: > Add data structures for parsing mikroBUS manifests, which are based on > greybus manifest. > > Signed-off-by: Ayush Singh > --- > include/linux/greybus/greybus_manifest.h | 49 ++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/include/linux/greybus/greybus_manifest.h b/include/linux/greybus/greybus_manifest.h > index bef9eb2093e9..83241e19d9b3 100644 > --- a/include/linux/greybus/greybus_manifest.h > +++ b/include/linux/greybus/greybus_manifest.h > @@ -23,6 +23,9 @@ enum greybus_descriptor_type { > GREYBUS_TYPE_STRING = 0x02, > GREYBUS_TYPE_BUNDLE = 0x03, > GREYBUS_TYPE_CPORT = 0x04, > + GREYBUS_TYPE_MIKROBUS = 0x05, > + GREYBUS_TYPE_PROPERTY = 0x06, > + GREYBUS_TYPE_DEVICE = 0x07, These need approval in the spec before we can add them here. And you are adding 3 different things here, not just one. Shouldn't this be 3 patches? > }; > > enum greybus_protocol { > @@ -151,6 +154,49 @@ struct greybus_descriptor_cport { > __u8 protocol_id; /* enum greybus_protocol */ > } __packed; > > +/* > + * A mikrobus descriptor is used to describe the details > + * about the bus ocnfiguration for the add-on board > + * connected to the mikrobus port. > + */ > +struct greybus_descriptor_mikrobus { > + __u8 pin_state[12]; > +} __packed; > + > +/* > + * A property descriptor is used to pass named properties > + * to device drivers through the unified device properties > + * interface under linux/property.h > + */ > +struct greybus_descriptor_property { > + __u8 length; > + __u8 id; > + __u8 propname_stringid; > + __u8 type; > + __u8 value[]; Don't we have a "counted-by" marking that we can use to show how big value[] here is? > +} __packed; > + > +/* > + * A device descriptor is used to describe the > + * details required by a add-on board device > + * driver. > + */ > +struct greybus_descriptor_device { > + __u8 id; > + __u8 driver_stringid; > + __u8 protocol; > + __u8 reg; > + __le32 max_speed_hz; > + __u8 irq; > + __u8 irq_type; > + __u8 mode; > + __u8 prop_link; > + __u8 gpio_link; > + __u8 reg_link; > + __u8 clock_link; > + __u8 pad[1]; Why the padding? And this looks like a greybus thing, not a mikrobus thing, right? Some description of exactly what this is and what it does would be good. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel