From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CE1FCD1284 for ; Thu, 11 Apr 2024 09:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DWQ9FSAJdJTxz09waShx+v3XZFp1P4KCEZ9kLIq5188=; b=ej6PuGBJoWu97b dcmVYrH7mTqelYBpZXBrMgcvsqXPn+CLZJrk+eCPz7bOb8FeTxdmyKx5hIceCFaoLfQrUMOyr1Uyd eaW0IwPqYA/nxDMrWUG0Fi506ouYzGDqkOj70yw2OnvyFtazLV1YqMIJfWOGBozXeFpiOMkgDjHfP PrxKPs2czeJ/r/XI2ljAL+OBL6BtlU+BmHOj7O1Fk6cgIgFG9zTU9DZnQj0MKXIF0YxD4c7eaqdVK rxx41+vkahzmOvafzcOHOCQ9AwJIxm82e+WNFlxx3NRqdyQUmMF89RePKtZNFKWz7TXa4b3TXBl3t ZZy7+bbfEH1mEpZfr9lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruqgz-0000000BJG2-3YSJ; Thu, 11 Apr 2024 09:26:01 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruqgw-0000000BJEY-0HqY for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 09:26:00 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7ECF360003; Thu, 11 Apr 2024 09:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1712827552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vKjOj/t4Yd+gG7pDolrHBzRHmNw6eOFJQo600f52EaQ=; b=heNt7qrSXRMC4rqLyIBOIMXpVD8SFG+udbziO2RYbryEobpgcdrsdl8Zera6ZTHjQdhOqG 5yHs1eci3vhT8x0di/FRMcpX5H9dHp0hEMxuwP9jshRIyuUlGeaTRokaFv+Ao094HNm6Bk wnarmorhQDzH+EU55n/bsVVk1k2h+P+0+58GmQ7Vi3rwV+jZ2wUXUBY3DLH6en//GzkqHO JgXjV+A2KkxuKNHW5qpBD2Mg71z9HjlA2cphOTqMcY6r0/cYzdfb0Z308Tk3igbKbpaHAt 5Y1XNSLddxw7Bg3/4pTa0Zig5M94uVSNTFsir+GzdhGRrFN8Bisr83TtE2rRMg== Date: Thu, 11 Apr 2024 11:25:48 +0200 From: Maxime Chevallier To: Nathan Chancellor Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v11 01/13] net: phy: Introduce ethernet link topology representation Message-ID: <20240411112548.68ae868e@device-28.home> In-Reply-To: <20240410145358.GA2996695@dev-arch.thelio-3990X> References: <20240404093004.2552221-1-maxime.chevallier@bootlin.com> <20240404093004.2552221-2-maxime.chevallier@bootlin.com> <20240409201553.GA4124869@dev-arch.thelio-3990X> <20240410101627.53bfdebf@device-28.home> <20240410145358.GA2996695@dev-arch.thelio-3990X> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240411_022558_572292_7F45B48B X-CRM114-Status: GOOD ( 24.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, 10 Apr 2024 07:53:58 -0700 Nathan Chancellor wrote: > On Wed, Apr 10, 2024 at 10:16:27AM +0200, Maxime Chevallier wrote: > > On Tue, 9 Apr 2024 13:15:53 -0700 > > Nathan Chancellor wrote: > > > On Thu, Apr 04, 2024 at 11:29:51AM +0200, Maxime Chevallier wrote: > > > > [...] > > > > > I bisected a crash that I see on one of my test devices to this change > > > in -next as commit 6916e461e793 ("net: phy: Introduce ethernet link > > > topology representation"). Here is the stack trace passed through > > > scripts/decode_stacktrace.sh: > > > > [...] > > > > > [ 5.626535] ? phy_link_topo_add_phy (drivers/net/phy/phy_link_topology.c:46) libphy > > > [ 5.627954] ? _raw_spin_lock (arch/x86/include/asm/atomic.h:115 (discriminator 4) include/linux/atomic/atomic-arch-fallback.h:2170 (discriminator 4) include/linux/atomic/atomic-instrumented.h:1302 (discriminator 4) include/asm-generic/qspinlock.h:111 (discriminator 4) include/linux/spinlock.h:187 (discriminator 4) include/linux/spinlock_api_smp.h:134 (discriminator 4) kernel/locking/spinlock.c:154 (discriminator 4)) > > > [ 5.627963] phy_link_topo_add_phy (include/linux/xarray.h:977 drivers/net/phy/phy_link_topology.c:80) libphy > > > [ 5.629462] phy_attach_direct (drivers/net/phy/phy_device.c:1516) libphy > > > [ 5.629504] phylink_connect_phy (drivers/net/phy/phylink.c:1983) phylink > > > [ 5.631030] ax88772_bind (drivers/net/usb/asix_devices.c:710 drivers/net/usb/asix_devices.c:919) asix > > > [ 5.631049] usbnet_probe (drivers/net/usb/usbnet.c:1745) usbnet > > > > I've run some tests on an arm64 board using an USB to Ethernet adapter > > that uses the same driver (It also goes through ax88772_bind() ) but I > > don't reproduce the error. > > > > > If there is any additional information I can provide or patches I can > > > test, I am more than happy to do so. > > > > The next step for me would be to try on an x86_64 box to get closer to > > the config you used, however could you give me the .config that was used > > when the bug was triggered ? I'd like to make sure I didn't miss > > anything related to some of the parts being build as modules for > > example. > > Sure thing! It should be the one I have attached, it is basically just > Arch Linux's configuration: > > https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/raw/main/config Thanks a lot. Let me try with that config and see if I can reproduce :) Maxime > > Cheers, > Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel