* [PATCH] arm64: dts: mediatek: mt8183-kukui: Drop bogus output-enable property
@ 2024-04-12 7:56 Chen-Yu Tsai
2024-04-15 10:33 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2024-04-12 7:56 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
The "output-enable" property is set on uart1's RTS pin. This is bogus
because the hardware does not actually have a controllable output
buffer. Secondly, the implementation incorrectly treats this property
as a request to switch the pin to GPIO output. This does not fit the
intended semantic of "output-enable" and it does not have any affect
either because the pin is muxed to the UART function, not the GPIO
function.
Drop the property.
Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index f934b8aad3ed..75c799a6adb4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -797,7 +797,6 @@ pins-tx {
};
pins-rts {
pinmux = <PINMUX_GPIO47__FUNC_URTS1>;
- output-enable;
};
pins-cts {
pinmux = <PINMUX_GPIO46__FUNC_UCTS1>;
@@ -816,7 +815,6 @@ pins-tx {
};
pins-rts {
pinmux = <PINMUX_GPIO47__FUNC_URTS1>;
- output-enable;
};
pins-cts {
pinmux = <PINMUX_GPIO46__FUNC_UCTS1>;
--
2.44.0.683.g7961c838ac-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8183-kukui: Drop bogus output-enable property
2024-04-12 7:56 [PATCH] arm64: dts: mediatek: mt8183-kukui: Drop bogus output-enable property Chen-Yu Tsai
@ 2024-04-15 10:33 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-15 10:33 UTC (permalink / raw)
To: Chen-Yu Tsai, Matthias Brugger
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
Il 12/04/24 09:56, Chen-Yu Tsai ha scritto:
> The "output-enable" property is set on uart1's RTS pin. This is bogus
> because the hardware does not actually have a controllable output
> buffer. Secondly, the implementation incorrectly treats this property
> as a request to switch the pin to GPIO output. This does not fit the
> intended semantic of "output-enable" and it does not have any affect
> either because the pin is muxed to the UART function, not the GPIO
> function.
>
> Drop the property.
>
> Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-15 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-12 7:56 [PATCH] arm64: dts: mediatek: mt8183-kukui: Drop bogus output-enable property Chen-Yu Tsai
2024-04-15 10:33 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).