From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DCE4C4345F for ; Fri, 12 Apr 2024 13:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uS95V8uwFPj7pPIMpBEpD40eHgrqNvt7kwRP3LOH+Lg=; b=cp5iukdy8VMMWV qkjcFgaHw9JW+buvrKrlQjqfodTQXDmdpehr0jFlV6Hmd7sT0CD1QaCU/RnRd7JL1BQS2uXypPSko ynVSfMZBefnc0o5W3tUOoAMxz8AXe+K/uF4gW2EAzd0KPvQ6VdZyi4i9jUr8babdAonTQ3bpoIvRC 98OmXuvXGLqcWDxfhvZLO2AjzrpaZHK30kmQKpCEmTKUly8gR6vaZstbvASCx3VKboR7VwMPgQ2tJ hDMgZY1RD+Z471xxYp2b5y9zuWj2z1YPLxYEedprmYBbOlavQsJolOYfjQXh4EecANjh+1f5kajq7 p/1iCisscEPCKL1Bqy6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvH2c-0000000HM7n-1QYB; Fri, 12 Apr 2024 13:34:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvH2Z-0000000HM6n-3Nhl for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 13:34:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1DEA3621CD; Fri, 12 Apr 2024 13:34:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 782A1C113CC; Fri, 12 Apr 2024 13:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712928842; bh=H/5Y4943nz8CB9370bqXYhLtnrWjvViTVIaYI0FXTBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B1F7xpqbXMlsIlbhQv7f04ytdIJi1BFBq1mId+1PLQCCrBozo1jQcO9gVDvi0Wamx KxXnTzXS/J4MiXbHcUEfJr67duV5rU+gMk51fR3uDKUg61QEAQCa0xRkbmzuHMbnX+ FAIgd/g7qFdkcV5Rlc6w95Ox2msXM53kgDrPX1QXLi4uTN2gQxv0iDwEUFdPYml+VH hV5M4IiQy5iPlhy3ludusTZSeGDufHKT6GUgvSsSe8Ym+AWJPU/yQfTq5A53T60ALQ t4uARCqvgIa9VztJ2iOCTqF/dsvkA+tm9ktM+y1rn98+MDhePmdQD+XZQV1phGnHIe LMaZrzYb4KgTg== Date: Fri, 12 Apr 2024 08:34:00 -0500 From: Rob Herring To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , Cristian Marussi , Peng Fan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-bindings: firmware: add i.MX95 SCMI Extension protocol Message-ID: <20240412133400.GA2282201-robh@kernel.org> References: <20240412-imx95-bbm-misc-v2-v3-0-4380a4070980@nxp.com> <20240412-imx95-bbm-misc-v2-v3-2-4380a4070980@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240412-imx95-bbm-misc-v2-v3-2-4380a4070980@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_063403_960590_BC6800D8 X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 12, 2024 at 06:47:08PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX SCMI Extension protocols bindings for: > - Battery Backed Module(BBM) Protocol > This contains persistent storage (GPR), an RTC, and the ON/OFF button. > The protocol can also provide access to similar functions implemented via > external board components. > - MISC Protocol. > This includes controls that are misc settings/actions that must be exposed > from the SM to agents. They are device specific and are usually define to > access bit fields in various mix block control modules, IOMUX_GPR, and other > GPR/CSR owned by the SM. > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/firmware/arm,scmi.yaml | 21 +++++++++++++ > .../bindings/firmware/nxp,imx95-scmi.yaml | 36 ++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 93fb7d05f849..fa2cc910c485 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -247,6 +247,27 @@ properties: > reg: > const: 0x18 > > + protocol@81: > + $ref: '#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x81 > + > + protocol@84: > + type: object > + anyOf: > + - allOf: > + - $ref: /schemas/firmware/nxp,imx95-scmi.yaml > + - $ref: '#/$defs/protocol-node' If you put the ref under the protocol node, then it's 1 schema file per protocol per vendor. Also, we then have to list every possible protocol node here, and every one listed here will be valid for every vendor. What we discussed is putting the list of vendor protocol schemas at the top-level here and then the vendor schemas can list out all the protocol nodes. Also, move "$ref: '#/$defs/protocol-node'" to nxp,imx95-scmi.yaml. > + > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x84 > + > additionalProperties: false > > $defs: > diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > new file mode 100644 > index 000000000000..b84c4a53b78a > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/nxp,imx95-scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX95 System Control and Management Interface(SCMI) Vendor Protocols Extension > + > +maintainers: > + - Peng Fan > + > +properties: > + nxp,wakeup-sources: > + description: > + Each entry consists of 2 integers, represents the source and electric signal edge > + items: > + items: > + - description: the wakeup source > + - description: the wakeup electric signal edge > + minItems: 1 > + maxItems: 32 > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > +if: > + properties: > + reg: > + const: 0x84 This schema is only included from protocol@84 node, so how can this be false? > +then: > + properties: > + nxp,wakeup-sources: true > +else: > + properties: > + nxp,wakeup-sources: false > + > +additionalProperties: true > > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel