From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A77C7C4345F for ; Fri, 12 Apr 2024 14:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ncvs84HRqwm26LlQ9rXXQuZnWBFk/4ljBsElhsQX9Jg=; b=LgfqgvmfT5cVD7 rk3sfsnq0pZVHFhrI61VLX7eNJ4oNLM1TR3NIUWm2aSEaYyGCqd+wGcmm6hnDwb6ArmMAKuaudZdi tMVPMaJlEjfXLvYq5kZzExVaTMeR6cr1uN8aRiD6Z5PUPgf6qYq0Qid+mPGVMDia6doP7O6o3e+gG wp/ZCtj4CRtKoNLU+Ok1zPzMHT5Hq3PyYtG6AAHzX5owwVOdEEqpTYX2XeVappS5Fn9q/+f/3ToHq fcpSMiAfpo4Zk/MLm5PJPVeBfb5w9JGYNPTwtmuswuVAjySGlbvWs3dpD/IF2K/KzVyoUBLsyiAG8 IiQ6GAJ6ZH3W++R1xrtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHpF-0000000HY6C-1dbe; Fri, 12 Apr 2024 14:24:21 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHp7-0000000HY1L-1FuH for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:24:16 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ed0e9ccca1so934275b3a.0 for ; Fri, 12 Apr 2024 07:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931852; x=1713536652; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ycTUqQHx5D5MreNoECYZAdXjkRI9aE0qu1OLjEN7fk=; b=bvaCWTJULNJUTdUAxJiZPbiPaJ4dCe84gwPtSHzF9wczvYW8eilqshrBg6o7Sku1La B3zJ5PQmYg4EX2OdUznnuT5mdR1XHnMl/LwgG+QsTqRuKMGC8/csR/BvqfiXfdb6vENl dgoR7k/tQHGgoSH4Em8eiS8u+Kzbh/1QQuv/4qeeFKJXBoHIgEDRthSUcQ5Y77+BcFe1 WzuShvhune3qK9w499aFBKfMnCs8SoC6Rg/mefU6T/TgWwWyl7m9s8k3A/107x0sCyQQ G5gkr26yXxmlHQdBdDLeC9M2RWzqOB3AQricpoXhJWftmfnhUJAGjBXj3G6FLV96P/tm /apg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931852; x=1713536652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ycTUqQHx5D5MreNoECYZAdXjkRI9aE0qu1OLjEN7fk=; b=jaCfcvF1zxYnEnUahmGSlxloBeTT85VGVizEjf7RjFD0g0zmndpiU6Z1OKZU8SO+HE xjACcWtbJ++q9ZaUZqTVfuCeH9PMhrC6A3jROu0ZXgqFYnMhWYx8oS9yXZAETIUvTuOl EzRgVYZYNd0VEJMuCLLwh47EGWH+ixINQN3k112r0ZWJelKJ94T0HcH8Z15cHkyCsXJT 1gRV0A1XVMtijXkqxOms25x+/ihM2btkBBdvLMICPKv22M+mgJi3KhF5BW82YG7yzaqt uuLi+m1kZ+xpfeOjSpq1xcdNiEK+zx4UDuAocAoxZQ5jwubuwu4J6HX/sSw6GRCXUShC 5spw== X-Forwarded-Encrypted: i=1; AJvYcCUl11RL9p8Z1+mjHfn4GDm1zatYDbeAqhZkyZGQ3503MFlacJJIBlsAFzAP15/AA3mO6vcPyQPI9P0Xu1xQXPDYAAaXgrZCG4WzXhtaTUwLtb2T14Y= X-Gm-Message-State: AOJu0YxN71bj53aYg/+6uKyqg4NnyUd4kUB+cnVp7/YBFtPS2NlpgjB2 ABx69elOvlp8lvjW0wNxLPHuHHwOQpKmu7arKgmGyTWOqrbwCcUP X-Google-Smtp-Source: AGHT+IEVIzMZY6CCMhIHZf+aL4aqZNSAeFET5jkH5mSvmrZ4I4gbLuytamFXU/gqKehAc/d6O6nkoA== X-Received: by 2002:a05:6a00:acf:b0:6ea:ad01:358e with SMTP id c15-20020a056a000acf00b006eaad01358emr3589380pfl.0.1712931852323; Fri, 12 Apr 2024 07:24:12 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:24:11 -0700 (PDT) From: Anand Moon To: Thinh Nguyen , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/5] usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Fri, 12 Apr 2024 19:52:54 +0530 Message-ID: <20240412142317.5191-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072413_789091_FF87B00B X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_sleep_ptr() to discard all PM_SLEEP related stuff if CONFIG_PM_SLEEP isn't enabled. Signed-off-by: Anand Moon --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled. --- drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index 5d365ca51771..3427522a7c6a 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c @@ -187,7 +187,6 @@ static const struct of_device_id exynos_dwc3_match[] = { }; MODULE_DEVICE_TABLE(of, exynos_dwc3_match); -#ifdef CONFIG_PM_SLEEP static int dwc3_exynos_suspend(struct device *dev) { struct dwc3_exynos *exynos = dev_get_drvdata(dev); @@ -230,14 +229,8 @@ static int dwc3_exynos_resume(struct device *dev) return 0; } -static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume) -}; - -#define DEV_PM_OPS (&dwc3_exynos_dev_pm_ops) -#else -#define DEV_PM_OPS NULL -#endif /* CONFIG_PM_SLEEP */ +static DEFINE_SIMPLE_DEV_PM_OPS(dwc3_exynos_dev_pm_ops, + dwc3_exynos_suspend, dwc3_exynos_resume); static struct platform_driver dwc3_exynos_driver = { .probe = dwc3_exynos_probe, @@ -245,7 +238,7 @@ static struct platform_driver dwc3_exynos_driver = { .driver = { .name = "exynos-dwc3", .of_match_table = exynos_dwc3_match, - .pm = DEV_PM_OPS, + .pm = pm_sleep_ptr(&dwc3_exynos_dev_pm_ops), }, }; -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel