From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A377C04FF8 for ; Fri, 12 Apr 2024 17:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=M9gU6TH9gkO7c/fP6geqWSV4K0gLyuOjSDFxEbC4dCI=; b=XgED3Djl16c0Nj WGJLGVIWgwqrTkpxmBYyCISzNPdJqI5M0BR23Kd79ivEz9rEiMthmSL9JIe0yU0TmfDKHjw4HbHoG L8J4VRyEa2OM3ODwUuTfbuulse+WLHBGb1CoMn/i/3XX9qjo/+5ZjLK7m00B9BE90KaDgqVPxeGmW aKZ1mIHqQtiGbAn/37jJk1WABcLBaaoUSz3AfhgnjLSjdZjuf4x4IHm/S6LkRTR7OQHcVJ3hIsfo7 xKexKax5C8jBh8+oMrX9sBOtdtXRtU89DiIbkhIxnUQzwrG8jwOq2ipHLh7UBdmt+x6hgBxwG/tVS EiU5xxkewVQODhI9KHOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvL3o-00000000kAQ-0o2C; Fri, 12 Apr 2024 17:51:36 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvL3l-00000000k9O-0yBs; Fri, 12 Apr 2024 17:51:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5F306CE393D; Fri, 12 Apr 2024 17:51:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59851C113CC; Fri, 12 Apr 2024 17:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712944289; bh=B4SDpNiM6OJj6RA1ZnrFX2EgwahSw1RpMCPDTL5Nv+Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=aQjZA5q6Qh0W9oWz3dVtullRDOpFKrgq9zOOq3Ta5ItJF0PLUQSZpC7H/6knlI8ol DpD1Y2iho9K41AVL+wOkBBL7iLevPIoJy23roX4DC6P9hBItDUt4e4Qolx9p5zExDS h1/v4KsIWPrBLlr/VK+9TlTqxbZS9NQaJRyTZwV+9zd+9sNVs+blFzmygs38cAfIyw xktCioMFLFBMulyc5EwPPTetdX25Nc4IsOygdoGZUBx17JqOcDO9/JtAeNlQCKmGUZ k5fVtGpCC9VK/eF76wkTuzuhsb6INbzAQP+S2s2cXn06EF05m7/r86VrzTl9TskV12 fzGtNmy+pIykw== Date: Fri, 12 Apr 2024 12:51:27 -0500 From: Bjorn Helgaas To: Niklas Cassel Cc: Manivannan Sadhasivam , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Shradha Todi , Damien Le Moal , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 8/9] PCI: rockchip-ep: Set a 64-bit BAR if requested Message-ID: <20240412175127.GA8613@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240313105804.100168-9-cassel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_105133_474588_64C0C6CC X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 13, 2024 at 11:58:00AM +0100, Niklas Cassel wrote: > Ever since commit f25b5fae29d4 ("PCI: endpoint: Setting a BAR size > 4 GB > is invalid if 64-bit flag is not set") it has been impossible to get the > .set_bar() callback with a BAR size > 4 GB, if the BAR was also not > requested to be configured as a 64-bit BAR. > > It is however possible that an EPF driver configures a BAR as 64-bit, > even if the requested size is < 4 GB. > > Respect the requested BAR configuration, just like how it is already > repected with regards to the prefetchable bit. Does this (and the similar cadence patch) need a Fixes: tag for f25b5fae29d4? > Signed-off-by: Niklas Cassel > --- > drivers/pci/controller/pcie-rockchip-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index c9046e97a1d2..57472cf48997 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -153,7 +153,7 @@ static int rockchip_pcie_ep_set_bar(struct pci_epc *epc, u8 fn, u8 vfn, > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_IO_32BITS; > } else { > bool is_prefetch = !!(flags & PCI_BASE_ADDRESS_MEM_PREFETCH); > - bool is_64bits = sz > SZ_2G; > + bool is_64bits = !!(flags & PCI_BASE_ADDRESS_MEM_TYPE_64); > > if (is_64bits && (bar & 1)) > return -EINVAL; > -- > 2.44.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel