From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 329EBC4345F for ; Fri, 12 Apr 2024 22:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=wzh8LbV0Ain09+j3ieFrgrNp29fGSFdXoM0npTGMq5k=; b=crJek8OnTFGcEe 7sTeDd9uvjlG1idZQg15Z+Qw+I7OH/4FgJfkd6GHHPpCZVo+JIL4YClX5H7+mDNoam6SL5ibxAdOy UyudKlrbSSEEK+mFgAHOZAXCFyXxBjH1Yd7HtDYpLe0OYxHzGn4ZqcEYgvNQUPeKOYwzPqF4EBf00 RBfLmGayrWOKUe8Ks0rue/CIsiqAURu75q++j3QXbifTjF0U4zkoUSGXHjireknr3q1K+SrMvevFC AelnRU32JIh2GdElmMl9h4ydZ8Qe4L72uqp2Yd7MNONaO0YeItatQ9LWbeQFyXSvmPNUhHeSTqsh9 bBZNr/HvTHVqnqsrLBdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvP7n-00000001VBz-3mt9; Fri, 12 Apr 2024 22:11:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvP7l-00000001VAj-0DJV; Fri, 12 Apr 2024 22:11:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4E6266199F; Fri, 12 Apr 2024 22:11:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC87CC113CC; Fri, 12 Apr 2024 22:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712959916; bh=OZwvmDGS/9jos0oXpEDMyV23RH68O16X3jDCFlPoCk8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dmmFPxsJme3/18nT2Jf5IaGpKomI0Fqtbt/SUgyXNo4D1GL55MMr3ql9Rzdj4DF0k Q5YLRzs9USvoprkiSvwVYuXyby+lJpSAGTurkXDdqvphHQb+Cs/AORZY734W9lL0kG OfPgUWai58nLqqTvo3wAErCUMzbK6DmBKeCNMZhQK2w/UTCZVJHg9aZC0XIj2fSV5R R/jPtRhr+pcAmWGoZv+rgDtLEqMD6A1zYzi6L/EyInHLY0croqnJg+TSHJdVJ6Eywt e9Pft9/vUaZ1dIiHFTXMnK9Lm40qNn3B7UVEWIMGU7QGDVFQbID68K3WwK3bsHXy26 8dNR4yatlFsrA== Date: Fri, 12 Apr 2024 17:11:53 -0500 From: Bjorn Helgaas To: Niklas Cassel Cc: Manivannan Sadhasivam , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Shradha Todi , Damien Le Moal , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 8/9] PCI: rockchip-ep: Set a 64-bit BAR if requested Message-ID: <20240412221153.GA21914@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_151157_165641_ED23156D X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 13, 2024 at 12:02:12AM +0200, Niklas Cassel wrote: > On Fri, Apr 12, 2024 at 01:59:01PM -0500, Bjorn Helgaas wrote: > > On Wed, Mar 13, 2024 at 11:58:00AM +0100, Niklas Cassel wrote: > > > ... > > > > > --- a/drivers/pci/controller/pcie-rockchip-ep.c > > > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > > > @@ -153,7 +153,7 @@ static int rockchip_pcie_ep_set_bar(struct pci_epc *epc, u8 fn, u8 vfn, > > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_IO_32BITS; > > > } else { > > > bool is_prefetch = !!(flags & PCI_BASE_ADDRESS_MEM_PREFETCH); > > > - bool is_64bits = sz > SZ_2G; > > > + bool is_64bits = !!(flags & PCI_BASE_ADDRESS_MEM_TYPE_64); > > > > > > if (is_64bits && (bar & 1)) > > > return -EINVAL; > > > > Completely unrelated to *these* patches, but the BAR_CFG_CTRL > > definitions in both cadence and rockchip lead to some awkward case > > analysis: > > > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM_32BITS 0x4 > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH_MEM_32BITS 0x5 > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM_64BITS 0x6 > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH_MEM_64BITS 0x7 > > > > if (is_64bits && is_prefetch) > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH_MEM_64BITS; > > else if (is_prefetch) > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH_MEM_32BITS; > > else if (is_64bits) > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM_64BITS; > > else > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM_32BITS; > > > > that *could* be just something like this: > > > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM 0x4 > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_64BITS 0x2 > > #define ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH 0x1 > > > > ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_MEM; > > if (is_64bits) > > ctrl |= ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_64BITS; > > if (is_prefetch) > > ctrl |= ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_PREFETCH; > > If you send the cleanup patches, I will send the Reviewed-by tags ;) Fair enough :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel