From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D0AC4345F for ; Sun, 14 Apr 2024 10:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YuEYvPlxShmhzsOKfvGWKN7xtYyOoo7/13Rbx+ZdBlg=; b=CSMBGCb1aTMQPA KmdFNrd/haIlfRQTVmGXTBVlqqU6t/o2B632V4Q577FTXmg95kKTCFIbPmvN5J4l9vrM4ofjVEQZZ +fvtAitUgqYbW6+/hua0PvHBL/FXBLYRalHnsYwXaulg+Zp3avUPrMbgYSdDXHqUR+BaoTiFze+Uq usd1CEHEZFTpYyZLskfEYMu4ZWh4T0zLJhxrpkqxNtJWt2vg2X3zHsW3mMH8LA51yqLgyi9+BnM9d 9574K3gBfQUV/Lu8Bula/mjT4wczRDyDlG8+7lxIVAeO1NZc1Nevx+ejUwfVJtCIGkv1pUcBDPPre uh6nJ9M39jIHfYsVEvXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvxGy-00000005HBH-0iiB; Sun, 14 Apr 2024 10:39:44 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvxGu-00000005HAk-0wuH for linux-arm-kernel@lists.infradead.org; Sun, 14 Apr 2024 10:39:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8F3CFCE01DC; Sun, 14 Apr 2024 10:39:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 963E6C072AA; Sun, 14 Apr 2024 10:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713091176; bh=JbtOUWHVC7wNzadBF8bYSYuSrVY77oLf7wqjRB8KLZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofepjH0wUf3Os10OXvzt5lHI9qsH/w9nNsvcYVyBhHvdV4m2cw1ohO/Vis0QJOZPT QNyIPOOSPN9/npG3/acx1bApWHvcRg4inaWGF7oI86g09jSvOtGs3JJuOQmxR5+DqK V/5DIXQc2ngSjOvui34lFC+GSfpozW/Y1/RcAEHh13yGpVo7SBlIDUUVXg8NY9TQw0 pBiSrPRv47ciuhlJwVmwEsGvS1Jq7za0ry0lmYTjh0Gn3/rXYJWaXhUKZXdofrNYTe 2JXfiqIDu/+DKNmMNI7krvG53xb65g67PP1mGaNc9TkDe1l4j5Xn0zP+PRvAt0VObl j1ne7+aCuG2ig== Date: Sun, 14 Apr 2024 11:39:26 +0100 From: Simon Horman To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , Amit Pundir , Xilin Wu , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v7 13/16] power: sequencing: implement the pwrseq core Message-ID: <20240414103926.GB645060@kernel.org> References: <20240410124628.171783-1-brgl@bgdev.pl> <20240410124628.171783-14-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240410124628.171783-14-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_033940_675023_B8959457 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 10, 2024 at 02:46:25PM +0200, Bartosz Golaszewski wrote: ... > +/** > + * pwrseq_device_register() - Register a new power sequencer. > + * @config: Configuration of the new power sequencing device. > + * > + * The config structure is only used during the call and can be freed after > + * the function returns. The config structure *must* have the parent device > + * as well as the match() callback and at least one target set. > + * > + * Returns: > + * Returns the address of the new pwrseq device or ERR_PTR() on failure. > + */ > +struct pwrseq_device * > +pwrseq_device_register(const struct pwrseq_config *config) > +{ > + struct pwrseq_device *pwrseq; > + int ret; > + > + if (!config->parent || !config->match || !config->targets || > + !config->targets[0]) > + return ERR_PTR(-EINVAL); > + > + pwrseq = kzalloc(sizeof(*pwrseq), GFP_KERNEL); > + if (!pwrseq) > + return ERR_PTR(-ENOMEM); > + > + pwrseq->dev.type = &pwrseq_device_type; > + pwrseq->dev.bus = &pwrseq_bus; > + pwrseq->dev.parent = config->parent; > + device_set_node(&pwrseq->dev, dev_fwnode(config->parent)); > + dev_set_drvdata(&pwrseq->dev, config->drvdata); > + > + pwrseq->id = ida_alloc(&pwrseq_ida, GFP_KERNEL); > + if (pwrseq->id < 0) { > + kfree(pwrseq); Hi Bartosz, pwrseq is freed on the line above, so it should not be dereferenced on the line below. Flagged by Smatch. > + return ERR_PTR(pwrseq->id); > + } ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel