From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9B18C001CC for ; Sun, 14 Apr 2024 10:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2OCFmVgIKhcybZVccv2CD3Wzx7xpsnYnwFHB1ISLnvk=; b=X6C6ffoiNcGqEp qKiELYLqi+ZeqejjtN+wGcllNQ3bqL8jMFV8Xrov4kV/9wc23yXUb5PwW5/QowK0dK/WDUPxWDSJn IPCNee24qAea2HZeqB7JJsADKUQSmHYEv7mU3lPdYRmcFZAw6g+2OLH9qkDdIlcdAd9OiB8/NnFOK XvwCUK6DHCYFqttXutn6ovvP86eganTX3W5YAHvlAi/L8cE+qvNhWcP5XILeKbounSDd5d+jdwkRw hzdk1UGMzeedt3ZZzTo5YcObl6yS2mtRo7dOVkDLCPLLl7Whlc6cRj2ZJ+62A1rdZ6tI+lJhBGUZq GnahwQthROBoK5NqJLCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvww3-00000005FVk-0mrM; Sun, 14 Apr 2024 10:18:07 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvwvy-00000005FV0-04Nl; Sun, 14 Apr 2024 10:18:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3B891CE01F5; Sun, 14 Apr 2024 10:18:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9C40C072AA; Sun, 14 Apr 2024 10:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713089879; bh=gKVFAu7bX5Wtu28q+2CQOcF6pB1tKN/oXMHkZM9hdkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XcslpJknihp9zd2fAIpmnIsTQLQuSQAE4zI856SKRvl7K5YYa6NaKqWtzKSGeFzom XQVVibypLsRkJHaiS/VnFTWITap2y4tF4eX/M2ZDPmLOH4Pf+5uURZmnVF+Hlifi8d YsiyG+uA4e/b0D+fH2iJoplgxrB22tVZLJQZw1yg= Date: Sun, 14 Apr 2024 12:17:56 +0200 From: Greg KH To: sumadhura kalyan Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vc04_services: Code optimized to use linux BIT macro. Message-ID: <2024041419-rug-undrilled-6628@gregkh> References: <20240414101258.98358-1-opensourcecond@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240414101258.98358-1-opensourcecond@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_031802_259036_AA583C66 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 14, 2024 at 03:42:58PM +0530, sumadhura kalyan wrote: > Issue found by checkpatch > > Signed-off-by: sumadhura kalyan > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > index a0cdd28101f2..d811bfd3bb84 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > @@ -27,7 +27,7 @@ > /** Common parameter ID group, used with many types of component. */ > #define MMAL_PARAMETER_GROUP_COMMON (0 << 16) > /** Camera-specific parameter ID group. */ > -#define MMAL_PARAMETER_GROUP_CAMERA (1 << 16) > +#define MMAL_PARAMETER_GROUP_CAMERA BIT(16) > /** Video-specific parameter ID group. */ > #define MMAL_PARAMETER_GROUP_VIDEO (2 << 16) > /** Audio-specific parameter ID group. */ When looking at the code now, does this change make sense? Remember, checkpatch is a guide, not a hard rule. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel