From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F56C4345F for ; Mon, 15 Apr 2024 07:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AqVnugbCKuUa6/n1WjC+xhv4vgaHPEDvpktxyyS4CSY=; b=3k8TTLG2w+lgUx zy3I+gRMuhQoVf7dXYcLcK7fB5ZUAW5n8IjAAi71uR6rnOxt92aQITYBFFgeloL6ncorCcDHU2+PY aS03KfulrPaRpWmwVnXgz9tAEvpLVAWxd6vCXqpK3I42/1DAO8/8ZnlVAuxutXKw5GbVmKyuu+AJb Pn+MgWF/VrxXYrSzzxSt3Gq5rT3cZg8a4VnIX0gScpiX+Rcont1k49Hi/PMDeAnN0ybcCfSxSjTZg 3WDAZoQQRQPbpnAx86L7RS+/RaSSL5Id2PUV95pcVKQxPZwuH7eWsec+6ZybxrhoOXMmG8XUS8xnB rfcGFnMoNIERlqu3QtNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwGoK-00000007LvT-1ncE; Mon, 15 Apr 2024 07:31:28 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwGoF-00000007LuJ-1mxP for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 07:31:26 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id F27BD1F91E; Mon, 15 Apr 2024 09:31:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1713166274; bh=9bgbSLn8w7LWy5U13HiOlSznXVfDMLIhp3YYmdC9IC4=; h=From:To:Subject; b=sJPN5/JZbaoZdLIEg+4BSESHRIS4CKUd8MKjoUxYZXmaxqMjX6ffqxhks8m7U4iaA dAuduXNt6fETQJUNZYO8Hd/wdDN6QVfYdzI7LQ1Bd4nmwvOre+7jL5sLe4PTk1x1IV NKScLbOZcajW9j+cfTzVCpBt62Yon39qkpKtLzPFD7mB2Kbxgc+JsY1tz1U1vs5eU4 uR/58k4ceTR2Agl+fMqwRlXZAskTppgpGxPQ0STKWa/z5a4zgN/VDtJFNNqLGM54bd yNYk3CD4D8nYsfmNmk3ayDNYNPpPDOWpC7waMcs6Ox1wUz11k37qInsgvqHRfFDhRh FqG+O3V+NT2/w== Date: Mon, 15 Apr 2024 09:31:10 +0200 From: Francesco Dolcini To: Udit Kumar Cc: nm@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kristo@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: Arranging mux and macro update Message-ID: <20240415073110.GA7360@francesco-nb> References: <20240415063329.3286600-1-u-kumar1@ti.com> <20240415063329.3286600-2-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240415063329.3286600-2-u-kumar1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_003124_551285_FE37E7DE X-CRM114-Status: UNSURE ( 8.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Mon, Apr 15, 2024 at 12:03:26PM +0530, Udit Kumar wrote: > Updating J784S4 macro for pin mux instead of J721S2. > > Also arranging pin mux in order of main_pmx0/1, wkup_pmx0/1/2/3 > along with fixing pin type for TX as output of wkup_uart. Are you doing a refactoring + fixes in the same commit or I misunderstood your commit message? If this is the case I would suggest to have separate commit for the fix and the refactoring, with the fix being first in the series and with a fixes tag. >From a quick look, this comment may apply to other commits in the series. Thanks, Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel