From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05981C4345F for ; Mon, 15 Apr 2024 22:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=My2W+AYNG6i2JmoSVpdJIm2Mh2zS3Pid1qH2HdDXo/Q=; b=tko/9Lr67AUcXo bAdRJ4WxlapNESij8LWaJf4dyTtpBrSz7IGBwElw0GjY4HjN7sctcub6ZcxDhfGzKDqMivecAodbR hgNYixp9Ck+MNsrA171WMdt1aY1dUf3OkfFisaAdx+GP5iImI8v068OVls54bTTmlO+/CAcS5ZZ8c Y7YPEnyXqVe02KWCYsJWFaWvX19yuo9BT9oNbJMlryIuVzGv1QrqwZJ4d4cHHlWxZyP8M25pwfwRd a1SAQpTRPJQ62kyxJT1ynIn54pLgpo+kQ7zHJ34p9gWYSp+hGE8519e1fIeoJr2A9KmexxJlQ071J 6ciKLXtnsY6m5EqxSmew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwUn9-0000000A4KW-1N5u; Mon, 15 Apr 2024 22:27:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwUn6-0000000A4Jw-3nne for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 22:27:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E322760BC3; Mon, 15 Apr 2024 22:27:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5171CC113CC; Mon, 15 Apr 2024 22:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713220026; bh=HEf/tRcjyvnch8G1vURup/zbc73d2ZJkc5OYcs0NKco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h6ic+DeJpJjMdu+ZMBmBoT1mHXbZwxdPlCBsMhKa3rEEQur6u5Togj2/sh4qQlIQG q56pEWUGzu3goJ0NNv8vDm/8M7pOhoVMrDxSsC+xEECSfaF09lO2uQ8Fkx5LOmOesX k5mQ3pxDOBgbWzRh0xoKRQlP+RDTbcAeS+43UEsuwL3n91R0UyWzq0VMY6GALF0Bwd +fljv149smnODNlWw2PMYlgrKHxoJxOOJOVZPz7ZJWXabT0AXSj63AikAnlbYaIXcU K4YfYeOd7Vz9quMI5fyUJJNMm6kZ2KR1fkWzPDbWpJdmwYNaOxfWC5ldodwIvp3jci HsTy1DHc1tCpQ== Date: Mon, 15 Apr 2024 17:27:04 -0500 From: Rob Herring To: Christophe Roullier Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] dt-bindings: net: add STM32MP13 compatible in documentation for stm32 Message-ID: <20240415222704.GA191094-robh@kernel.org> References: <20240411143658.1049706-1-christophe.roullier@foss.st.com> <20240411143658.1049706-2-christophe.roullier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240411143658.1049706-2-christophe.roullier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_152709_062132_21E7B298 X-CRM114-Status: GOOD ( 20.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2024 at 04:36:48PM +0200, Christophe Roullier wrote: > New STM32 SOC have 2 GMACs instances. > GMAC IP version is SNPS 4.20. > > Signed-off-by: Christophe Roullier > --- > .../devicetree/bindings/net/stm32-dwmac.yaml | 80 +++++++++++++++++-- > 1 file changed, 72 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > index 857d58949b029..20f58eff6e6f9 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -22,18 +22,17 @@ select: > enum: > - st,stm32-dwmac > - st,stm32mp1-dwmac > + - st,stm32mp13-dwmac > required: > - compatible > > -allOf: > - - $ref: snps,dwmac.yaml# > - > properties: > compatible: > oneOf: > - items: > - enum: > - st,stm32mp1-dwmac > + - st,stm32mp13-dwmac > - const: snps,dwmac-4.20a > - items: > - enum: > @@ -74,13 +73,16 @@ properties: > > st,syscon: > $ref: /schemas/types.yaml#/definitions/phandle-array > - items: > - - items: It is subtle, but the '-' there was significant... > - - description: phandle to the syscon node which encompases the glue register > - - description: offset of the control register > description: > Should be phandle/offset pair. The phandle to the syscon node which > - encompases the glue register, and the offset of the control register > + encompases the glue register, the offset of the control register and > + the mask to set bitfield in control register > + items: > + minItems: 2 > + items: Now you removed it, so any number of are allowed. You need: items: - minItems: 2 items: - ... > + - description: phandle to the syscon node which encompases the glue register > + - description: offset of the control register > + - description: field to set mask in register > > st,ext-phyclk: > description: > @@ -108,6 +110,34 @@ required: > > unevaluatedProperties: false > > +allOf: > + - $ref: snps,dwmac.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp1-dwmac > + - st,stm32-dwmac > + then: > + properties: > + st,syscon: > + items: > + minItems: 2 You mean 'maxItems: 2' as 2 is already the min. > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp13-dwmac > + then: > + properties: > + st,syscon: > + items: > + minItems: 3 > + > + > examples: > - | > #include > @@ -168,3 +198,37 @@ examples: > snps,pbl = <8>; > phy-mode = "mii"; > }; > + > + - | > + #include > + #include > + #include > + #include > + //Example 4 Not a useful comment. > + ethernet3: ethernet@5800a000 { > + compatible = "st,stm32mp13-dwmac", "snps,dwmac-4.20a"; > + reg = <0x5800a000 0x2000>; > + reg-names = "stmmaceth"; > + interrupts-extended = <&intc GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>, > + <&exti 68 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq", > + "eth_wake_irq"; > + clock-names = "stmmaceth", > + "mac-clk-tx", > + "mac-clk-rx", > + "eth-ck", > + "ptp_ref", > + "ethstp"; > + clocks = <&rcc ETHMAC>, > + <&rcc ETHTX>, > + <&rcc ETHRX>, > + <&rcc ETHCK_K>, > + <&rcc ETHPTP_K>, > + <&rcc ETHSTP>; > + st,syscon = <&syscfg 0x4 0xff0000>; > + snps,mixed-burst; > + snps,pbl = <2>; > + snps,axi-config = <&stmmac_axi_config_1>; > + snps,tso; > + phy-mode = "rmii"; > + }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel