From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37808C04FF9 for ; Tue, 16 Apr 2024 13:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=woi044uDyISLdawFZd69AIs05S1uXF1si75ngroLy1g=; b=HGv/VKLmYt46nu mluEatdeNLnRTgesx32i67wQK0pnvKNzFVEDQc3a6WbKREAJEUi3mPGHRnOwt1kIaB/TQjz/rONTl ytVm0dDirdDotyIvGq1pnZJBaJDcTTN/epKSoGqy0X3iDamiwzZmq0dO+OGRbY62rmxhv9VxTM/nV tg5oF6ElgRpM/mzWNVGf3cJmvrv8pr8KVI3H74pMUeQ0TrDs0G05Q0ovlUf6lgz5stWtVWPYghvnI +MqBwRGwV6/4QBC0/gJdGHirRnsJHaZMI5YL0eRC0Bv0g5IG8TpW7zwoVGxxiHSfDwlJ/r5LLIIU/ mVrt8hwy7pq40bIY7o8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwiWr-0000000CEhR-1VkN; Tue, 16 Apr 2024 13:07:17 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwiWj-0000000CEdw-3Bjs for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 13:07:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A8A62CE0D9A; Tue, 16 Apr 2024 13:07:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 846BDC113CE; Tue, 16 Apr 2024 13:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713272825; bh=P/HPomrIVTOMU1OFfPX9hmOeQB5uLwyIa2hpgQujMeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ecCh7swTXz2FNCSrCWahCDgRZzR2S5fOM+BKjrcQeqhCKxjKIOXC8HTyhJMP/1Xxv Dlk6Dx5qf6dBd1EYsJGjcJyUJsCtW3o1fUkXDwyGF4ldWQxC8cVs7NWPtZyEPHyjGv xZyjl9CPjG545ktRwmHoEDKlS4X0/iNruvm9Ra9fKDwgUWozbVkbziemqxGBcpzedH NAwXHZ73TCqN+/5V/rlspgwd770KttrbBla9S6V+iaHjFCtWhCeld+HswVGFMBtCBe A84KJ4m8GAE2fd7XRX80EvgO0Vm/IRutwVBoLC27wtKCOS+3Opj7yhMBp0anyQ2xm5 obeZUoLScCdrw== Date: Tue, 16 Apr 2024 08:07:03 -0500 From: Rob Herring To: Peng Fan Cc: "Peng Fan (OSS)" , Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , Cristian Marussi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 2/6] dt-bindings: firmware: add i.MX95 SCMI Extension protocol Message-ID: <20240416130703.GA1992329-robh@kernel.org> References: <20240412-imx95-bbm-misc-v2-v3-0-4380a4070980@nxp.com> <20240412-imx95-bbm-misc-v2-v3-2-4380a4070980@nxp.com> <20240412133400.GA2282201-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_060710_191730_9518803B X-CRM114-Status: GOOD ( 25.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 12, 2024 at 01:50:37PM +0000, Peng Fan wrote: > Hi Rob, > > > Subject: Re: [PATCH v3 2/6] dt-bindings: firmware: add i.MX95 SCMI > > Extension protocol > > > > On Fri, Apr 12, 2024 at 06:47:08PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > Add i.MX SCMI Extension protocols bindings for: > > > - Battery Backed Module(BBM) Protocol > > > This contains persistent storage (GPR), an RTC, and the ON/OFF button. > > > The protocol can also provide access to similar functions implemented via > > > external board components. > > > - MISC Protocol. > > > This includes controls that are misc settings/actions that must be exposed > > > from the SM to agents. They are device specific and are usually define to > > > access bit fields in various mix block control modules, IOMUX_GPR, and > > other > > > GPR/CSR owned by the SM. > > > > > > Signed-off-by: Peng Fan > > > --- > > > .../devicetree/bindings/firmware/arm,scmi.yaml | 21 +++++++++++++ > > > .../bindings/firmware/nxp,imx95-scmi.yaml | 36 > > ++++++++++++++++++++++ > > > 2 files changed, 57 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > index 93fb7d05f849..fa2cc910c485 100644 > > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > @@ -247,6 +247,27 @@ properties: > > > reg: > > > const: 0x18 > > > > > > + protocol@81: > > > + $ref: '#/$defs/protocol-node' > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + reg: > > > + const: 0x81 > > > + > > > + protocol@84: > > > + type: object > > > + anyOf: > > > + - allOf: > > > + - $ref: /schemas/firmware/nxp,imx95-scmi.yaml > > > + - $ref: '#/$defs/protocol-node' > > > > If you put the ref under the protocol node, then it's 1 schema file per protocol > > per vendor. Also, we then have to list every possible protocol node here, and > > every one listed here will be valid for every vendor. > > What we discussed is putting the list of vendor protocol schemas at the top- > > level here and then the vendor schemas can list out all the protocol nodes. > > > > Also, move "$ref: '#/$defs/protocol-node'" to nxp,imx95-scmi.yaml. > > In arm,scmi.yaml top level, add below: > +anyOf: > + - $ref: /schemas/firmware/nxp,imx95-scmi.yaml > > And also add a protocol node: > protocol@84: > $ref: '#/$defs/protocol-node' > > properties: > reg: > const: 0x84 > But here I not add unevaludatedProperties = false; otherwise the vendor > yaml new properties will not work. Just drop 'protocol@84' entirely here and change the top-level additionalProperties to unevaluatedProperties. > > In nxp,imx95-scmi.yaml: > properties: > protocol@84: > $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > unevaluatedProperties: false > > properties: > reg: > const: 0x84 > > nxp,wakeup-sources: > description: > Each entry consists of 2 integers, represents the source and electric signal edge > items: > items: > - description: the wakeup source > - description: the wakeup electric signal edge Constraints on the items values? > minItems: 1 > maxItems: 32 > $ref: /schemas/types.yaml#/definitions/uint32-matrix > > additionalProperties: true > > Are the upper looks good to you? Yes, other than the one comment. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel