From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C190C4345F for ; Wed, 17 Apr 2024 15:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EFe1fopPLyxmKCyzOlS5UBe7saABvAg6phJF0Yk8s50=; b=MEIKIkPCQArkO4NkvPhDcTnjyQ ESE+ZcELqF+90njI4BuVB9LqfGwXuw0KvDKaJR+tkTFBiqsa6lhbUzharxYhgzDDqUcW5mCSdXXS5 aiHgFaOOjGMla1K8fN3YQ9TALEOG85iCCVD8qL1xD7S5JeBP1qmuGe/4W1DnGoOEY3ZwMpLsFcEPt lACvZmZ4DXhWN5a02KBKKXzd0GYboZNNpus41Itao92OavnsqQ5eqGiESwyESqBIeEIPIPqKcoeoH 3fs0my0N7unSvZiD5lIVTgeL6FuVGYhEppLAydfDR9naADjP2BKL5I8Op62G1J4CYHRCdcGsGKVlK gwKMTcPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7Ae-0000000GZw9-1CMS; Wed, 17 Apr 2024 15:26:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7Ab-0000000GZvH-1UWU; Wed, 17 Apr 2024 15:25:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4DF25614F1; Wed, 17 Apr 2024 15:25:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59CC0C072AA; Wed, 17 Apr 2024 15:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713367556; bh=ExXTOF7E2XdRHFoRRHZlQyZt3AaGPH9qv/wKJ86w0aE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kNpCaVGIeW6zkJSGxSCih9gQp5PXISQazsi9Clc9Jd3NQ/N7OQGwS5G5BTJ+zKT4a SY/jEobOaSwYc6BWACjYEw/4PkI1y/942ZEt4W4YPveRlJeuyJZ4w4ZXduuh0oDMg+ ACG9FQ8PVJN+KoKh76tUmSpnD94ZhkqydM//fnoB5Z0ZJqt90YxUvTP+tvPkGQz/ha N/6hNXHNtjHGwiWtyTpuGGeKyyr7KR7Ni7YNcjLqWfIWrGIW7BayDO/XumA6XHCB4S /zOIq4m4LxdMfbKoM3KQzj15vxRe5r1HYS3kPOyv3oR+nfXFhySvPa3W6d41zO9jPU GFARGCzD0twLQ== Date: Wed, 17 Apr 2024 16:25:50 +0100 From: Conor Dooley To: AngeloGioacchino Del Regno Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com Subject: Re: [PATCH v1 1/6] dt-bindings: soc: mediatek: Add DVFSRC bindings for MT8183 and MT8195 Message-ID: <20240417-fame-cotton-c5c6d40c003d@spud> References: <20240416153805.431118-1-angelogioacchino.delregno@collabora.com> <20240416153805.431118-2-angelogioacchino.delregno@collabora.com> <20240416-grope-blissful-a914854b3732@spud> <20240416-onion-prone-44b45d5a003e@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_082557_518942_382EB452 X-CRM114-Status: GOOD ( 40.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1391933267895219232==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1391933267895219232== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tUWCs0nZ7Ll4Hx8L" Content-Disposition: inline --tUWCs0nZ7Ll4Hx8L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 17, 2024 at 10:26:06AM +0200, AngeloGioacchino Del Regno wrote: > Il 16/04/24 19:30, Conor Dooley ha scritto: > > On Tue, Apr 16, 2024 at 06:28:58PM +0100, Conor Dooley wrote: > > > On Tue, Apr 16, 2024 at 05:38:00PM +0200, AngeloGioacchino Del Regno = wrote: > > > > Add bindings for the MediaTek Dynamic Voltage and Frequency Scaling > > > > Resource Collector (DVFSRC), a hardware module used to collect all = the > > > > requests from both software and the various remote processors embed= ded > > > > into the SoC and decide about a minimum operating voltage and a min= imum > > > > DRAM frequency to fulfill those requests in an effort to provide the > > > > best achievable performance per watt. > > > >=20 > > > > This hardware IP is capable of transparently performing direct regi= ster > > > > R/W on all of the DVFSRC-controlled regulators and SoC bandwidth kn= obs. > > > >=20 > > > > Signed-off-by: AngeloGioacchino Del Regno > > > > --- > > > > .../soc/mediatek/mediatek,mt8183-dvfsrc.yaml | 57 ++++++++++++++= +++++ > > > > 1 file changed, 57 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek= /mediatek,mt8183-dvfsrc.yaml > > > >=20 > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediate= k,mt8183-dvfsrc.yaml b/Documentation/devicetree/bindings/soc/mediatek/media= tek,mt8183-dvfsrc.yaml > > > > new file mode 100644 > > > > index 000000000000..12bcc3fdfd07 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mt818= 3-dvfsrc.yaml > > > > @@ -0,0 +1,57 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/soc/mediatek/mediatek,mt8183-dv= fsrc.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: MediaTek Dynamic Voltage and Frequency Scaling Resource Col= lector (DVFSRC) > > > > + > > > > +description: > > > > + The Dynamic Voltage and Frequency Scaling Resource Collector (DV= FSRC) is a > > > > + Hardware module used to collect all the requests from both softw= are and the > > > > + various remote processors embedded into the SoC and decide about= a minimum > > > > + operating voltage and a minimum DRAM frequency to fulfill those = requests in > > > > + an effort to provide the best achievable performance per watt. > > > > + This hardware IP is capable of transparently performing direct r= egister R/W > > > > + on all of the DVFSRC-controlled regulators and SoC bandwidth kno= bs. > > > > + > > > > +maintainers: > > > > + - AngeloGioacchino Del Regno > > > > + - Henry Chen > > > > + > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - items: > > >=20 > > > This items should not be needed with the enum, right? > > >=20 >=20 > Whoops. Yep items is not needed. >=20 > > > > + - enum: > > > > + - mediatek,mt8183-dvfsrc > > > > + - mediatek,mt8195-dvfsrc > > > > + - items: > > > > + - const: mediatek,mt8192-dvfsrc > > > > + - const: mediatek,mt8195-dvfsrc > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + description: DVFSRC common register address and length. > > > > + > > > > +patternProperties: > > > > + "@[0-9a-f]+$": > > > > + type: object > > >=20 > > > Why is there no enforcement of what a child could be here? > >=20 > > Seems like you know exactly what the children are: regulators and an > > interconnect? What am I missing? > >=20 >=20 > I wasn't sure whether that would've been a good idea, given that there wi= ll > be more possible children in the future - as in - more drivers that need = the > DVFSRC communication. If there's no additional hardware, just additional drivers wanting to use this, there's no need to modify the dt, you just call platform_device_register() to spin up the new drivers. > But anyway yes, for now, it's just the regulator and interconnect drivers. We can always free it up whenever new requirements appear. > > > > +required: > > > > + - compatible > > > > + - reg > > > > + > > > > +additionalProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + soc { > > > > + #address-cells =3D <2>; > > > > + #size-cells =3D <2>; > > > > + > > > > + dvfsrc@10012000 { > > >=20 > > > "dvfsrc" looks like something my (imaginary given allergies) cat would >=20 > (allergies: ugh, same here - feel you) >=20 > > > produce from sitting on my keyboard. Could you use full words for the > > > node name and make it something that attempts to be generic please? > > >=20 >=20 > I'm not entirely sure that I can find a generic name for this... I wonder= if > "remoteproc" could work - as this is a remote processor (a MCU, actually). >=20 > To give you context, this doesn't need firmware to be loaded, and does no= t have > any remoteproc driver. I dunno, I don't think having to load firmware to something or interact with a remoteproc driver in linux changes what the hardware actually is. >=20 > Because then, I don't think that "performance-controller" would be correc= t, > even though I have this N.2 choice... ideas? My lot call this type of thing a "system controller" in our specs. Any of firmware, remote-processor, performance-controller all seem valid to me. > Cheers, Cheers, Conor. --tUWCs0nZ7Ll4Hx8L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZh/p/gAKCRB4tDGHoIJi 0lEeAP9ODgsxAxqY6EugFK0v+xBoTRrFSYYNmBEiyjKsBl58iwEApvmNdrMatUuk K3JRuZZ5UsqYCh5o+lFttCQJm55Rugk= =bY+B -----END PGP SIGNATURE----- --tUWCs0nZ7Ll4Hx8L-- --===============1391933267895219232== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1391933267895219232==--