From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E593EC4345F for ; Wed, 17 Apr 2024 14:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GIz1r3NEAm8fTDkvaxVf0YmE0wk/ZaQalqiiWnnwU3c=; b=xbtZIx1iDVQ7Wc 5W+J6c4RSS+vuX+dZEe5xASyFHD/coY/GRvRbYI8G00ZsaDnRuadvmwFoHzG1s3SQmCHp/YfphmM8 unIIcHpf5D76COAnX+yPpTAR6FmPCMpBCWeFe3v90zMxQPgQZDynG3qeldG8+jE45SxrVOzx77GHR wJXYwgw2Prl2KI4V85ivzIMbNV0vxjBM5UGq2D1NrIyE0cFUzZu+88fQUZBtgwmZORE2dFiPomhf/ AlbobnFj0G17Gb6B8f7pgfFGB3HIf5VDKgXba+kR0RvdFwfdQNUG1Xc2V01du/0tX1CdMvrBXsxIp 5QCWu3r+5x8+guzP90RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx6U8-0000000GOWW-3gxK; Wed, 17 Apr 2024 14:42:04 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx6U4-0000000GOQB-1Ofs for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 14:42:02 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VKNlG239gz6D8ym; Wed, 17 Apr 2024 22:36:42 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 09442140B38; Wed, 17 Apr 2024 22:41:40 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 15:41:39 +0100 Date: Wed, 17 Apr 2024 15:41:38 +0100 From: Jonathan Cameron To: "Russell King (Oracle)" CC: Thomas Gleixner , Peter Zijlstra , , , , , , , , , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Ingo Molnar , Borislav Petkov , Dave Hansen , , , Subject: Re: [PATCH v6 02/16] cpu: Do not warn on arch_register_cpu() returning -EPROBE_DEFER Message-ID: <20240417154138.0000511b@Huawei.com> In-Reply-To: References: <20240417131909.7925-1-Jonathan.Cameron@huawei.com> <20240417131909.7925-3-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_074200_604273_DF52EC0E X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 17 Apr 2024 15:01:33 +0100 "Russell King (Oracle)" wrote: > On Wed, Apr 17, 2024 at 02:18:55PM +0100, Jonathan Cameron wrote: > > For arm64 the CPU registration cannot complete until the ACPI > > interpreter us up and running so in those cases the arch specific > > arch_register_cpu() will return -EPROBE_DEFER at this stage and the > > registration will be attempted later. > > > > Suggested-by: Rafael J. Wysocki > > Acked-by: Rafael J. Wysocki > > Signed-off-by: Jonathan Cameron > > > > --- > > v6: tags > > --- > > drivers/base/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > > index 56fba44ba391..b9d0d14e5960 100644 > > --- a/drivers/base/cpu.c > > +++ b/drivers/base/cpu.c > > @@ -558,7 +558,7 @@ static void __init cpu_dev_register_generic(void) > > > > for_each_present_cpu(i) { > > ret = arch_register_cpu(i); > > - if (ret) > > + if (ret != -EPROBE_DEFER) > > pr_warn("register_cpu %d failed (%d)\n", i, ret); > > This looks very broken to me. > > if (ret && ret != -EPROBE_DEFER) > > surely, because we don't want to print a warning if arch_register_cpu() > was successful? Gah. Excellent point. thanks, Jonathan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel