From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4AE1C4345F for ; Thu, 18 Apr 2024 11:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/P917Scs0hpK+noE8ChsUnkgVqgaqFR/mPLbqXiroaI=; b=Yc134EdqOsoopb V+eDjHhIeu2FsZlcy4KHLmUvD56laO/e2r+GphTAO1KT0pyzB7kccndXVuonoupbCirbwi/ikNOuw A9Xpo4Ojkyvdn/Hpm4S3Z7yy+HdRbs4T6lGWfRYjM2aEpfHEerk3u/CNz8fRug9daEyfVkUEQ2elq lVQ+JWaWNbCLXYwKKnMCe1zU/U8+01eSDzdl4Hgm6/3SudS47bL9XU7HxyizQGl5vZE55yec1tmOh XKjzBZEJHrX9Dl1tuvEm3pQwgg0dknWN2irzrstGqf+wqHTk6dDdahtA9s+mmSvS8rgo/7pj4uXBC 3rDLcJSRktbio7dpJFfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxPl8-00000001xus-1I14; Thu, 18 Apr 2024 11:16:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxPl6-00000001xuO-0A5h for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 11:16:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E13D2339; Thu, 18 Apr 2024 04:17:16 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A2CB3F792; Thu, 18 Apr 2024 04:16:46 -0700 (PDT) Date: Thu, 18 Apr 2024 12:16:42 +0100 From: Andre Przywara To: "Ryan Walklin" , "Viresh Kumar" Cc: "Yangtao Li" , "Viresh Kumar" , "Nishanth Menon" , "Stephen Boyd" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, "Brandon Cheo Fusi" , "Martin Botka" , "Martin Botka" , "Chris Morgan" , "Mark Rutland" , "Lorenzo Pieralisi" , "Sudeep Holla" Subject: Re: [PATCH v4 0/8] cpufreq: sun50i: Add Allwinner H616 support Message-ID: <20240418121642.53208fab@donnerap.manchester.arm.com> In-Reply-To: <0e021133-f8c1-457d-9079-d9c972e0e69b@app.fastmail.com> References: <20240329141311.27158-1-andre.przywara@arm.com> <20240404064027.shjqvqih7s5rnv2i@vireshk-i7> <0e021133-f8c1-457d-9079-d9c972e0e69b@app.fastmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_041652_175138_71C1DDBE X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 04 Apr 2024 20:44:02 +1300 "Ryan Walklin" wrote: Hi Viresh, Ryan, > On Thu, 4 Apr 2024, at 7:40 PM, Viresh Kumar wrote: > > Is it okay to merge all the changes via the cpufreq tree ? > > I have tested this series with an H700-based board, and have at least one speed-bin (1.032GHz) is not supported although the governor attempts to enable it based on the opp-supported-hw bitmask, and I am unable to reach the 1.5GHz bin at 1.16v (or higher) despite it working on the vendor BSP (kernel panic at boot if enabled), so this may need some slight rework. > > I have reached out to Andre on IRC to debug. So those test results look odd, especially since it seems to work on the BSP. I don't want to jeopardise this series over the oddity on this variant, so I am dropping the H700 specific speed bin for now. Not directly matching any known SoC variant now, it will fall back to bin 0, which gives us some safe values. We lose the highest OPP (1.5 GHz), but this was exactly the problematic one in the testing, so it's not a great loss. Once we have worked out what's really going on there, we can easily add a well tested OPP set later, to get the 1.5 GHz back. Will send a v5 shortly. Cheers, Andre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel