From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6498C4345F for ; Fri, 19 Apr 2024 11:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=84ZRxrx0nv50DQkQLwJledNhguJZldIW/N0Ppl/zM5M=; b=JOlzJsoBSyjkjh ItMjQd43Yk7lYHh6yrHlFfSd/+hbd2TqF1HdPDi2qo9KnFAeOAf0ychWKfxTSCkfFFwivDGfF1GRy k0sbQSRuazcCg7zoZ1o6KgHCAREYnjuHsbGA6B95C3CjFEgwWfTdRugSSh3xYl1Ruj2+u42M3g8H/ hkqw8X69paQ0ExwTCEGUk1KCGc0siiQQqgmOfYF4dwr0HcW3CyrPaddYlLM0a1CynJfu8upfIVH0D +IpLOQvhKise3A6zXt/cbRYu0iMx5z+vLONpKzopu75RAhExdyLsjkQmW9PUOeAAyyc+vKg1N9rRb iKRKvBHhiKp5UXdKwgLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxm3W-00000005P4P-3GjJ; Fri, 19 Apr 2024 11:05:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxm3S-00000005P1v-1PGc for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2024 11:05:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E812F61921; Fri, 19 Apr 2024 11:05:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E2AC072AA; Fri, 19 Apr 2024 11:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713524716; bh=wOUo2++bYvOhHtA/1yKJ+lIawhgs+4qJQ+CoecAxzKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDY7u55wKa7tKq9U/6vZr38Np7ow1VOp99BWoLgocxm2uWiDfyEh9Dsk8vZXHzZkz Q0m24GX9jFlUdmh4oONI+68B20HmzlRA4Xsc0BlhOJxU1cjIRqXTin+etPgdMXKDMv K3GPdXbZApY6JvwNKf9mLSDW2aplgZgxJr5447fo= Date: Fri, 19 Apr 2024 13:05:03 +0200 From: Greg Kroah-Hartman To: Marc Zyngier Cc: Catalin Marinas , Naresh Kamboju , Mark Brown , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, Yihuang Yu , Gavin Shan , Ryan Roberts , Anshuman Khandual , Shaoqin Huang , Will Deacon , linux-arm-kernel@lists.infradead.org, Anders Roxell Subject: Re: [PATCH 6.6 000/122] 6.6.28-rc1 review Message-ID: <2024041954-replica-deflation-73b5@gregkh> References: <20240415141953.365222063@linuxfoundation.org> <86y19dqw74.wl-maz@kernel.org> <86sezjq688.wl-maz@kernel.org> <2024041921-drown-dizzy-7481@gregkh> <86r0f1r5i1.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86r0f1r5i1.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_040518_548765_CD887D45 X-CRM114-Status: GOOD ( 37.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 19, 2024 at 11:50:14AM +0100, Marc Zyngier wrote: > On Fri, 19 Apr 2024 11:40:33 +0100, > Greg Kroah-Hartman wrote: > > > > On Thu, Apr 18, 2024 at 12:21:17PM +0100, Catalin Marinas wrote: > > > On Thu, Apr 18, 2024 at 12:07:35PM +0100, Marc Zyngier wrote: > > > > On Tue, 16 Apr 2024 18:28:10 +0100, > > > > Catalin Marinas wrote: > > > > > On Tue, Apr 16, 2024 at 02:22:07PM +0100, Marc Zyngier wrote: > > > > > > On Tue, 16 Apr 2024 14:07:30 +0100, > > > > > > Naresh Kamboju wrote: > > > > > > > On Tue, 16 Apr 2024 at 16:04, Mark Brown wrote: > > > > > > > > On Mon, Apr 15, 2024 at 04:19:25PM +0200, Greg Kroah-Hartman wrote: > > > > > > > > > This is the start of the stable review cycle for the 6.6.28 release. > > > > > > > > > There are 122 patches in this series, all will be posted as a response > > > > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > > > > let me know. > > > > > > > > > > > > > > > > The bisect of the boot issue that's affecting the FVP in v6.6 (only) > > > > > > > > landed on c9ad150ed8dd988 (arm64: tlb: Fix TLBI RANGE operand), > > > > > > > > e3ba51ab24fdd in mainline, as being the first bad commit - it's also in > > > > > > > > the -rc for v6.8 but that seems fine. I've done no investigation beyond > > > > > > > > the bisect and looking at the commit log to pull out people to CC and > > > > > > > > note that the fix was explicitly targeted at v6.6. > > > > > > > > > > > > > > Anders investigated this reported issues and bisected and also found > > > > > > > the missing commit for stable-rc 6.6 is > > > > > > > e2768b798a19 ("arm64/mm: Modify range-based tlbi to decrement scale") > > > > > > > > > > > > Which is definitely *not* stable candidate. We need to understand why > > > > > > the invalidation goes south when the scale go up instead of down. > > > > > > > > > > If you backport e3ba51ab24fd ("arm64: tlb: Fix TLBI RANGE operand") > > > > > which fixes 117940aa6e5f ("KVM: arm64: Define > > > > > kvm_tlb_flush_vmid_range()") but without the newer e2768b798a19 > > > > > ("arm64/mm: Modify range-based tlbi to decrement scale"), it looks like > > > > > "scale" in __flush_tlb_range_op() goes out of range to 4. Tested on my > > > > > CBMC model, not on the actual kernel. It may be worth adding some > > > > > WARN_ONs in __flush_tlb_range_op() if scale is outside the 0..3 range or > > > > > num greater than 31. > > > > > > > > > > I haven't investigated properly (and I'm off tomorrow, back on Thu) but > > > > > it's likely the original code was not very friendly to the maximum > > > > > range, never tested. Anyway, if one figures out why it goes out of > > > > > range, I think the solution is to also backport e2768b798a19 to stable. > > > > > > > > I looked into this, and I came to the conclusion that this patch is > > > > pretty much incompatible with the increasing scale (even if you cap > > > > num to 30). > > > > > > Thanks Marc for digging into this. > > > > > > > So despite my earlier comment, it looks like picking e2768b798a19 is > > > > the right thing to do *if* we're taking e3ba51ab24fd into 6.6-stable. > > > > > > > > Otherwise, we need a separate fix, which Ryan initially advocating for > > > > initially. > > > > > > My preference would be to cherry-pick the two upstream commits than > > > coming up with an alternative fix for 6.6. > > > > To be specific, which 2 commits, and what order? > > That'd be: > > e2768b798a19 ("arm64/mm: Modify range-based tlbi to decrement scale") > > followed by: > > e3ba51ab24fd ("arm64: tlb: Fix TLBI RANGE operand") Thanks, now queued up. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel