From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5054AC4345F for ; Sat, 20 Apr 2024 10:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V966YLIVF9QIBJffV5I5WEHuf8C7+CjRjGApxUxyjbw=; b=Z1zRRrQKKxWbXF rL66b2eJPwOD6bfQ6V6k4vS4EiSzO7TSo6BeYQZAAMDrtHYTwPBD6KBxyyVgI5kCCmn7wEo+8ZUPK CoIEkyZSmjDwe/f4upm4wE8rU0dndZN+6IYfTZUGsnuucAKUm3r4aLDl32jwTwIIzZBcyhaL+hJVg CCr2AgrYT5zp/zMZF6TxNU2KH8HNhf583AISCoT4qG5ectxibff3u1EmyVPVI1MhcyLm/ybJ1isw8 iF8hNsE61MtIl1Ef4zywW3U2SnrVJLxdGAzViyamBKhzWFyEFsGXoc7aRsjqnX9fk5rdjF1iqyDzl 3MwFMhfuoW60VWcNqD8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry8Mh-00000008KXY-1uIL; Sat, 20 Apr 2024 10:54:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry8Me-00000008KVp-2N0X for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 10:54:38 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F81F1A2; Sat, 20 Apr 2024 12:53:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1713610420; bh=oOOjWnG8y8qjRys3yjCEii5n6nxTX+J51/N+FQTnwfM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OXsCBWAg+5xLe3UZNmSUijKujjQgcdKsdcj+GvTyPgj/etsTrFuFjpzSMkFRRWj+3 9uJOrKLzzTu6xPbLILf4YDy6Q2HS3wihF4LyUYy+Ajor0pKd2hqGs1ncc2nXwzQzyL 2M+siWUj4/MKyGzQ+dhArhZQFw5EqHyamrdRRazA= Date: Sat, 20 Apr 2024 13:54:20 +0300 From: Laurent Pinchart To: Stefan Wahren Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2] staging: vc04_services: vchiq_arm: Fix NULL ptr dereferences Message-ID: <20240420105420.GF6414@pendragon.ideasonboard.com> References: <20240420091240.9552-1-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240420091240.9552-1-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_035436_980061_527FD623 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Thank you for the patch. On Sat, Apr 20, 2024 at 11:12:40AM +0200, Stefan Wahren wrote: > The commit 8c9753f63905 ("staging: vc04_services: vchiq_arm: Drop > g_cache_line_size") introduced NULL pointer dereferences by > using the wrong device. > > Fixes: 8c9753f63905 ("staging: vc04_services: vchiq_arm: Drop g_cache_line_size") > Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart > --- > > Changes in V2: > - drop cosmetic changes as noticed by Laurent > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 502ddc0f6e46..c06232fcb0fb 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -257,7 +257,7 @@ create_pagelist(struct vchiq_instance *instance, char *buf, char __user *ubuf, > if (count >= INT_MAX - PAGE_SIZE) > return NULL; > > - drv_mgmt = dev_get_drvdata(instance->state->dev->parent); > + drv_mgmt = dev_get_drvdata(instance->state->dev); > > if (buf) > offset = (uintptr_t)buf & (PAGE_SIZE - 1); > @@ -436,7 +436,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel > > dev_dbg(instance->state->dev, "arm: %pK, %d\n", pagelistinfo->pagelist, actual); > > - drv_mgmt = dev_get_drvdata(instance->state->dev->parent); > + drv_mgmt = dev_get_drvdata(instance->state->dev); > > /* > * NOTE: dma_unmap_sg must be called before the -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel