Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments

From: Daniel Machon <daniel.machon@microchip.com>
To: Simon Horman <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Bryan Whitehead <bryan.whitehead@microchip.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
Date: Sat, 20 Apr 2024 19:24:24 +0000	[thread overview]
Message-ID: <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> (raw)
In-Reply-To: <20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org>

Hi Simon,

> -/* Convert validation error code into tc extact error message */
> +/* Convert validation error code into tc exact error message */

This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
the fix should be 'extack' instead.

>  void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
>  {
>         switch (vrule->exterr) {
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> index 56874f2adbba..d6c3e90745a7 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
>  /* Copy to host byte order */
>  void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> 
> -/* Convert validation error code into tc extact error message */
> +/* Convert validation error code into tc exact error message */

Same here.

>  void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule);

The other fixes seems correct.

/Daniel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel