From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACCDDC4345F for ; Sun, 21 Apr 2024 13:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1QG4tTRLkJakOiWHS/noahOSrToC2yxEa6sFdwheNlo=; b=QjoH6kmwo9Vxlo PkuKyXetzYFBRghqA5zVgsF7G+OHNza+vHyQJB0Ai5X8TSfKLFzNwP13bmLHRDHK925YjiqV9wo1J P4ufFushlmp7B059P7qoKlDbo8DcEJcxUL1J7mLr4kpjfIdJht4ekoXzZmMiXtVH1ySBrpZiepAND hAssCCd7ldimvr60PYcqP0g//H9X3AAgizwAb9Dhah86J4qz7MAYHxcSVwvLHV0Svim2wTfE5fKmq EaBFz55NFbY0r57ONea79jLxnNEuWKAfXdRrT1FYwxKE95Y7uC8wBke9LtTdjxsQtNMyr/2F0wFr7 IzZtUyrVp2lc4BWweItw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryXYq-0000000AavK-3UO3; Sun, 21 Apr 2024 13:48:52 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryXYj-0000000Aaqf-3kBg for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2024 13:48:47 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6ed2dc03df6so3177016b3a.1 for ; Sun, 21 Apr 2024 06:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713707324; x=1714312124; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CFH817ciebpwZm5RIvkd4+jbnHC/S06VW05vaHkc95Y=; b=CVAOXhjN2DWiNJ853hls8gp3YrNxOCKTcZxgNNYMG1wycdBMvxPA/A7r5XTsEjUvmr CZpMkPtyqFijonPbiAoE6X9lcxc/zi5CINdUuOdWshYlbQQu5ccwAZEJBwmUb6S/xYSv nICSy3KG7Rf1V8eknwKnCNFK9gh7xc7pLWsGJsocZMNtnY6gUTjmdIXzp5xhN84BqEZg aRKse0Bikml1sBRCa8nsR/8Kt73/f3oEGjchgg+Uff6s5kRF6Px40ZlrFoNhBgwOck8P cK7sUyLxDSNCxoOIi4Yk4WQtg3ljpt+4vbTq66mZ127k37eHKxy5g1c26uO85xafPlpp ZfdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713707324; x=1714312124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CFH817ciebpwZm5RIvkd4+jbnHC/S06VW05vaHkc95Y=; b=raPdHeGWrgz0vGHrnHm9J4rzIP8IHMGbCooVpL1pM9Yi9p9RvCwHD3TYtOTrifrDow q15I0ReDgXfwIYY+MQ1czNNssBIJexIbwN0bs23iAnW3KNC18CJBl50x2Q9m3wjdPx+w 62Z7TfwhVqGifUeIa4tYEfwKUHEwyESOn/000enbxKkK6nWCQQUeePtE2pKPf20s5Aya jTPBQKJtLZ3M81P+8TCBzft8vHLRCIrOyQ/GmiHTJgqeu6n/AXRMz8Fb0cYr4r7WrlHa 6aB8jQ0l72okK3tFh00b03/xjxW/RIA7crq+1hFwNARivoTwN+pIoj11SV8tnaidGWjZ JGbw== X-Forwarded-Encrypted: i=1; AJvYcCXTTqLUOU6hxW0nLYRCaNjF98WNy+NoJUZQL8ouufAi7qzX7NgogatHwmraRApa39RCRbF78xvb7JMMJxi7LNazucOu63BjL68nOczUASZ0/m2qzns= X-Gm-Message-State: AOJu0YyBdUHTWIdnDOiPhEA6+lBztTYYKkf8DRGeLocKav7ZydNT5iTM 6Pk/u/v188LklFxzvo9WFhtUBLtwj0VqBK/ZKK3LffvsgH5NVA9t X-Google-Smtp-Source: AGHT+IGBTkJIFfQemhLvAqEPk4jeBsCkiyNthhoIPYS3OEp203fcQuznnALtMlwF0yGaNj9W4OwFNQ== X-Received: by 2002:a05:6a00:10d1:b0:6ea:9252:435 with SMTP id d17-20020a056a0010d100b006ea92520435mr9937740pfu.30.1713707324572; Sun, 21 Apr 2024 06:48:44 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id o13-20020a056a001b4d00b006e6c733bde9sm6175043pfv.155.2024.04.21.06.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 06:48:44 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/5] usb: ohci-exynos: Use devm_clk_get_enabled() helpers Date: Sun, 21 Apr 2024 19:17:32 +0530 Message-ID: <20240421134752.2652-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240421134752.2652-1-linux.amoon@gmail.com> References: <20240421134752.2652-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240421_064846_000490_F89F397E X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Reviewed-by: Alan Stern Signed-off-by: Anand Moon --- v4 : Add reviewed by Alan Stern v3: drop dev_err_probe to simplify the error handle. v2: new patch in this series --- drivers/usb/host/ohci-exynos.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 20e26a474591..89e6587c089b 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -135,20 +135,16 @@ static int exynos_ohci_probe(struct platform_device *pdev) err = exynos_ohci_get_phy(&pdev->dev, exynos_ohci); if (err) - goto fail_clk; + goto fail_io; - exynos_ohci->clk = devm_clk_get(&pdev->dev, "usbhost"); + exynos_ohci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost"); if (IS_ERR(exynos_ohci->clk)) { dev_err(&pdev->dev, "Failed to get usbhost clock\n"); err = PTR_ERR(exynos_ohci->clk); - goto fail_clk; + goto fail_io; } - err = clk_prepare_enable(exynos_ohci->clk); - if (err) - goto fail_clk; - hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hcd->regs)) { err = PTR_ERR(hcd->regs); @@ -191,8 +187,6 @@ static int exynos_ohci_probe(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); pdev->dev.of_node = exynos_ohci->of_node; fail_io: - clk_disable_unprepare(exynos_ohci->clk); -fail_clk: usb_put_hcd(hcd); return err; } @@ -208,8 +202,6 @@ static void exynos_ohci_remove(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); - clk_disable_unprepare(exynos_ohci->clk); - usb_put_hcd(hcd); } -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel