From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDD52C04FF8 for ; Sun, 21 Apr 2024 13:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3igFiO1M1hhP5nrD6ufIx5WrHO3Owf1J56qVKZ4K8U=; b=PKTim5UoVq/v0/ Iqoti+VW2rZ/fYMAzoF8Ue3CT6NU7LZz1Myv0NVXcsOcjdk4oUyK4xqnxMWSd4KMQmCmv/x5LdWru TnJZ8SFvSKtsFprlSP6MGZnVd8/xTkAmqvnkUSRn7ps0wFJXgtyW/jO7UwV3PUOwloJLxjLycfAtv +zHqKDIbVtXQa8mLJQyIpiiyY5pmyKPE/UHuE6ijQ/bI7gTZGJbKAKfUp8lhm6Ocno9FIFKgaLCem IuVj5bXy3Qrndk1754ZM4md7Xcb1zQQuDBwUmROZQLvTnZTs9YGNMaC+GxxBftatzX2BYt6C1ObQb bczTpUHP1SfI+0UQDiFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryXZ2-0000000Ab2F-0pEv; Sun, 21 Apr 2024 13:49:04 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryXYy-0000000Aayx-1Def for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2024 13:49:01 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6ed04c91c46so3506038b3a.0 for ; Sun, 21 Apr 2024 06:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713707338; x=1714312138; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vAq3AHvWEQFsKDgpu//rdmbRIcBJ6dLOs4RYotedEeg=; b=RCiurjO6mymUJ+1wxf/vSjvcaUt0+LXl0sv5ig/IlEfjIoEh3dEBDe4/LPtl4mjW0P quzcZSWoXnYt/vOo29J0VMEGGoZW05WatKUASCvxzGhXBJHB8dyb+wFOQMHNjAD/4fDV 5wNchYCpUbaGOEV7gPCghCrrzxJyaI3CJatMSocMIiwVgKP3YnSNwgaoVtaxYEnX0H+a hbYnuPYqlQL49xAnm5w5H8mbXOu69Rp+8zy5VV65kXAgvijJPCqh13k1mRfV8M5xn987 sZx1PChM9NyXnBVMxlAfClO+twUAzY3Q0vuN1V1SKTdgiZs9YtkD1dIA2F60ywCyDNoe K+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713707338; x=1714312138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vAq3AHvWEQFsKDgpu//rdmbRIcBJ6dLOs4RYotedEeg=; b=RwQE4rPMLTe9kh4QrWlSlGKTO1EV4eMtvUo1XnmiLvnWZjzp/zBsVsg0gUgvX6yEc6 chwa0aBLWr1VnmC+wFS/iE/QaY18jzO+fUvvjwWGYa5X8trnvRgz5VHLMGZrkTtshWQ/ YDs9eGP5Qm8bLC3suzc2UKlskyEDAr1NecQM1SqrQkaX/ArTsHpVIDYxEJ+W7/3ZyaJC qSwglHnISqlb3CPqg57Hs9xNE23MziZxC9IGx0MRK9DrCQaX354Zx3TtUb8/xaZx+lBI NL6WfuGrpkkl323CrB5WTum3kQ/yNOZgcG2dx1+25CXPm0uJDTzgk/FnUAJxqLtX8PTO t4SQ== X-Forwarded-Encrypted: i=1; AJvYcCWhBXhGMCbSpUlSCJcogBu6rOXl299uHJ89AfWV7hwIjTLniA7wFIRopyGtkIHBDVKaV11moBSsvxsiICI4Sqp4oJ4fj96y824A9Slxrk/vYzFNj1k= X-Gm-Message-State: AOJu0YwydXicIDD+ysWWdJiDCKq1rFtoF4E1F0exhQOiPgmaNdTmHrhO oO98I2k65VIf8ieiV+pLuqVJg9/UVBVW6U7/3IrZFzMvs+pZmhbI X-Google-Smtp-Source: AGHT+IFqFGNGrYSxduO+G3kiUy/CR5IuQrcVEgPwVltGpWh2slVvuWUY98I8IosXloAx10/SaETCIw== X-Received: by 2002:aa7:8883:0:b0:6ea:bf1c:9dfd with SMTP id z3-20020aa78883000000b006eabf1c9dfdmr10512702pfe.27.1713707337795; Sun, 21 Apr 2024 06:48:57 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id o13-20020a056a001b4d00b006e6c733bde9sm6175043pfv.155.2024.04.21.06.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 06:48:57 -0700 (PDT) From: Anand Moon To: Thinh Nguyen , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/5] usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Sun, 21 Apr 2024 19:17:34 +0530 Message-ID: <20240421134752.2652-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240421134752.2652-1-linux.amoon@gmail.com> References: <20240421134752.2652-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240421_064900_360832_DB1AA405 X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SET_SYSTEM_SLEEP_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_sleep_ptr() to discard all PM_SLEEP related stuff if CONFIG_PM_SLEEP isn't enabled. Acked-by: Thinh Nguyen Signed-off-by: Anand Moon --- v4 Fix typo in commit message SIMPLE_DEV_PM_OPS to SET_SYSTEM_SLEEP_PM_OPS Add Acked by Thinh Nguyen v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled. --- drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index 5d365ca51771..3427522a7c6a 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c @@ -187,7 +187,6 @@ static const struct of_device_id exynos_dwc3_match[] = { }; MODULE_DEVICE_TABLE(of, exynos_dwc3_match); -#ifdef CONFIG_PM_SLEEP static int dwc3_exynos_suspend(struct device *dev) { struct dwc3_exynos *exynos = dev_get_drvdata(dev); @@ -230,14 +229,8 @@ static int dwc3_exynos_resume(struct device *dev) return 0; } -static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume) -}; - -#define DEV_PM_OPS (&dwc3_exynos_dev_pm_ops) -#else -#define DEV_PM_OPS NULL -#endif /* CONFIG_PM_SLEEP */ +static DEFINE_SIMPLE_DEV_PM_OPS(dwc3_exynos_dev_pm_ops, + dwc3_exynos_suspend, dwc3_exynos_resume); static struct platform_driver dwc3_exynos_driver = { .probe = dwc3_exynos_probe, @@ -245,7 +238,7 @@ static struct platform_driver dwc3_exynos_driver = { .driver = { .name = "exynos-dwc3", .of_match_table = exynos_dwc3_match, - .pm = DEV_PM_OPS, + .pm = pm_sleep_ptr(&dwc3_exynos_dev_pm_ops), }, }; -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel