From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3945BC4345F for ; Sun, 21 Apr 2024 19:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=BbcG0Z3Jta+eevBbpyJJkOQIKGhCZnSYY4f3bawU6lc=; b=cvwsqtkyUBsBqY BQshPIq+BE7lndWE70k7QXBGGl2O2AkGVjsA+AeRLysSVTwPJWiC3Kxdq4PPQ1NsyFU7DZpM0g4zH rxEqC0L5R+5AQ5nCM5Q8EIQ4hvlKlgAirYzdunONCCR1lBddxnTelz+bqFY99UEQiMVpNEEIx7Au+ pSUSnI6bubtbSf09OYEMRKp4X4QmVMh9INQlROazgx4QBM3WTdn/AgfcuIhwmxiT53mdmC4S7qZMT lQCxpRfoxnMbM/Rz56vi/YONoYhltv8nRRpUGeY1Qad2tRxrch+xX8P428cWmY1Xg+8f3eYUuOeBD XRmGbGQsGKBlwCYh4U9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rycTP-0000000B7w8-1ptn; Sun, 21 Apr 2024 19:03:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rycTL-0000000B7vD-2n9W for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2024 19:03:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3CD50601BA; Sun, 21 Apr 2024 19:03:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F0F2C113CE; Sun, 21 Apr 2024 19:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713726206; bh=n6SwaZjcVFkNjY8H2WkLa4Pno+VxulX+IYzOLA17DN0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=uXtAHIMZ+qdvwY4KOBlp6kyl/izvObBoe0q9E24/x2a/oAvezSFan1OX6VQTOp5sp XbGSwwLd9l+P5+xnWrZ6I8KOTHVWcrWSbpLP42QT8DyqGhcoOqtc+a4DOCmgRm9IFe oiDyiIdBxuKDhRFLp4hadXjFd7MqxDhekNxh4U47OZkS47ymQAtT8qZ8kej/O6J1Uo jtfSym6QZTLu+OP9Fuec09FOoXd77svf/Ixyw6ARqTOX7uCDJ5jgA7HSRRA3gEsKmD +CU3Cgb0BdfBgGTD+eIL5Inooarzhz6Un0ujHX+X5m2SBtGa8Mm+aYlkfQ3NmUeyNG M0WIDRGCe6UbQ== Date: Sun, 21 Apr 2024 14:03:24 -0500 From: Bjorn Helgaas To: Vidya Sagar Cc: bhelgaas@google.com, rafael@kernel.org, lenb@kernel.org, will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, frowand.list@gmail.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, treding@nvidia.com, jonathanh@nvidia.com, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V6] PCI: Add support for preserving boot configuration Message-ID: <20240421190324.GA373874@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240418174043.3750240-1-vidyas@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240421_120331_776594_6FA7D57A X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2024 at 11:10:43PM +0530, Vidya Sagar wrote: > Add support for preserving the boot configuration done by the > platform firmware per host bridge basis, based on the presence of > 'linux,pci-probe-only' property in the respective PCI host bridge > device-tree node. It also unifies the ACPI and DT based boot flows > in this regard. This looks great; my only comments are: - It might make sense to move the _DSM evaluation to pci-acpi.c instead of probe.c. - There are a few different things going on (move _DSM, look at DT host bridge in addition to of_chosen, integrate ACPI and DT flows, tweak usage of PCI_PROBE_ONLY vs bridge->preserve_config, use pci_assign_unassigned_root_bus_resources() when we didn't before), and I think they could be split into multiple patches to make it easier to read. I took a stab at splitting this, but didn't quite complete it. I'll post that as v7-incomplete, and if you compare with v6, you'll see what's missing (the PCI_PROBE_ONLY and assign resources stuff -- there's some subtlety there that wasn't obvious to me). Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel