From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AFF6C4345F for ; Mon, 22 Apr 2024 10:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GYZzgnU/8OT7RL6EnTsPXm9LZ1Yu1C7opuu+QoRNyT0=; b=tm4sMhWMPBzFJC y6YJjJxPWwGr/X55SofQHmke4stTS0soHKxMRInGmbbVykePF0CJc9deEzJd1ZRrKir3UssxAA8L9 7FkyA8LJlYbgPKnrvpoFXb7WIagHqCS5suV5KC+APQTjhgCkqDTUrQUIw5mshkDdGU/mL/ijA9aRF ox6f+9TUjw41y57LcyBl958PsdeVpEWJ+KRmL9dJKbyrHrNDf8MI6od6bzBu+Wg9i47YYwVaFQ2Ts YheAd6tX7aWzUDl3n65BUM4LFPmMQXZdtRZW1I8/qSm2yBoxwT2OkZkWs2QoeYCWUirWBJYxSUg+J noPd4yyDzHBbmR652COg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryrOa-0000000DGXd-3TmI; Mon, 22 Apr 2024 10:59:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryrOX-0000000DGWF-2Pid for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 10:59:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 44D4560E09; Mon, 22 Apr 2024 10:59:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EBD7C113CC; Mon, 22 Apr 2024 10:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713783571; bh=1p9dN9HGyRnh6FNMJMHLYFOMqCNJyVlRMdNicikYM7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ek74AD6W4SAMRR94/ykIS3Oh8v34oQJAiUhV9AL8lXFDWIgQmHlhrbpi7z7Bh04lM bgYZR6qwAeKu14SmwhUT4iCV71eDGXeleACEee+HJQcNtgicvS3hzerUbVsyF4kWeT BYsaTRg/baMxyyLn4AbrCksK9iKVqdt8TN2s0TiSAqPNajHkJJu1/FKIdZRyV0S19i zj6yOIDMZ5NfYtNnFQY0mTPY2bIUFZIQ2OKqgj23Kosxi+l3yBxjw56oF/KQzuVwmW tKFiOaPLh9rJGpo2Q5Jk3u3Ktpgvb33rE/s2I6cDwOlbAuNrTYKkXMC2XKXBTZAJbe +pXoxxO2+JkDg== Date: Mon, 22 Apr 2024 11:57:56 +0100 From: Simon Horman To: Daniel Machon Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bryan Whitehead , Richard Cochran , Horatiu Vultur , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments Message-ID: <20240422105756.GC42092@kernel.org> References: <20240419-lan743x-confirm-v1-0-2a087617a3e5@kernel.org> <20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org> <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_035933_698980_D30D94CC X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 20, 2024 at 07:24:24PM +0000, Daniel Machon wrote: > Hi Simon, > > > -/* Convert validation error code into tc extact error message */ > > +/* Convert validation error code into tc exact error message */ > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > the fix should be 'extack' instead. > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > { > > switch (vrule->exterr) { > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > index 56874f2adbba..d6c3e90745a7 100644 > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > /* Copy to host byte order */ > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > -/* Convert validation error code into tc extact error message */ > > +/* Convert validation error code into tc exact error message */ > > Same here. Thanks Daniel, Silly me. I'll drop these changes in v2. > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule); > > The other fixes seems correct. > > /Daniel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel