From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BBF3C4345F for ; Mon, 22 Apr 2024 14:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P3OMi/+9GG1AEUVfwmizszGj79enI/rhanqX+xYAKIQ=; b=W6TUfzQxqrZ3Jk 0n4CL7uAWlLMIQZT0YEENjI8kvN0xMzKwxoWjyy3l7LC6sahihFnuO8iworwrpg1As2hcW7Qf5DLi lniEeo4/2F7L1A1xKhxtnoONGeYQIy0Jo9T5CRaXKy5kL3s5aJsZKjKuDTXzSrzQNyC07QDdEcS/E HpnCQjwqzNlS21tyBbcVf6DGEBY6LQSyzzUevh4lZiKMfyk/Zcms1TdhASlNioNx9SSQPWb9coLE/ gvLvIDXUEUICZM+xy0voPKBt8NFZ0+PXP6da3ta8AAjdhb3YqhlCgv2bhdEWK82zcJ+lj7CNOPuu2 9B2++iApgoIWU1odWeXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryubN-0000000DuHA-0aOY; Mon, 22 Apr 2024 14:25:01 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryubG-0000000DuFt-1tfG for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 14:24:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42D72CE0AEB; Mon, 22 Apr 2024 14:24:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EB09C113CC; Mon, 22 Apr 2024 14:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713795891; bh=UixV5EidYwsxFua1xIDYV6JAjWIOm875jhs6D2+QN/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E9iRwFZc4nm5fJqxtHjuvWOp6mjRA8LzvnLCX1H5Kv+Qys2M5FqKiFeGJBRuIWJBS JPAr1jWogxMWhbaJhjVRyXWysKBnVc2PQYw9tW9hqh98DfKqEcEH8FWqvabhGp2FZ5 /M4PtM6QNLFmw9wjM3qV+yCuVjLHejweLDgrA3++au6lThe/KEFSRGi226PQxOyElm G8j1FH8MEy0zpK9l9HfXilWaGxLEpnuX/Pwj5dMvpEO5rJpy0ccwwHnqQvf0WW/oAV qL08LZxijyPSQ+fLwJIUSai2pzR0CoX+eYEz+e/WT4Vi1HgtR9tM0B9YdwWHXYZgev yVZpdDmrNACsA== Date: Mon, 22 Apr 2024 09:24:49 -0500 From: Rob Herring To: Frank Li Cc: Laurentiu Mihalcea , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Liu Ying , Laurentiu Mihalcea , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: dsp: support imx8ulp dsp clocks Message-ID: <20240422142449.GA1186917-robh@kernel.org> References: <20240418203720.8492-1-laurentiumihalcea111@gmail.com> <20240418203720.8492-2-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_072455_037369_EF04D59F X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2024 at 05:08:20PM -0400, Frank Li wrote: > On Thu, Apr 18, 2024 at 11:37:18PM +0300, Laurentiu Mihalcea wrote: > > From: Laurentiu Mihalcea > > > > i.MX8ULP DSP node needs a MU clock, but doesn't need > > a debug clock. Change "clocks" and "clock-names" properties > > to allow for this case. > > > > Signed-off-by: Laurentiu Mihalcea > > --- > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 51 ++++++++++++++----- > > 1 file changed, 39 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > index 9af40da5688e..4a39d57b1cc6 100644 > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > @@ -30,22 +30,12 @@ properties: > > maxItems: 1 > > > > clocks: > > - items: > > - - description: ipg clock > > - - description: ocram clock > > - - description: core clock > > - - description: debug interface clock > > - - description: message unit clock > > minItems: 3 > > + maxItems: 5 > > > > clock-names: > > - items: > > - - const: ipg > > - - const: ocram > > - - const: core > > - - const: debug > > - - const: mu > > minItems: 3 > > + maxItems: 5 > > > > power-domains: > > description: > > @@ -93,6 +83,43 @@ required: > > - memory-region > > > > allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx8ulp-hifi4 > > + then: > > + properties: > > + clocks: > > + items: > > + - description: ipg clock > > + - description: ocram clock > > + - description: core clock > > + - description: message unit clock > > + clock-names: > > + items: > > + - const: ipg > > + - const: ocram > > + - const: core > > + - const: mu > > + else: > > + properties: > > + clocks: > > + items: > > + - description: ipg clock > > + - description: ocram clock > > + - description: core clock > > + - description: debug interface clock > > + - description: message unit clock > > + minItems: 3 > > + clock-names: > > + items: > > + - const: ipg > > + - const: ocram > > + - const: core > > + - const: debug > > + - const: mu > > + minItems: 3 > > According to your descript, look like only clk "debug" is difference. > > How about > > clocks: > items: > - description: ipg clock > - description: ocram clock > - description: core clock > - description: message unit clock > - description: debug interface clock > > clock-names: > items: > - const: ipg > - const: ocram > - const: core > - const: mu > - const: debug You can't change the existing order, so this does not work. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel