Re: [PATCH 01/20] dt-bindings: arm: stm32: Add compatible string for DH electronics STM32MP13xx DHCOR DHSBC board

From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Dario Binacchi" <dario.binacchi@amarulasolutions.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Sean Nyekjaer" <sean@geanix.com>,
	"Steffen Trumtrar" <s.trumtrar@pengutronix.de>,
	devicetree@vger.kernel.org, kernel@dh-electronics.com,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 01/20] dt-bindings: arm: stm32: Add compatible string for DH electronics STM32MP13xx DHCOR DHSBC board
Date: Mon, 22 Apr 2024 10:08:09 -0500	[thread overview]
Message-ID: <20240422150809.GA1265252-robh@kernel.org> (raw)
In-Reply-To: <20240422002006.243687-1-marex@denx.de>

On Mon, Apr 22, 2024 at 02:19:15AM +0200, Marek Vasut wrote:
> Add DT compatible string for DH electronics STM32MP13xx DHCOR SoM and
> DHSBC carrier board. This stm32mp135f-dhcor-dhsbc board is a stack of
> DHCOR SoM based on STM32MP135F SoC (900MHz / crypto capabilities)
> populated on DHSBC carrier board.
> 
> The SoM contains the following peripherals:
> - STPMIC (power delivery)
> - 512MB DDR3L memory
> - eMMC and SDIO WiFi module
> 
> The DHSBC carrier board contains the following peripherals:
> - Two RGMII Ethernet ports
> - USB-A Host port, USB-C peripheral port, USB-C power supply plug
> - Expansion connector
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de>
> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Andre Przywara <andre.przywara@arm.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sean Nyekjaer <sean@geanix.com>
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: devicetree@vger.kernel.org
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index bc2f43330ae42..7f61223b8ef24 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -59,6 +59,12 @@ properties:
>                - prt,prtt1s   # Protonic PRTT1S
>            - const: st,stm32mp151
>  
> +      - description: DH STM32MP135 DHCOR SoM based Boards
> +        items:
> +          - const: dh,stm32mp135f-dhcor-dhsbc
> +          - const: dh,stm32mp131a-dhcor-som

Either this or your dts is wrong. Either way, please test your dts files 
against the schemas.

> +          - const: st,stm32mp135
> +
>        - description: DH STM32MP151 DHCOR SoM based Boards
>          items:
>            - const: dh,stm32mp151a-dhcor-testbench
> -- 
> 2.43.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel