linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <michal.simek@amd.com>,
	Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v3 05/13] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding
Date: Mon, 22 Apr 2024 14:45:45 -0400	[thread overview]
Message-ID: <20240422184553.3573009-6-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240422184553.3573009-1-sean.anderson@linux.dev>

Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---

(no changes since v2)

Changes in v2:
- New

 drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 8635b5673386..f1834c8e3c02 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -255,10 +255,10 @@ struct zynqmp_dp_link_config {
  * @fmt: format identifier string
  */
 struct zynqmp_dp_mode {
-	u8 bw_code;
-	u8 lane_cnt;
-	int pclock;
 	const char *fmt;
+	int pclock;
+	u8 bw_code;
+	u8 lane_cnt;
 };
 
 /**
@@ -295,27 +295,27 @@ struct zynqmp_dp_config {
  * @train_set: set of training data
  */
 struct zynqmp_dp {
+	struct drm_dp_aux aux;
+	struct drm_bridge bridge;
+	struct delayed_work hpd_work;
+
+	struct drm_bridge *next_bridge;
 	struct device *dev;
 	struct zynqmp_dpsub *dpsub;
 	void __iomem *iomem;
 	struct reset_control *reset;
-	int irq;
-
-	struct drm_bridge bridge;
-	struct drm_bridge *next_bridge;
-
-	struct zynqmp_dp_config config;
-	struct drm_dp_aux aux;
 	struct phy *phy[ZYNQMP_DP_MAX_LANES];
-	u8 num_lanes;
-	struct delayed_work hpd_work;
+
 	enum drm_connector_status status;
+	int irq;
 	bool enabled;
 
-	u8 dpcd[DP_RECEIVER_CAP_SIZE];
-	struct zynqmp_dp_link_config link_config;
 	struct zynqmp_dp_mode mode;
+	struct zynqmp_dp_link_config link_config;
+	struct zynqmp_dp_config config;
+	u8 dpcd[DP_RECEIVER_CAP_SIZE];
 	u8 train_set[ZYNQMP_DP_MAX_LANES];
+	u8 num_lanes;
 };
 
 static inline struct zynqmp_dp *bridge_to_dp(struct drm_bridge *bridge)
-- 
2.35.1.1320.gc452695387.dirty


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-04-22 18:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 18:45 [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-04-22 18:45 ` [PATCH v3 01/13] drm: xlnx: Store base pointers in zynqmp_disp directly Sean Anderson
2024-04-23 12:16   ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 02/13] drm: xlnx: Fix kerneldoc Sean Anderson
2024-04-23 12:17   ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 03/13] drm: zynqmp_dp: Downgrade log level for aux retries message Sean Anderson
2024-04-22 18:45 ` [PATCH v3 04/13] drm: zynqmp_dp: Adjust training values per-lane Sean Anderson
2024-04-22 18:45 ` Sean Anderson [this message]
2024-04-22 18:45 ` [PATCH v3 06/13] drm: zynqmp_dp: Don't delay work Sean Anderson
2024-04-23 12:18   ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 07/13] drm: zynqmp_dp: Add locking Sean Anderson
2024-04-22 18:45 ` [PATCH v3 08/13] drm: zynqmp_dp: Don't retrain the link in our IRQ Sean Anderson
2024-04-22 18:45 ` [PATCH v3 09/13] drm: zynqmp_dp: Convert to a hard IRQ Sean Anderson
2024-04-22 18:45 ` [PATCH v3 10/13] drm: zynqmp_dp: Use AUX IRQs instead of polling Sean Anderson
2024-04-22 18:45 ` [PATCH v3 11/13] drm: zynqmp_dp: Split off several helper functions Sean Anderson
2024-04-22 18:45 ` [PATCH v3 12/13] drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func Sean Anderson
2024-04-22 18:45 ` [PATCH v3 13/13] drm: zynqmp_dp: Add debugfs interface for compliance testing Sean Anderson
2024-04-22 18:48 ` [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-04-23 13:33 ` Tomi Valkeinen
2024-04-23 14:59   ` Sean Anderson
2024-04-23 15:30     ` Tomi Valkeinen
2024-04-23 15:39       ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422184553.3573009-6-sean.anderson@linux.dev \
    --to=sean.anderson@linux.dev \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michal.simek@amd.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).