From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B07DCC4345F for ; Tue, 23 Apr 2024 12:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6jmi6H3WTg8mYbHhjyLKlXMBJOm4PWdYfvLkkNJq5DU=; b=ouGwwC64bFgiIO IuSijST1N72Qy/jbQYRgTGDTZBuJHTzbso+0hCbyUda+v36k+jqMPcd5buwzawkEqdNL0b1JIUWxa u9XBQKoUKiw3xY+U5Rjr9QXiTXYq0VbfxMWTiYsywOc4T1vgyWiaw2SXiE6LUcF5yIm+oKJc/Kocf qkfjzSLaOAR2WluPcKZWsa8k1rmZ2I0JXkTrHwKq4ovsm1aUPvRnlJKnSu5Nx2PpYDLxjAEt23DUZ Lvez+SdHP/UGPcTURrM86oGaYAOISSK0qyFDPrF1MlLG77mIVsK6AJoiU5ahZr+c0Qao2HnacvdT2 3DcjdfvIsChmIYpWvo3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzFQO-0000000HQxQ-1Q6f; Tue, 23 Apr 2024 12:39:04 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzFQJ-0000000HQtY-04k2 for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 12:39:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AF9E7CE0FB6; Tue, 23 Apr 2024 12:38:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B64AC116B1; Tue, 23 Apr 2024 12:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713875932; bh=+cXiwTbxFmfiSsQO21Adm9RSvK/3tEUU0QEneBBOX70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EpKUFJiIg8iLilLGVtbduWQebSgX9U/D2FgvydndfzBLm9spskITcBjNtTxVG/Gpm XbLH7kLJJqXOJDoEmSY3fTfB2qy3dDiZCXjfvKnyjPsLGmmtn8kFvb5SuCSu4h+/vC SGhpydeagU0louQl4VetJfuyjGbrzOeSa3iAfjsJrK25+9XaOEFdqHdGF8rwt7fGb+ 142bvCoSGBKlTZByQGf/BulrwuMcegszSwNikANTdo6aTUIHNwwUdcSuffkxFGLZOc WIkY0zKC3o9jNPzig34V7fQcqTDK2SS+BJs5VLYvetlnAQSKOyAffltLIj67pHXgwt RTMtcjiQt9ZTw== Date: Tue, 23 Apr 2024 07:38:50 -0500 From: Rob Herring To: Sean Anderson Cc: Michal Simek , Thippeswamy Havalige , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Conor Dooley , linux-kernel@vger.kernel.org, Bjorn Helgaas , Krzysztof Kozlowski , devicetree@vger.kernel.org, Lorenzo Pieralisi Subject: Re: [PATCH 1/7] dt-bindings: pci: xilinx-nwl: Add phys Message-ID: <20240423123850.GA4105016-robh@kernel.org> References: <20240422195904.3591683-1-sean.anderson@linux.dev> <20240422195904.3591683-2-sean.anderson@linux.dev> <171382130333.1986303.15938018699322126426.robh@kernel.org> <173a7bb2-5473-4c1b-b3dd-ef776e63ac7a@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <173a7bb2-5473-4c1b-b3dd-ef776e63ac7a@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_053859_534546_1A0C204E X-CRM114-Status: GOOD ( 20.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 22, 2024 at 05:30:06PM -0400, Sean Anderson wrote: > On 4/22/24 17:28, Rob Herring wrote: > > > > On Mon, 22 Apr 2024 15:58:58 -0400, Sean Anderson wrote: > >> Add phys properties so Linux can power-on/configure the GTR > >> transcievers. > >> > >> Signed-off-by: Sean Anderson > >> --- > >> > >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']} > > hint: "maxItems" is not needed with an "items" list > > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240422195904.3591683-2-sean.anderson@linux.dev > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > This warning is invalid, since I am using pattern with items. It is valid. You need to make 'items' a schema not a list (i.e. drop the '-'). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel