From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4A38C4345F for ; Tue, 23 Apr 2024 12:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=utCkH/Vz72WiY0jvXTWdOi9WNFl/Xzn8kIHMc1n0jrU=; b=va+5cV/ck/xmmd YcY9Ofe9QDegOXAaMwDGX2yokZ7RFYRkdBxje/zzrpcmkMw7WoY58+Ls2zDHSfclJrrBJTD4enxKs g/hrDifXit+RW3OadmSJbMv1Vkb5jmBg/djFH2m3x2dGQaJjBfyLWCuhissYy6aG+UWzhxAOy0L/i eGiW6M0MqSIw8FPKJ2yqnyWi17hX008xAo1KLLYWdbsuad1F6Fc1656ZCKlABFdqb9Zen0wIVcyJW JY8E/RowD6/9xlMtks0JS028qMSvtRrJD+hEEUpwQoXW7ksoApMc6oqVscG/zBa1DgOJE0YjOMWBt JlRAu5e2d9plsvGg1KUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzFWx-0000000HU5v-1K3Q; Tue, 23 Apr 2024 12:45:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzFW8-0000000HTPZ-2n8g for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 12:45:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 701E5611FC; Tue, 23 Apr 2024 12:44:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E753EC116B1; Tue, 23 Apr 2024 12:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713876299; bh=cTXx+iD2wmjxxov1qX3iubOa9Y20RoJrqWIrv/7Wz0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kKY/7MhBGou+3DqZ/lN9QH+aKZ7FDa9tbgHIKuxifPyXktA/MznLQJ1uuwRhwD2lB OmyXEgOTk60IOS1FJJrXEK1huQIM5Njl3G/q+fg3GtKaWH1Kz6tGsCsiJ42M43z0Lo QtZc/bPi71errt/8feNSEc1qXa2sQd3EPwoPzJmlDQVbmsEZwOtaaczeUP4rZAqUNr dyi7rVBAQN0aHCWrbllEil1GKKrufWjy28e/dnnNBB9g1bj3kKqtrSrzliOjuuiYwu vuCT6Am90rSjErLhmETtvcXPFOwHGQyoxUFJiN0B87fYFip+YA9uRq2wHtYlgMMNJa TKXfcsBb5u59A== Date: Tue, 23 Apr 2024 07:44:56 -0500 From: Rob Herring To: Sean Anderson Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thippeswamy Havalige , Michal Simek , Bjorn Helgaas , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 1/7] dt-bindings: pci: xilinx-nwl: Add phys Message-ID: <20240423124456.GB4105016-robh@kernel.org> References: <20240422195904.3591683-1-sean.anderson@linux.dev> <20240422195904.3591683-2-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240422195904.3591683-2-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_054500_959401_1E21C99A X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 22, 2024 at 03:58:58PM -0400, Sean Anderson wrote: > Add phys properties so Linux can power-on/configure the GTR > transcievers. > > Signed-off-by: Sean Anderson > --- > > Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > index 426f90a47f35..02315669b831 100644 > --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > @@ -61,6 +61,14 @@ properties: > interrupt-map: > maxItems: 4 > > + phys: > + maxItems: 4 > + > + phy-names: > + maxItems: 4 > + items: > + - pattern: '^pcie-phy[0-3]$' The names here are pointless and redundant. Names are local to the device, so 'pcie' is redundant. They only refer to PHYs, so 'phy' is redundant too. All you are left with is the index of the entry. Now if PCIe can work on only lanes 2 and 3 or similar, then maybe -names becomes useful. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel