From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0CB0C4345F for ; Tue, 23 Apr 2024 16:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VS8jcZxDpWGniT+PvZkFpZ3r4v6W6vvpxzJnPt7o0/0=; b=sDrjKe5xUPYlyl iqb8UcAOFq1l5zqkiUD/IFVz25hkm13tUPN6JEuSOjWabGZuUBZhIsuYNAx0pXFZTmnLzJoLsNboc K/AivFqez+IJvSaL8aJGPvTuv1DxSk9wjcFOa9nBQQlXZ36Ehrdw4kPb41OEO2lFB0mPZwx7R7K1s y+RBxXeNXdQOzRxjchzpRpl8RukE3GQf9BsceX9IkidBa/sodxzh5YrP9yqfTX03h/X6CX1qoB7NF N3sxJsFHTqdIm1J8ZJkZI1OWWAYdAmsHQeKIgodhITnuRrrR7RDIrGukJgWoq5zPQYh2d1SjITjSG gA4oVW9xUdCzemkzvzvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzIrH-00000000hrV-01nY; Tue, 23 Apr 2024 16:19:03 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzIrC-00000000hqd-45Ro for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 16:19:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EE3E2CE0E12; Tue, 23 Apr 2024 16:18:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52C6AC116B1; Tue, 23 Apr 2024 16:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713889134; bh=JJPdZeRSB0G7BWjAMGmMubvKNrJMsm7LhBJ9zzq/Hfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o2tcZPudzWK7CpfFi7IxJqaL2SdA5471xtcrRRGugct4rGMzS5cF+aeKHpVJ0iDXn q+6PJ/A/EcngAsVrGDHgB06ISRRQPW3NsdYAZ7svncj4pQJx2X+TCDg0fb6LlcsyM/ LRnwEwZsNT7a2cDwfUy9yki5a5z+1xC62X88lObdYYJAtC1NS/iEphC4xiSEWlDqWu eoIDAumbBMqm8bFsgRqVEVg+Ab0QfNVU6TUTqi3ikyMWfKvh6aUZ67vhvYq124DzDZ 2ZUbg26tonhU8ey7z4K13XJv4LRCvkx7+tidNV8jrdiTDzH/R/bD/8xpUYFqfbNLkf ELVz7lg6uHriQ== Date: Tue, 23 Apr 2024 17:18:49 +0100 From: Simon Horman To: Daniel Machon Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bryan Whitehead , Richard Cochran , Horatiu Vultur , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments Message-ID: <20240423161849.GW42092@kernel.org> References: <20240419-lan743x-confirm-v1-0-2a087617a3e5@kernel.org> <20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org> <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> <20240422105756.GC42092@kernel.org> <20240423112915.5cmqvmvwfwutahky@DEN-DL-M70577> <20240423135417.GT42092@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240423135417.GT42092@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_091859_428555_67C68280 X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > Hi Simon, > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > the fix should be 'extack' instead. > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > { > > > > > switch (vrule->exterr) { > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > /* Copy to host byte order */ > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > Same here. > > > > > > Thanks Daniel, > > > > > > Silly me. I'll drop these changes in v2. > > > > No reason to drop them just change it to 'extack' :-) > > Thanks, will do. Sorry, I am somehow confused. Do you mean like this? /* Convert validation error code into extact error message */ Or just leave things unchanged? /* Convert validation error code into tc extact error message */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel