From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14CF5C4345F for ; Tue, 23 Apr 2024 19:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r+zJmMZxtA9n1WE6H7G8PD0cx7eWrDDWeWbw4ivWw3U=; b=JETWozdIL6/D/j +SHcj+HT9OiO8WmRYpUhCqnJZxNTFu1blVQ86qW8g0Tm5L2ZY4UyfQqXYbrE6+VLiC9EI9BW9aX5x 9ERlOaAN+D+S0Uczi551ZURyTJPFY5alyDmWe87BjiJFOxj3/BQDKWyXoV7w85wTq/Uz8XAXiLWpP nIiGuYXf71EIRsP/rDU7KMCacQi+7cRFK52io+1DT6DWFzaKhxIzxsCYgrRRIyc0GaebOHI2xpWUu KGipodDJawxnZEurJj7qu+T9KxAR6JxD7tijqQB7EYmmMC/Q5ajKh/h9ym5jq+hypK72nK0RhaWr5 MDDzLTqI7S3i1ZEi4fdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLpv-00000001Hs0-1qNS; Tue, 23 Apr 2024 19:29:51 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLps-00000001Hq8-2ZHV for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 19:29:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1713900589; x=1745436589; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=odvs53J89vHkxamj8JtAAYYYthFoYRIwiYqr53H9o4A=; b=A242dnWLXs28d3Sd02JsHjc40AcaHwN/6odywm9eIGFNt87+mGnWmAoY j6X9ssbAdHJ86Cuw8W3V3BrsU/ITa9ByoRAyWr/Zq6eV2n7rULlT23/Z3 Z1h08Ji7/YYF1GZ+f0O2n9syYxyYXpw7UglAdblCpmGPgZ7Qpr/+uQ1da r+ffWDcKx/QlNTf0MUI0ddhWPem1HER2J6jQBIBseGDL1haVmrE6rTPdz /n6xPuGKheTkAIWBXUQA3S9Vh2XWpoNoA8hLbJtM5kzFQmHwj+Dr6yBZr +6bzjSCojLCJVky5vWWslV/kskWfLck8ao7knkYWBibf1z6g140hOcTKS A==; X-CSE-ConnectionGUID: SD2mN5/IQM20Rk6USUIJug== X-CSE-MsgGUID: gCTb8hoCSFCt/0pTMDJExA== X-IronPort-AV: E=Sophos;i="6.07,222,1708412400"; d="scan'208";a="22340301" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Apr 2024 12:29:46 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 12:29:33 -0700 Received: from DEN-DL-M70577 (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 23 Apr 2024 12:29:31 -0700 Date: Tue, 23 Apr 2024 19:29:30 +0000 From: Daniel Machon To: Simon Horman CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bryan Whitehead , "Richard Cochran" , Horatiu Vultur , Lars Povlsen , Steen Hegelund , , , Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments Message-ID: <20240423192930.okhvbvlao6ke3pkl@DEN-DL-M70577> References: <20240419-lan743x-confirm-v1-0-2a087617a3e5@kernel.org> <20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org> <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> <20240422105756.GC42092@kernel.org> <20240423112915.5cmqvmvwfwutahky@DEN-DL-M70577> <20240423135417.GT42092@kernel.org> <20240423161849.GW42092@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240423161849.GW42092@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_122948_678197_DC22100F X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > > Hi Simon, > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > > the fix should be 'extack' instead. > > > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > > { > > > > > > switch (vrule->exterr) { > > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > > /* Copy to host byte order */ > > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > Same here. > > > > > > > > Thanks Daniel, > > > > > > > > Silly me. I'll drop these changes in v2. > > > > > > No reason to drop them just change it to 'extack' :-) > > > > Thanks, will do. > > Sorry, I am somehow confused. > > Do you mean like this? > > /* Convert validation error code into extact error message */ > > Or just leave things unchanged? > > /* Convert validation error code into tc extact error message */ Should be: /* Convert validation error code into tc extack error message */ So the misspelling was real, just the fix was extack and not exact. /Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel