From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C1C0C4345F for ; Wed, 24 Apr 2024 15:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xEJK8FPJH7Gpfwd70aZfAaEdKbVJM2JMvhLPaewkrHQ=; b=YknY4lQNSt3sTK zrfw7cCPaK9yYAf0SGH0seEVU4o8a+XoiBQe6/m6okcjM3/4Nni98IM+kf/mEOuuAM0pZHfK78H5L YPPV271E5k60r0KyIi7Ow7YlPOgiUjeluLgjoTWdVobzhkU9jH0QCdeV9xQiYfXcgwEEWMATp9ZqU 1otWkmZNqHxX3gDcEQZ+Q5tdyARCf+gLL61Zj6kQJSFuGf0+lNnCeK1SuclXz21/cs3CNc4F6fWxl M1uv5Xk6N62U87UqDakkeA40jCxjwCn2SODNP4c64VPjaoz6zzJzzTyOrSadNu7Z+fr8sdecSSHw0 DS8kxTY+pgZL3wl5xtPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rze7h-00000004cDn-1X6S; Wed, 24 Apr 2024 15:01:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rze7b-00000004cCK-1sGo for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 15:01:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 74CEBCE140B; Wed, 24 Apr 2024 15:01:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 090A8C113CD; Wed, 24 Apr 2024 15:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713970876; bh=4YXfv5lqCAUcfMB5t+fOCcrGW9badPRJMRygflAgOOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r9SABrMb7zJqLBKULymwu8vicegkSboVvUmce/TtA45HANww2y2OHZyc+7TvwGORe 4m4ESChpC+CiI5J8zb1W5VIqmjsksSTs1VyoIuYesyvVw6+h63usuAjH/WTWcALxse 1sKKvQnuJWTVePrPkcXZ9X/wacsbiBAr02LAdY/rZsU7eotNVNaR9L6g8GL7UXJcYR 6CxckSH7y83cMd6+5e0vW4A0d8pjZ+SP97SyELBnTmx6wNgdyjf72r+3ISRM1z3OOM ptJJDZNdYRr9ssdxlCZys9lwZ/GaujqI3Q1kEn2u1XWxAsV5f2oMQ1RNbTj42GpkXp lgRbdL6PNCIkQ== Date: Wed, 24 Apr 2024 15:59:41 +0100 From: Simon Horman To: Daniel Machon Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bryan Whitehead , Richard Cochran , Horatiu Vultur , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments Message-ID: <20240424145941.GL42092@kernel.org> References: <20240419-lan743x-confirm-v1-0-2a087617a3e5@kernel.org> <20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org> <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577> <20240422105756.GC42092@kernel.org> <20240423112915.5cmqvmvwfwutahky@DEN-DL-M70577> <20240423135417.GT42092@kernel.org> <20240423161849.GW42092@kernel.org> <20240423192930.okhvbvlao6ke3pkl@DEN-DL-M70577> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240423192930.okhvbvlao6ke3pkl@DEN-DL-M70577> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_080119_864391_A2FD6CB2 X-CRM114-Status: GOOD ( 22.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2024 at 07:29:30PM +0000, Daniel Machon wrote: > > On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > > > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > > > Hi Simon, > > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > > > the fix should be 'extack' instead. > > > > > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > > > { > > > > > > > switch (vrule->exterr) { > > > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > > > /* Copy to host byte order */ > > > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > > > Same here. > > > > > > > > > > Thanks Daniel, > > > > > > > > > > Silly me. I'll drop these changes in v2. > > > > > > > > No reason to drop them just change it to 'extack' :-) > > > > > > Thanks, will do. > > > > Sorry, I am somehow confused. > > > > Do you mean like this? > > > > /* Convert validation error code into extact error message */ > > > > Or just leave things unchanged? > > > > /* Convert validation error code into tc extact error message */ > > Should be: > > /* Convert validation error code into tc extack error message */ > > So the misspelling was real, just the fix was extack and not exact. Thanks, I see it now. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel