From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B83C6C4345F for ; Wed, 24 Apr 2024 12:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1XMZkx/xllZjp5E1R/jFeQ/o1f8sGbQVd33aTuMxVJE=; b=NBcQGAZ7SmEeZE A/xRAKH0jJAXSWLQUcaSFSBCi50I5EA2bOsYCDyItjx8kagZficQo+cYzTbB1FoRXDvRZ+eojFQjU Iv9EDNTZpMMVVtV3q4XWOnJWGDUYnWBziJGonn0431jEJA3NQ9a+sHvwSYNrffrIaaSLbi5CoCMPO XAOQhdcgGu6cohc7SzJqbCGd2uW/CuteqS1+6a6eGiRkMzgwOcWWrB7U6iX3cCqOqvbcgPCixTzJe RJ6Hz1klxL0SUg8pMTIT++6o4xHuD8j7QbkhKXQ3CPwYIwTtrQtxqJGuOSujt3RlhxVyYHejwpvST YT35U5xmWkeKrrat3M7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzbpP-000000045lt-11Kz; Wed, 24 Apr 2024 12:34:23 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzbpM-000000045ku-2hxH for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 12:34:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713962061; x=1745498061; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RdEzfGHr6mIGf1fmDgMivz/m+lwL7VuuP84qTo4VLCg=; b=kjRCXIKvqLVZc4mO8U+ZgKH2zQ3AZH4gLdAMVpa9RDGErUTurv9Giodw LzNuB4IpsgtI+6frr0XC6CJwWp5VSJH0FRL2aCl+T50dRQjwEtMZ8YySV ZsnG0X9oBkEfTXXeUX5kHGISoGdkoxPzG7cLZ83c10bpPHMnnuD8YEDwq 88GpJJS/sm1jdwv1wOLETTCKyRqtilCMt6nmRl0D8jhktNrqRsOFHFdtu bEVsdMBh5EvWT7lUeLeL7j4iNzIA6i4Xr8+nAYnu08g1MPkXCfC6ZJF74 B5hJ0YcPdVMaHc6IEdRn3hrUC2F+HHpDb3W4Xaer9wNXLTzC/+tiNvyY4 w==; X-CSE-ConnectionGUID: x9EkuAgAQ9CMqhXNPyf8Qw== X-CSE-MsgGUID: 0/W+S+F/SNO82ZEH9NsSfg== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9811286" X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="9811286" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 05:34:18 -0700 X-CSE-ConnectionGUID: UXB9MMOrRbiJGz+VZuSSzg== X-CSE-MsgGUID: /K5OmW/RRKu88J3t3Vt0qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="24585850" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by orviesa010.jf.intel.com with ESMTP; 24 Apr 2024 05:34:12 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1rzbpB-0001Dq-2r; Wed, 24 Apr 2024 12:34:09 +0000 Date: Wed, 24 Apr 2024 20:34:03 +0800 From: kernel test robot To: Aren Moynihan , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Aren Moynihan , Andy Shevchenko , Ondrej Jirman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: <202404242057.PUDY5RB1-lkp@intel.com> References: <20240423223309.1468198-4-aren@peacevolution.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240423223309.1468198-4-aren@peacevolution.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_053420_722544_2B38AC9D X-CRM114-Status: GOOD ( 15.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Aren, kernel test robot noticed the following build warnings: [auto build test WARNING on jic23-iio/togreg] [also build test WARNING on sunxi/sunxi/for-next robh/for-next linus/master v6.9-rc5 next-20240423] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aren-Moynihan/dt-bindings-iio-light-stk33xx-add-vdd-and-leda-regulators/20240424-064250 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240423223309.1468198-4-aren%40peacevolution.org patch subject: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend config: arm64-randconfig-001-20240424 (https://download.01.org/0day-ci/archive/20240424/202404242057.PUDY5RB1-lkp@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 5ef5eb66fb428aaf61fb51b709f065c069c11242) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240424/202404242057.PUDY5RB1-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202404242057.PUDY5RB1-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/iio/light/stk3310.c:10: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:21: In file included from include/linux/mm.h:2208: include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> drivers/iio/light/stk3310.c:615:38: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 615 | return dev_err_probe(&client->dev, ret, "get regulator vdd failed\n"); | ^~~ drivers/iio/light/stk3310.c:594:9: note: initialize the variable 'ret' to silence this warning 594 | int ret; | ^ | = 0 2 warnings generated. vim +/ret +615 drivers/iio/light/stk3310.c 591 592 static int stk3310_probe(struct i2c_client *client) 593 { 594 int ret; 595 struct iio_dev *indio_dev; 596 struct stk3310_data *data; 597 598 indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); 599 if (!indio_dev) { 600 dev_err(&client->dev, "iio allocation failed!\n"); 601 return -ENOMEM; 602 } 603 604 data = iio_priv(indio_dev); 605 data->client = client; 606 i2c_set_clientdata(client, indio_dev); 607 608 device_property_read_u32(&client->dev, "proximity-near-level", 609 &data->ps_near_level); 610 611 mutex_init(&data->lock); 612 613 data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); 614 if (IS_ERR(data->vdd_reg)) > 615 return dev_err_probe(&client->dev, ret, "get regulator vdd failed\n"); 616 617 ret = stk3310_regmap_init(data); 618 if (ret < 0) 619 return ret; 620 621 indio_dev->info = &stk3310_info; 622 indio_dev->name = STK3310_DRIVER_NAME; 623 indio_dev->modes = INDIO_DIRECT_MODE; 624 indio_dev->channels = stk3310_channels; 625 indio_dev->num_channels = ARRAY_SIZE(stk3310_channels); 626 627 ret = regulator_enable(data->vdd_reg); 628 if (ret) 629 return dev_err_probe(&client->dev, ret, 630 "regulator vdd enable failed\n"); 631 632 /* we need a short delay to allow the chip time to power on */ 633 fsleep(1000); 634 635 ret = stk3310_init(indio_dev); 636 if (ret < 0) 637 goto err_vdd_disable; 638 639 if (client->irq > 0) { 640 ret = devm_request_threaded_irq(&client->dev, client->irq, 641 stk3310_irq_handler, 642 stk3310_irq_event_handler, 643 IRQF_TRIGGER_FALLING | 644 IRQF_ONESHOT, 645 STK3310_EVENT, indio_dev); 646 if (ret < 0) { 647 dev_err(&client->dev, "request irq %d failed\n", 648 client->irq); 649 goto err_standby; 650 } 651 } 652 653 ret = iio_device_register(indio_dev); 654 if (ret < 0) { 655 dev_err(&client->dev, "device_register failed\n"); 656 goto err_standby; 657 } 658 659 return 0; 660 661 err_standby: 662 stk3310_set_state(data, STK3310_STATE_STANDBY); 663 err_vdd_disable: 664 regulator_disable(data->vdd_reg); 665 return ret; 666 } 667 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel