From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A155C4345F for ; Wed, 24 Apr 2024 21:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=isliyH1Pwq7dBL9LXg3/IOGRSF6jwrKnZa0HcyOoOck=; b=JF1BwOockkqSK3 0a/6xnpNWe5vR8fxtvEzrc7QYBGB2PSno++RLTSELptQ1B/LmAbeGogr7YxPCzSBs5U27hjorKu+A ilm6lTRMXXhuqGBz5sWdljsEsXZE/OF+fX8TzT03cfCKO69NKPrUQ7Mfa5jjAXG0Z6dBtOF9AzCbj 0wHjVU3OAVv3ouWheolOqb5mBmWbqEr7H+JQN7DrWstHT8OQGm0gAUPCwDevVMXp266+RV03uscg/ o6QU0ZJskH5R7bM7VjJiEZYEX8ni92jLUaU1C2ud/2WHk4gTQdOYM+11S5t25Z9mAtpY0E8qYS9/M QIx0Ypf+XK9nVj4AQZQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzkGF-0000000674v-2WTr; Wed, 24 Apr 2024 21:34:39 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzkGC-0000000674E-3lYt for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 21:34:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A9F72CE17FD; Wed, 24 Apr 2024 21:34:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFCE4C113CD; Wed, 24 Apr 2024 21:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713994471; bh=SrHYLs89xngbdxeCohwI49CaO37g9BgaojB8ExaVup0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qiVR3Fc4AVQcXSENBIatnhU6o6BmBxbHG1GhuxjzVlnWjy3cZG/FUQzYFCSBAFbyU ajVFl3uzcGL7xTkm8rYAnyFfpmZ+zgFbolml/21CJZUTlFbHM9xPIg+/eJXAfXBnMv c/7dYhJDqkpfz+nG8P8WUcEmZ5nXMWS0QuRSgWMU= Date: Wed, 24 Apr 2024 14:34:22 -0700 From: Greg KH To: Jay Buddhabhatti Cc: michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: soc: xilinx: check return status of get_api_version() Message-ID: <2024042430-scurvy-swimmer-92f2@gregkh> References: <20240424063118.23200-1-jay.buddhabhatti@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240424063118.23200-1-jay.buddhabhatti@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_143437_154748_8427D026 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2024 at 11:31:18PM -0700, Jay Buddhabhatti wrote: > Check return status of pm_get_api_version and return error in case of failure to > avoid checking uninitialized pm_api_version variable from stack. > > The issue is also reported by smatch on x86 as "warning: 'pm_api_version' is > used uninitialized". > > Fixes: b9b3a8be28b3 ("firmware: xilinx: Remove eemi ops for get_api_version") > Signed-off-by: Jay Buddhabhatti > --- > drivers/soc/xilinx/zynqmp_power.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c > index 965b1143936a..8570ab1a6857 100644 > --- a/drivers/soc/xilinx/zynqmp_power.c > +++ b/drivers/soc/xilinx/zynqmp_power.c > @@ -3,6 +3,7 @@ > * Xilinx Zynq MPSoC Power Management > * > * Copyright (C) 2014-2019 Xilinx, Inc. > + * Copyright (C) 2024, Advanced Micro Devices, Inc. Really? Your lawyers think that your 3 line change deserves this addition as well? If so, please have them sign off on the next version of this patch submission so that we get their confirmation that this is what they want to start doing for all AMD submissions. >From my point of view, this change is not ok. thanks, greg "I talk to too many lawyers" k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel