From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43E8EC4345F for ; Sun, 28 Apr 2024 13:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xphRW1Eg9M85RFnn+pY41we++D3YwNf0CSnMXoldfS0=; b=W+2HK//4wUPD6/ YemaGc6wg4lUsArKI78KdolDeWWfQq2LHsLzErkf7dACLNXpPgw9gQdaaFvDkbzVgq4qGPLpcZrZk wVm6eLsjwdOyhfCeuI6/pwKAU/8CFIavb6s4LHnqF3c25tBOfpobhfqSJYUBND/0UBQBiN6eogAUF BZLSl4hUmZwSi87rqsE1XB3LrhytMoJhkjcqf+1kJKwaeYG4LW9lsLObG+9DSh3cdLhhyKDLA4PSI XAOX1aXyQY1rCJoF+nV7gcYmo1mgnEJec26tOItYxEGIWiyaIcmmNV+nBxJnQLPYjYrBvyYX9LYhS lmptMqdYPJt1u8/MT3TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s14Z7-000000002PV-1Zxa; Sun, 28 Apr 2024 13:27:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s14Z3-000000002Ou-1uqa for linux-arm-kernel@lists.infradead.org; Sun, 28 Apr 2024 13:27:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BE52860918; Sun, 28 Apr 2024 13:27:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51406C113CC; Sun, 28 Apr 2024 13:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714310852; bh=UeRn/pJ41orv6XOdXZFOuoyklETajUXkK7V1tSlZmtU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DOdaHkiq5iRVyOlk8mzyS4b31++a8Qy3V/BEBddxXEsZU4VwDJJYUgdIhGLqVA8Md rURcRHUfDtkgoNE+Sj/kjFsxJf0uKspDKYH2zhGzDiMcfkkz3F9oip8lhIvM1M737p xIj54kxkTmwu9y3V86LWA2tt8qE/nuKs7qL7ROrY/BSLuKaDkmWU0LvSyJjdVXt+wC RwAR/qGoUeFEkHr1igNYkn5uV7XqDs0W49PQ90/0HMZBgzPR8AYQsnf3gyjGb4YVsw hxcbod8LDoz0ESX9eyT+ommuZk0SRwXDPb/yanpglS6nzWrwHSN/3Gyw1hLK/G6uVV ZAXCcC7Vx7oQw== Date: Sun, 28 Apr 2024 14:27:19 +0100 From: Jonathan Cameron To: David Lechner Cc: Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] iio: cleanup masklength usage Message-ID: <20240428142719.08363889@jic23-huawei> In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240428_062733_694941_F0CD9BC4 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 25 Apr 2024 10:03:26 -0500 David Lechner wrote: > While working on other patches I noticed that a few drivers are setting > the masklength field of struct iio_dev even though it is marked as > [INTERN]. It looks like maybe this was not always the case, but we can > safely clean it up now without breaking anything. > > --- > David Lechner (3): > iio: adc: ad7266: don't set masklength > iio: adc: mxs-lradc-adc: don't set masklength > iio: buffer: initialize masklength accumulator to 0 > > drivers/iio/adc/ad7266.c | 1 - > drivers/iio/adc/mxs-lradc-adc.c | 1 - > drivers/iio/industrialio-buffer.c | 2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. I can't remember that ever being set by drivers so this is rather weird. Mind you our docs used to be less clear on what drivers should set so maybe that was the issue. Jonathan > --- > base-commit: b80ad8e3cd2712b78b98804d1f59199680d8ed91 > change-id: 20240425-b4-iio-masklength-cleanup-86b632b19901 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel