Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

Jonathan Cameron
2024-04-28T16:48:40Z

On Wed, 24 Apr 2024 22:00:46 +0200
Ondřej Jirman <megi@xff.cz> wrote:

> On Wed, Apr 24, 2024 at 08:31:27PM GMT, Andy Shevchenko wrote:
> > On Wed, Apr 24, 2024 at 7:14 PM Ondřej Jirman <megi@xff.cz> wrote:
> > > On Wed, Apr 24, 2024 at 06:20:41PM GMT, Andy Shevchenko wrote:
> > > > On Wed, Apr 24, 2024 at 3:59 PM Ondřej Jirman <megi@xff.cz> wrote:
> > > > > On Wed, Apr 24, 2024 at 02:16:06AM GMT, Andy Shevchenko wrote:
> > > > > > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan <aren@peacevolution.org> wrote:
> >
> > ...
> >
> > > > > > > ret = stk3310_init(indio_dev);
> > > > > > > if (ret < 0)
> > > > > > > - return ret;
> > > > > > > + goto err_vdd_disable;
> > > > > >
> > > > > > This is wrong. You will have the regulator being disabled _before_
> > > > > > IRQ. Note, that the original code likely has a bug which sets states
> > > > > > before disabling IRQ and removing a handler.
> > > > >
> > > > > How so? stk3310_init is called before enabling the interrupt.
> > > >
> > > > Exactly, IRQ is registered with devm and hence the error path and
> > > > remove stages will got it in a wrong order.
> > >
> > > Makes no sense.
> >
> > Huh?!
> >
> > > IRQ is not enabled here, yet. So in error path, the code will
> > > just disable the regulator and devm will unref it later on. IRQ doesn't enter
> > > the picture here at all in the error path.
> >
> > Error path _after_ IRQ handler has been _successfully_ installed.
> > And complete ->remove() stage.
>
> Allright. So fixing the other issue I mentioned will fix this one too, because
> there will be no error path after IRQ enable, then.

Don't do reorder stuff past iio_device_register.
It generates a bunch of it's own issues wrt to functionality.
The iio_device_register() call is the last one because the device must be in a
state to correctly deal with all userspace actions by the time they are made
available.

Harden the driver to not call IIO core functions for false events if that
is easy to do, but there shouldn't be an issue if you do (if there is we should
address that in the IIO core).

Jonathan

>
> kind regards,
> o.
>
> > > > > Original code has a bug that IRQ is enabled before registering the
> > > > > IIO device,
> > > >
> > > > Indeed, but this is another bug.
> > > >
> > > > > so if IRQ is triggered before registration, iio_push_event
> > > > > from IRQ handler may be called on a not yet registered IIO device.
> > > > >
> > > > > Never saw it happen, though. :)
> > > >
> > > > Because nobody cares enough to enable DEBUG_SHIRQ.
> > >
> > > Nice debug tool. I bet it makes quite a mess when enabled. :)
> >
> > FWIW, I have had it enabled for ages, but I have only a few devices,
> > so I fixed a few cases in the past WRT shared IRQ issues.
> >
> > --
> > With Best Regards,
> > Andy Shevchenko