Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

Aren
2024-06-07T14:19:46Z

On Sun, Apr 28, 2024 at 05:53:37PM GMT, Jonathan Cameron wrote:
> On Tue, 23 Apr 2024 18:33:05 -0400
> Aren Moynihan <aren@peacevolution.org> wrote:
>
> > From: Ondrej Jirman <megi@xff.cz>
> >
> > VDD power input can be used to completely power off the chip during
> > system suspend. Do so if available.
> >
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
>
> Suggestions inline. Key thing is take the whole thing devm_ managed
> and your life gets much easier. It is mixing the two approaches that
> causes problems and often the best plan is to do everything in probe/remove
> with devm_ calls to do the cleanup for you.

Thank you for writing this up. I've been a bit distracted lately, but
I'm hoping to find some time to implement this in a new revision soon.

- Aren