From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01BACC4345F for ; Tue, 30 Apr 2024 17:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2aStJwkt1Mrtz640uRqWDqu2K9oAcjGIIG8ifTODJuA=; b=rKQf0lZWlbMVZO 0Y2rSmCAROzftxF6yUGT0HeLXIUgmV/2y5HDhs+adqipfB2j0LbaIC4o1Ypi93OqFj/KT/BafIVTg Wi06iEdjY9jRXflL0l/j+OXQyXPx46ZQBMs9TmhFMKqibCEn6XNYrHCzMb31Q9WqKbK3msjaNeZxH mB60zYAyu59vk8fb+vztxJoShXzxsHA8ep5WuMM6oZfOI6BuvHxyMSLM9SV9pd5xuXOwoEe40CV7E IAA5miLr7Hq/EN7XggWvjPqnNjfLuP4DWsPjTNF4atIKHyYK4IK7CQuHMIuEvxh9W5vWYTeXJiBsM wZCg30/KF79jYeqIH8HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1rau-00000007UVz-1h2L; Tue, 30 Apr 2024 17:48:44 +0000 Received: from mail-oo1-xc2f.google.com ([2607:f8b0:4864:20::c2f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1rap-00000007UTc-3spx for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 17:48:41 +0000 Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-5aa28cde736so3921645eaf.1 for ; Tue, 30 Apr 2024 10:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714499317; x=1715104117; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PDq8d+gYPhH6UpCrQkijKEWZF+TRlH556m+C6sytk2c=; b=SIlOgDYEXDlKaiS5UOwq4JrvdFEYv3Srao7T9LSxgQrqIUUu5uylULB/Oku8gRuEOE GlImX0Vk+oWKK0PejQRCI9W+GKHIqRIvqS2b8I4R9B/fFUuGCU4A+B5982aWc3YKfJcy O2JvBzvcxJ3+pfS8MkBkcdRhrtSDtCVces56E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714499317; x=1715104117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PDq8d+gYPhH6UpCrQkijKEWZF+TRlH556m+C6sytk2c=; b=GefMPulrzk02ZaVuNTKQLvDIFzn6d1EwvVgHsajiGwLt+BbqcMM4mW0tkbdHqPtPPw 6EVz+cJJUnrIhzWSD+21kU0VRyW9GECJ7ypl952oC/utnO72TjAAwmWdnqB69XzLdhUb 5zhRh5ye7xxh0wYxAiGN+BrGdTuNvWUzJzS+ewhWzlIXEriDy42VAsHMLKKz8+0xk/ps 95re885M3Ey+Rc9Bm2EaAvbL4DNlsI8ueY8bqYE7QMfR/xhONrDQwnqxrOD3rdoiOl4A aW6gxGJ9JyT0fDhrvHGx7kzhv9Dhuyg5xzc0I74109J7mRU6i+x7QAMivXdpooAPGXOM mYlA== X-Forwarded-Encrypted: i=1; AJvYcCXDzRY2CghpvMjSsMtlOH015I7+Ze0zNPGk0YgTF8mhoPb4VXW+8oQg8fna2vgCjx/8+Hs/jayxcJbgAhKodE+8rq1OIb2r+ZVdZVgnDrgPmVOhTio= X-Gm-Message-State: AOJu0YwbXU3H5axl0/4ov1xPhOnDPjB7xUbDl8QzHC5pFcO55Ip4KMx0 l+K/4s4GfhZW/ha4vJ2mkka2VBBSbtfH8MjE+VbGM2swDPdfYp+l3Y0mGwnBVA== X-Google-Smtp-Source: AGHT+IEmbtVwIHw8WS21DEFm3vZJtcsGN62O+K99Z6mISqTw/HC8GJbY1ZGTCLogwTQdWEB73IJAOg== X-Received: by 2002:a05:6218:2616:b0:186:5c1:1dd1 with SMTP id oy22-20020a056218261600b0018605c11dd1mr672678rwc.19.1714499317510; Tue, 30 Apr 2024 10:48:37 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id l185-20020a6391c2000000b005ffd8019f01sm15483435pge.20.2024.04.30.10.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 10:48:36 -0700 (PDT) Date: Tue, 30 Apr 2024 10:48:36 -0700 From: Kees Cook To: Peter Zijlstra Cc: "Gustavo A. R. Silva" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hardening: Refresh KCFI options, add some more Message-ID: <202404301037.9E34D4811@keescook> References: <20240426222940.work.884-kees@kernel.org> <20240430092140.GE40213@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430092140.GE40213@noisy.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_104840_109975_E91DBD12 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 11:21:40AM +0200, Peter Zijlstra wrote: > On Fri, Apr 26, 2024 at 03:29:44PM -0700, Kees Cook wrote: > > > - CONFIG_CFI_CLANG=y for x86 and arm64. (And disable FINEIBT since > > it isn't as secure as straight KCFI.) > > Oi ? Same objection I always had[1]: moving the check into the destination means attacks with control over executable memory contents can just omit the check. But now that I went to go look I see 0c3e806ec0f9 ("x86/cfi: Add boot time hash randomization") is only enabled under FINEIBT... seems better if that were always enabled... -Kees [1] https://lore.kernel.org/all/202210181020.79AF7F7@keescook/ -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel