From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CB15C4345F for ; Tue, 30 Apr 2024 11:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hToL7TY4budkaBF3gtyBG2VxyZ23jpumgrY5zxkvxzM=; b=f9k8laaIB6X2Z5GAsUjjaLRWFU aeH0XhwDgA1NBIg40vppu6NnQfRj3Y6/ghjquwhn5+nSjlYk9k3hqcs1epq0+6Cq28kyGFgKuJCnw 44TdWqbXtKXGTSpHG54FdODov4La064sjW0Gc8G7Avciou73VsZA2FK6dz9MgNV0fGIWCbgPtpJw/ xWbtdbJ21e70dgsut40DS4qRWwSRNaSX5yd8kirdTxXR7F9zVJItPmFkMO8nc1wdoRA5L/P3n7SNM 4WJ8ZDB/Abuq5Yl3uy4F2QVRBXDgtsHPeJiKa5GqCIO854SqnqleUm9n8wGrBOoA0C8cNGPJWKA98 jSprMEag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lMc-0000000687T-1yJQ; Tue, 30 Apr 2024 11:09:34 +0000 Received: from mail-lf1-x149.google.com ([2a00:1450:4864:20::149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lMZ-0000000686y-0Bl7 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 11:09:32 +0000 Received: by mail-lf1-x149.google.com with SMTP id 2adb3069b0e04-51d2f1c3255so2601739e87.1 for ; Tue, 30 Apr 2024 04:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714475368; x=1715080168; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iEYB9mDUejJc4/pGtI2YjsxtjTa/nIHaNe2DmniH/60=; b=VwQEfzFmsvcFHwlrDQ+MjdT4bL64c+zxzzzzLWUG6FQlVcIDodhu+rnGN5eURpMkVQ vCTMM1K6RBBk90v/ty7mno9gqvyEt2eon9BC+uacOTrydx5vT1LLI3dBJvG0aWVrITen Ufhk7Tb3FKlHHlj8pcQGCbEYSSxAl4MpBr44sBqm4Kn58HrQMoK6TRRZT4Ps8wP0BNZx TYyD+5noOESNsK3Oli5me0YI9IUadG1t7Keb4WH+m2Ve+hTg59+Sl0k1uxpxCh3pBwDd fjTverr/9CQszIj1P/zyQLtgHGxfiLEqpNVu/9hxrqCOFSJto2Vhm3t3bNlt/60Kx6YQ oyGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714475368; x=1715080168; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iEYB9mDUejJc4/pGtI2YjsxtjTa/nIHaNe2DmniH/60=; b=idkcAkShsmJwEmfDX9/xqlPCxgSPkbHeV1b7JLg9Upj7zi/ner1tqcPk29MSUImUrl lGf0jx8frbzCcbLKzQhNFgwNGQVGi/qIwC2A1rev1WMcXUeTsSFN+pq0r6nNX4aECbkx sZSzQSWLRmJcLRW7EMTYji0qP1BRf2ak9/AgmFzh49vip70KawfkTN+Y1wRAAdWpWdlJ YjVp9Qtdp5d0UpcB9HYs/9GhnedDm6xiE3BtA+wsTik1vZhvhh0TGpYuOla1wTxhykLY +8zipUPp6Yab7jh5iLqa6IdqH4ST3dLdHqOZCfUTrFpojPrIrbzw7tUiXbN+v1IRs/Dc 81og== X-Forwarded-Encrypted: i=1; AJvYcCUFuaBDGynCi1okDm6GguNjNbbRxO/fjf5EuyzhLIauLBp30ZJQ1nhC2NyGIDAxpZ4ZI+WFi3rr3xoBsRRXJEtXsK8D5mnlOd9TC6ctnYEUu78Nme4= X-Gm-Message-State: AOJu0YwNtpOyFR+4iIaLNBZYdIti3niGgOejpGZ6DN8T2TkM0BvSzmCx DSiddOCCECLtE4qgPkpFfOmCcAEAmUZ7DtDOUngFlobuZtbsfqY8izTwUZ2Wto5mCClXcASA67e YRSwVRHiHUal3aA== X-Google-Smtp-Source: AGHT+IEwO9Q5sZ30zpSvkC99WHH3eLdnH6j0MxCIGWpnoajIsyuoEBhv50j1r9BA61IMy/c54vMsTNsgaQ6JEU8= X-Received: from aliceryhl2.c.googlers.com ([fda3:e722:ac3:cc00:68:949d:c0a8:572]) (user=aliceryhl job=sendgmr) by 2002:a05:6512:33c1:b0:51c:fb60:5e18 with SMTP id d1-20020a05651233c100b0051cfb605e18mr10061lfg.4.1714475367865; Tue, 30 Apr 2024 04:09:27 -0700 (PDT) Date: Tue, 30 Apr 2024 11:09:25 +0000 In-Reply-To: <20240409103120.GA22557@willie-the-truck> Mime-Version: 1.0 References: <20240409103120.GA22557@willie-the-truck> X-Mailer: git-send-email 2.45.0.rc0.197.gbae5840b3b-goog Message-ID: <20240430110925.1064685-1-aliceryhl@google.com> Subject: Re: [PATCH v2] rust: add flags for shadow call stack sanitizer From: Alice Ryhl To: will@kernel.org Cc: Jamie.Cunliffe@arm.com, a.hindborg@samsung.com, alex.gaynor@gmail.com, aliceryhl@google.com, ardb@kernel.org, benno.lossin@proton.me, bjorn3_gh@protonmail.com, boqun.feng@gmail.com, broonie@kernel.org, catalin.marinas@arm.com, gary@garyguo.net, keescook@chromium.org, kernel@valentinobst.de, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, masahiroy@kernel.org, maz@kernel.org, miguel.ojeda.sandonis@gmail.com, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, ojeda@kernel.org, rust-for-linux@vger.kernel.org, samitolvanen@google.com, wedsonaf@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_040931_107794_96D20F50 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will Deacon wrote: > On Tue, Mar 05, 2024 at 01:14:19PM +0100, Miguel Ojeda wrote: >> Otherwise partially reverting to the `target.json` approach sounds good too. >> >> I added the `-Zuse-sync-unwind=n` to the list at >> https://github.com/Rust-for-Linux/linux/issues/2. Given the default is >> what we want, I have put it in the "Good to have" section. > > I think we have time to do this properly, like we did for the clang > enablement a few years ago. In hindsight, avoiding hacks for the early > toolchains back then was a really good idea because it meant we could > rely on a solid baseline set of compiler features from the start. > > So, please can we fix this in rustc and just have SCS dependent on that? Hi Will, Just to keep you in the loop, I've posted a PR to make rustc recognize the reserve-x18 target feature, so that the -Ctarget-feature=+reserve-x18 flag stops emitting a warning. This should be sufficient for adding support for CONFIG_DYNAMIC_SCS. You can find it here: https://github.com/rust-lang/rust/pull/124323 As for non-dynamic SCS, I plan to tackle that after the PR is merged. See the "Future possibilities" section in the linked PR for more info on that. Alice _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel