From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A48F6C19F53 for ; Tue, 30 Apr 2024 14:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E6klTgfsYZOWhJBrBUL2p2CqJnLmLPgxfjl0XVgHifE=; b=doHHetXTnl7TTV SXVEmfBcSpZ3CllHev865IbKGjo2G+va0mYn9YEO6/ob7J+VJHE/qM7TvbRNZaHc3umZgOwboDFBi 6G7VvzWGivWwSiO9FcWo+9als1wLFh/Kb8cAZd5YjxQ2eVWigyhffPD+fj31h4T4XBOU1k2Jf/tj4 qhZArXdA186mcPV8cY8YrRoKSpgMLLcKnPtyCAnO/2Vb3Ea6FRU1Ql0GcjZXIvZ/B3xwZhoGf5cO3 qEd6E4O/Y+wDoR+cJkwAN6ilR8MJqFsltDyQQFO5dBTQWpamNQ82t2I37cMNF5ELZsCRlASVB4Bp0 Si+L1tzJGhDkewRzYknQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1o7r-00000006gvL-0KgI; Tue, 30 Apr 2024 14:06:31 +0000 Received: from mail-co1nam11on20600.outbound.protection.outlook.com ([2a01:111:f403:2416::600] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1o7Y-00000006gha-3nz2 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 14:06:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWOUAG0oo9xPbQvVjhPio1MDlIbqi9yOU+ExwEG0yQkh8D+jm48Ub2vba+X+mtlD4BznyxEoVR5yCFW5U60BRBqDXsxFoTdBq7RKIxwLx76uQEN/w9Sp6td08cjAFahSM/wz9De689xe9TanQtde+Sy77JtJIfUTDasRt+UDKtdnNrP9+XlNV+jfmnvml2D0AtcNm1ovS1OPpT985qlGcE2uRMFVwGnErTfe2e51+zkft3TbEGXwqcr9TgE2Iud9SLoIz/gD1IUg9ybrE+4MZ4Id+0VYz5C+yHnp0y0NuC4pNIAsTZr2/30Ekv3U7S5/HyMreUUP5GOmuDAKa/U6OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xv7+alfGmC0L3lFcIc83KYYoR2JcfcX7O1Gra8tjvrs=; b=D0EaePuFItIpL1mgg0QTCD3rccTPZYpFJ/aLUv26K3q2tQC/kin+GuLhZSqN4xLg6L1sKMjHFh6TAEwq1ecQLAZzm1nUgD1XYEoL59//2YnV9V5uuaiCclke4IDomukBv+gyRdQaJZuEApaZ7ZHi5eIAS8WS8jWI4bnYoPM51CpEFzyRCiaSNREwLOpUeGeYvctIdrUAmShM0mp9eyb90ALOjxWI+/40gVgbQaEvXYUpqtL/kbRT4jqNTK1KFnGSTBlQEq159yg3Kw/zvbWGKJRmws+krrh9TxHZDfECLq3x2IsdcV5CrYvFA9tm9y/LZNX8n2l0s/+ODHd/cAuCLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xv7+alfGmC0L3lFcIc83KYYoR2JcfcX7O1Gra8tjvrs=; b=KHe12cSAtVE1u+70JJj9/rEJKi9ZIN61j/npVhI59JEDi6TsHMdWwwmrnEm7FjsVls0pDDWdt4V6yWX1rjchshfVbbUPBMNQ0y0CXHol9XyeDffi7QY56DjYRyvUJTM374IetVzvm5A7lVFX9deZKEoZXigIfcOq5vELPtoKbyBW9idBfm4YIv7msmZ4hoEtufHKelKmCPOb1Q1nZO34k/tDC0bLfXda5EHzmkl3QpnRxxsPii5yoz3bb9jzHRZffO8BmQcK1fEmfsZx7tAUHr95/aeAqaAKaA4v0JjVDAg/eAVJLMt/rLGnX2gihilJiS8YRdo2/hOGhYi/xmnrYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MW4PR12MB7165.namprd12.prod.outlook.com (2603:10b6:303:21b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Tue, 30 Apr 2024 14:06:02 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e%3]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 14:06:02 +0000 Date: Tue, 30 Apr 2024 11:06:00 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v6 4/6] iommu/arm-smmu-v3: Make __arm_smmu_cmdq_skip_err reusable Message-ID: <20240430140600.GP941030@nvidia.com> References: <25150aec77edf5590bca81f4a418ef1ee7b21952.1714451595.git.nicolinc@nvidia.com> Content-Disposition: inline In-Reply-To: <25150aec77edf5590bca81f4a418ef1ee7b21952.1714451595.git.nicolinc@nvidia.com> X-ClientProxiedBy: SN4PR0501CA0008.namprd05.prod.outlook.com (2603:10b6:803:40::21) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MW4PR12MB7165:EE_ X-MS-Office365-Filtering-Correlation-Id: 1068d6fb-cc19-4b13-ea4e-08dc691eaaff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2IgN1BIs/dI+b/lWVKfq0m9HfPE9LmbHvLCXQRClmOAdKpmSfmz6JkYXNwW/?= =?us-ascii?Q?4r2048sNJ7Px/76/ZrbyOSNhbvND2X8ZygsVpaeBmb/dZZ1F+CT8rQCcrP+F?= =?us-ascii?Q?2mp1vtZWA2ToKScLnjvauODiMTIazDzlYnf6hzxysFzWaxV6T4v8U397vHbH?= =?us-ascii?Q?isRnNjUJyMTq91dMgPk1lWjIksn4+v6PeaNYlZsN1XaaisofQdrPJFH9mJD/?= =?us-ascii?Q?cYHG283mdIXocqSp3ioqDPhlPdCBzfrmd8HQMKsYvU3P0pkpQclwTqogoHtG?= =?us-ascii?Q?BW/kPjsiyN13e71viT75UAXiSqghI8sk6NXzO8PpEu3z+lS8Gan4giQQwpIJ?= =?us-ascii?Q?TpG44CcfGveusKHXyFUVZvK/RQulCSyRf8F/g2bFu4sd2mUxiyDPqEnJiDWB?= =?us-ascii?Q?0YICgwP2iliRZlaW7rQOREE6t66VM+XvSh1zUGcBE3OUCCd65cozqCotvcN1?= =?us-ascii?Q?mevz56WUAV/ClXhLz4tx0Uv3E7Lwh+VHjiTLo8KPh1b2uowKjFNTb7vTvG+x?= =?us-ascii?Q?XwV4LE775ERbrd/PmyoOXCWi/doxqjkljOHs2W2273REhNJpLnTK3XYGRmyw?= =?us-ascii?Q?ZOv/0H5wQwxkiKIMxmZRw65h6bFDV0k5rqpuBOxXCVupRs8qOr6iPQRfHo/J?= =?us-ascii?Q?biWEwdaAyxYHxoUPykMEdJwT4xt/BPhN2lDEd7zT2tDL7q3yw/I2rCh4tCHi?= =?us-ascii?Q?oF6s94Ykx0DFVl1jYTJTBpvTzLwj3j+DgJo/PaWo6S/11MOk4dM05lCZEmju?= =?us-ascii?Q?7FVm6OGZWgBDbPH0cVS+e8CfrFC8xAJEUZPlA4eKtp+3hHpG1m8xn9MY740s?= =?us-ascii?Q?p9MbG2QLXkKit/XLdV18W0sTut3EONO/LU5AVL/C1LIcwH7/gy0rhzTodddd?= =?us-ascii?Q?mZyUZU6tmtLAZwNLSaBWTiz0gHXsIz4gLASjI/ZHDueJA0HNnztQopGhC8qb?= =?us-ascii?Q?Sd7lzrOw/4wwYj1FmFrF6Wz+68xrIsuPG4q7Ps4cWS8syOCVyVXy3cZfqXJW?= =?us-ascii?Q?p7rIyNKo2pJm9F1D+2YVtkrrgu2ipWGgQyzp3fIjwyhVwUUaawMRankK3DxR?= =?us-ascii?Q?1Mxs+uDDrRL2SMd75kuSQb/fJ7zaGm5kM4XT4rs4eYve1y1ugEw27wEYN0UE?= =?us-ascii?Q?s1voblsXurs7BvQlQDWv1h7BYPQtqPWnAcOeWvduMiadFV0La0pUMLd4PSBf?= =?us-ascii?Q?r/IieYUzxSlm6MJy7pvkHM7Zs33C4lKjDMdxEnfxNjea4+GrkSQCgsY5aCQB?= =?us-ascii?Q?y4caOh9X3msXETAu11+SebVcuhPrDpqiEoTAghgAmQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ot/r774E8O6OQtcO74+Z1BIAAX3gTcYw7rOjKIkqhaV5sHzwzaoPIowhAc2E?= =?us-ascii?Q?sbkpxiz9eFdmLY9IYYENOQFiClxKkmXZBnZ0oJ4cr2hse1lQp+fjtdyCmyo0?= =?us-ascii?Q?me7brtZKw2Xz1y0d7IlcKeA0OICEFVXgucx5z2myhn9p5YeYL6ruUUQACn4O?= =?us-ascii?Q?3xTojfI+penGC6ib6FbDACg0ntuup5JcXjLRJHLH9lMXnf43oIfY7tgNyc2t?= =?us-ascii?Q?W/FPODtCAv4ufIwWaNE0beWJc7mQUoFiG7jb2Mfzsme8vLgS+L8ZCaczAP7+?= =?us-ascii?Q?YZqHzaVjWwjBBQcBWbkcr8D87u+x1vMSTPvdyQagKz//BJO8JQtUD92WfINB?= =?us-ascii?Q?3vVSgop0thlX46feKcsSm0si9JpRbCaqB6S7ckL+2tRfsLuLcQnMwBo/MXNW?= =?us-ascii?Q?JWpY/0XA+x+nEKxvSXUOKBprKMuSe5p7KHxiHK+UGBUbbnwL4QzWSHlXV86o?= =?us-ascii?Q?Cuc3a0hx5qD6FpG9eq1bmTfYr65o3anpcvZXNZv7zrRdHyfJ7vcLIqFzn/vV?= =?us-ascii?Q?SbOc/W8p5qZyRJROQUSFfqWyjQ/88Oa6O9U9B4ywI/VkPt3habcvMjJujMg+?= =?us-ascii?Q?qEHyWnqPC9rOQpknNxif1QqLK3CblIBQFFh5OtNdyXDVhFbm9QlNTgwQI5xQ?= =?us-ascii?Q?13AIYLyDwineoT5wM+XVhz36yH0OOzbs6j3VNMjRAavtU5I1hGqFacUu8z/s?= =?us-ascii?Q?DOtlTnX0ydj7dyWwLIz5efkm2ffiU42/9NOUwzFjzkYHkHUBbjIt0lJo94wR?= =?us-ascii?Q?d9a1Zhpu6Xpf9arxpvmyylWmj9uFO+lblDP9hnR7MCKWzlszpCJ4dvjIC3Ls?= =?us-ascii?Q?orTfw1RrRfxcOvkb7BZRrNd09C8SL4xUA2/Hkpaxr+Dk2ObBSEnYbtOdfL0L?= =?us-ascii?Q?mwi/wRC1Dk7xOytu+A4daC8OW5Td+k9/MFoF5BclLGHgllfR+O3n340/l9lI?= =?us-ascii?Q?vGhE2zrxluzOySHrsE31JQM/dXvZOJGbQ2vQt/Y+pCi9b29pnr3Ffn3I4qnz?= =?us-ascii?Q?nl8awNPX8v731eisLYYKdVAqtnLpaZmaeVzjrglPSaJDa59Bg2L7mP40dXpO?= =?us-ascii?Q?79pll/4cHZJylHruCgdln/QNvFBIOFxglHxeYt+TC/b8qJM8kyQGOazySdAk?= =?us-ascii?Q?iyP+pRcmPIcJxbkehAO2Tl5VF4dJPTAa425g8mS8vJSDhzPdXrrfMELPylgl?= =?us-ascii?Q?RHM6iMg4ahFdQaHxt04TMRLdeWe/IHxsXmtJ6HlHaSkR6IkBfX3PL4MuUUVW?= =?us-ascii?Q?4DLAqWYage0J5abaHvxSF7RmytnSjttAuuN7KDfABNHR8qMZlreQvkNzzrfd?= =?us-ascii?Q?nsHOfK4VPA6YgWDhgGwUuwHrDVq83bguMJm20wlWCpxWaZUuBXI6B5rVFOjr?= =?us-ascii?Q?v8ZuIiIH8YwVhLn1Wk9VsU0xIz0q5rqQxL/izI9hRhHFz0OrywcqBb8KcYwh?= =?us-ascii?Q?o/aAYIazqx4RwBu1b5pr16IRzdaQvBNufYzL710BnXtu3WtvxFpAfZz/ta5j?= =?us-ascii?Q?LP/E2ktQZF9rw2Pgl/vgELecIBEtImyJOkjTdrk7sMQ+LO/vqsXcwkcOlCEK?= =?us-ascii?Q?kjIsq98Y+eJgJ7QutLIfjfeAau55/lb4r2UIaYK3?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1068d6fb-cc19-4b13-ea4e-08dc691eaaff X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 14:06:01.9990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nr6L7Z/2aqCyGn39CpIdgTIeAKfTjoMKLGRG7NFC4YPjNejxk7cmP16ldxG+oiSH X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7165 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_070613_399795_36B2524D X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2024 at 09:43:47PM -0700, Nicolin Chen wrote: > Allow __arm_smmu_cmdq_skip_err function to be reused by NVIDIA Tegra241 > CMDQV unit since it will use the same data structure for q. And include > the CMDQ_QUIRK_SYNC_CS_NONE_ONLY quirk when inserting a CMD_SYNC. > > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 +++++-- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 2 ++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 538850059bdd..5111859347d5 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -379,8 +379,8 @@ static void arm_smmu_cmdq_build_sync_cmd(u64 *cmd, struct arm_smmu_device *smmu, > arm_smmu_cmdq_build_cmd(cmd, &ent); > } > > -static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > - struct arm_smmu_queue *q) > +void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > + struct arm_smmu_queue *q) > { > static const char * const cerror_str[] = { > [CMDQ_ERR_CERROR_NONE_IDX] = "No error", > @@ -428,6 +428,9 @@ static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > for (i = 0; i < ARRAY_SIZE(cmd); ++i) > dev_err(smmu->dev, "\t0x%016llx\n", (unsigned long long)cmd[i]); > > + if (q->quirks & CMDQ_QUIRK_SYNC_CS_NONE_ONLY) > + cmd_sync.sync.cs_none = true; This hunk should be in "iommu/arm-smmu-v3: Add CS_NONE quirk" ? Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel