From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2FC9C4345F for ; Tue, 30 Apr 2024 15:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hFyIu7j1oRrpb6aI8zibdIvWd+yv5joYsrkPrAglA/g=; b=qN27789DZlJGDB kUlWwFwVZPRRYs+/NRFIavUMDmmoMzi3ggKFa3+MSO2HUbFLcUZWYdNRhvEXTAoj7vbvlbiFR35Zr /fvU8Oh5TVdQvksvZjugRMmPNBo9rPSoM2yuLx0vFWz2q0GcBJjjhkDIW9yA7ay2GFprlhOiQcqhB 77omQAmkzBGAlJLaIEqCahV1HVaSwvNBtOzcFgfbO8UHCJRNsxsBRHsnbLxZXZC3SZ7sVP08JuJXq LisN9Vj4dlF5IFNw3yNZVrOeFnQ+2zVOy1v4RfJdnO63YRUKui2wu56YCfxbGrTZaMSdZOE0fiLoV z1/T6ZFezWrmMuUEJS4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1p7J-00000006zrk-2yuj; Tue, 30 Apr 2024 15:10:01 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1p7H-00000006zqA-0fnJ for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 15:10:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2ADACCE10C9; Tue, 30 Apr 2024 15:09:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F306FC4AF1D; Tue, 30 Apr 2024 15:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714489796; bh=21NNPMBdF38yzR1UgW+l4G83qO/y+s6ncZ0pzt/V2rU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a7hD6ZuxY9/dNmI6Px0Te5atkU9V2hIHyI59zJ5m5wRRnL+/2lF+DIfw0GDp+WtpD wmO67+OI9lZpuOI2z0KqA8EWs+rjE7sdEFtu1PYNf3WfwPba/dMYlFnCOG6L5QzSts /Swhl70kuANqKMNfErsyiA45dG4q7BwP1z6kQyTGwXNx83VHNGo5kWKB2tziPpPwjN 9wBIGzthlMp8MOe0aJxy/rl1rX6s3PYem8Ks5tv8qcl2gi2dbkg3hd2E9aomUkxtAO f8/+RcikzEtXoPguI+Eke8RcwNFRucFbuecZoUvNJGwRW0esbF14qDK2RXKnPmbTkY F8xIrn+gYY0+w== Date: Tue, 30 Apr 2024 16:09:50 +0100 From: Will Deacon To: Tanmay Jagdale Cc: robin.murphy@arm.com, joro@8bytes.org, nicolinc@nvidia.com, mshavit@google.com, baolu.lu@linux.intel.com, thunder.leizhen@huawei.com, set_pte_at@outlook.com, smostafa@google.com, sgoutham@marvell.com, gcherian@marvell.com, jcm@jonmasters.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 0/2] iommu/arm-smmu-v3: Add support for ECMDQ register mode Message-ID: <20240430150950.GD14187@willie-the-truck> References: <20240425144152.52352-1-tanmay@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240425144152.52352-1-tanmay@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_080959_416918_6DA40A56 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 25, 2024 at 07:41:50AM -0700, Tanmay Jagdale wrote: > Resending the patches by Zhen Lei that add > support for SMMU ECMDQ feature. > > Tested this feature on a Marvell SoC by implementing a smmu-test driver. > This test driver spawns a thread per CPU and each thread keeps sending > map, table-walk and unmap requests for a fixed duration. > > Using this test driver, we compared ECMDQ vs SMMU with software batching > support and saw ~5% improvement with ECMDQ. Performance numbers are > mentioned below: > > Total Requests Average Requests Difference > Per CPU wrt ECMDQ > ----------------------------------------------------------------- > ECMDQ 239286381 2991079 > CMDQ Batch Size 1 228232187 2852902 -4.62% > CMDQ Batch Size 32 233465784 2918322 -2.43% > CMDQ Batch Size 64 231679588 2895994 -3.18% > CMDQ Batch Size 128 233189030 2914862 -2.55% > CMDQ Batch Size 256 230965773 2887072 -3.48% These are pretty small improvements in a targetted micro-benchmark. Do you have any real-world numbers showing that this is worthwhile? For example, running something like netperf. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel