From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA8B8C4345F for ; Tue, 30 Apr 2024 19:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L6mkxnMdo2LPiw75JquBv3rYhViiyrICXw1VQjARWng=; b=Nwg4D2Xri9AbJ2 JboQcTLkTgmkOzlBG+oekI2ocmtvTa1Y/TuMsBofzU3KomEu1PxvfnILQur/LZpGMqEVrWAGMQ7cF MELVpOofGDyzBSINdgJkAt/n+KbTDjG1rlE5rIfERL2/Dz9sIhpEx97N/T/fuBxYpcAgz4hfCnhc0 YrD4kRHqNBaC/l3Bk8d6z2MLzefONVMorri5MfThEJefRUhqjtS0MECyryDo3+NrpqL3yJFVJJMGG qixkAgijxLZl2JypK4Fd78Vzs/zkJFcWIpXw5NqJ7DW6OTTJtqbLlBaEKUDFa+KcEx+p9VwWEpG0w Z5oABsHE8QibSWHw+9jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1tUB-00000007kpz-0TA8; Tue, 30 Apr 2024 19:49:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1tU4-00000007kpD-3PVw for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 19:49:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5DF066162C; Tue, 30 Apr 2024 19:49:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6810CC2BBFC; Tue, 30 Apr 2024 19:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714506584; bh=L44UUlMJiMRqZ33YFvdDMIt0qg//D0t3qFogmLwOHbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lu0o802uikMvRSH2hVH/ntKAqjFEhQuKLi1pEvnAjtUk6qCI0wuLmfnLNsySFVH9r VtB1Gv3hjuFMKSfFYNM+xpcWj50TZDx2yntBcJC8ll4BfP1M95bZN7+DagyNX1dG4b Fa/jCNaS+C9EyCa5mhI7PyXYV8j6ajxQEhourAW3rkvlkzpyr8kwtoqeIg6YgTsVOd /BxpzCpawAPpQmIhnGqsJahpsq1/8LLTYMNaud7rV7t6AAqQ7pjsXHlNZUQBB6AXh5 nGJka9NLm0yhgp4lmwtNR7/hJ07hEOOx+3+6AjSnQWGTL139ib/LUyNwnprn8aZPj9 6RDkUflamtg/Q== Date: Tue, 30 Apr 2024 20:49:38 +0100 From: Simon Horman To: MD Danish Anwar Cc: Dan Carpenter , Heiner Kallweit , Andrew Lunn , Jan Kiszka , Diogo Ivo , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Vignesh Raghavendra , r-gunasekaran@ti.com, Roger Quadros Subject: Re: [PATCH net-next v3] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers Message-ID: <20240430194938.GD2575892@kernel.org> References: <20240430120634.1558998-1-danishanwar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430120634.1558998-1-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_124948_989530_EA07C3B7 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 05:36:34PM +0530, MD Danish Anwar wrote: > Add SW IRQ coalescing based on hrtimers for RX and TX data path for ICSSG > driver, which can be enabled by ethtool commands: > > - RX coalescing > ethtool -C eth1 rx-usecs 50 > > - TX coalescing can be enabled per TX queue > > - by default enables coalescing for TX0 > ethtool -C eth1 tx-usecs 50 > - configure TX0 > ethtool -Q eth0 queue_mask 1 --coalesce tx-usecs 100 > - configure TX1 > ethtool -Q eth0 queue_mask 2 --coalesce tx-usecs 100 > - configure TX0 and TX1 > ethtool -Q eth0 queue_mask 3 --coalesce tx-usecs 100 --coalesce > tx-usecs 100 > > Minimum value for both rx-usecs and tx-usecs is 20us. > > Compared to gro_flush_timeout and napi_defer_hard_irqs this patch allows > to enable IRQ coalescing for RX path separately. > > Benchmarking numbers: > =============================================================== > | Method | Tput_TX | CPU_TX | Tput_RX | CPU_RX | > | ============================================================== > | Default Driver 943 Mbps 31% 517 Mbps 38% | > | IRQ Coalescing (Patch) 943 Mbps 28% 518 Mbps 25% | > =============================================================== > > Signed-off-by: MD Danish Anwar > Reviewed-by: Andrew Lunn > --- > Changes from v2 [2] to v3: > *) Collected RB tag from Andrew Lunn > *) Fixed warning caused by {} missing for outer if conditions in > emac_napi_tx_poll() and emac_napi_rx_poll() APIs. > *) Fixed spelling mistake. Thanks for the updates. This one looks good to me. Reviewed-by: Simon Horman > > Changes from v1 [1] to v2: > *) Added Benchmarking numbers in the commit message as suggested by > Andrew Lunn . Full logs [3] > *) Addressed comments given by Simon Horman in v1. > > [1] https://lore.kernel.org/all/20240424091823.1814136-1-danishanwar@ti.com/ > [2] https://lore.kernel.org/all/20240429071501.547680-1-danishanwar@ti.com/ > [3] https://gist.githubusercontent.com/danish-ti/47855631be9f3635cee994693662a988/raw/94b4eb86b42fe243ab03186a88a314e0cb272fd0/gistfile1.txt ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel