From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C939EC4345F for ; Tue, 30 Apr 2024 19:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tZsDItdvhxtYJ3CyUy6eV3/NKJtS8I1W6VBLE+oAYAc=; b=AYcP9TgRn/A7Ay +afQkW/ddr45kZEw7ld9ZTzCBxyn8hrSeD/mWhMJW9YzdCSB9DPvo3M5RRwaOIQZ1RKPODFD+BVND jaSU/R/lM8bFkljlCPN2Zx0TnS9pwIntqsXRl1KbzDPXtfMGb8TNJVuZ3CGBayYjcJQccbP9VvV18 jK36LuPONZG32Fldd4CdCfr350/LNfXJ0udNEkh0uux22Xt0wAhFi2iO3wUXc8Kjm39sKee0zA5KL QBm1r006KlETFVK7LYsInD3U8dBCGtE0OP6fHkt42HeuJvGiR3HgM/8RTgx8U2GlTEnS1492xiu9l eyQjtSknuYRwGPVMaeUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1tVr-00000007lBr-488M; Tue, 30 Apr 2024 19:51:39 +0000 Received: from out-172.mta0.migadu.com ([2001:41d0:1004:224b::ac]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1tVo-00000007l9E-2tLH for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 19:51:38 +0000 Date: Wed, 1 May 2024 03:51:24 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714506687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ghnc7A+qj4DHw76Zc4PmkMS/7KxAwj/kz5TlaQ90WZI=; b=lVj8mn6ue9G0BSVmk14Q+jPSoq2w3ywceBLRrdQrxNI6hh143C5M4hONAgoZ1Tenwfa7jv x3OBEdOgt1d0Krs44Hruq1VeMnmIXJRBftrk6lj/9QH7xQmgLHTCmrGV9JgojeaJlhbEbH +K0IGz0MeHhX28uYqptwDflPnT+eOys= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leo Yan To: James Clark Cc: linux-perf-users@vger.kernel.org, coresight@lists.linaro.org, Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf cs-etm: Improve version detection and error reporting Message-ID: <20240430195124.GD125@debian-dev> References: <20240430133221.250811-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430133221.250811-1-james.clark@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_125137_302187_18B2A7DD X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 02:32:21PM +0100, James Clark wrote: > When the config validation functions are warning about ETMv3, they do it > based on "not ETMv4". If the drivers aren't all loaded or the hardware > doesn't support Coresight it will appear as "not ETMv4" and then Perf > will print the error message "... not supported in ETMv3 ..." which is > wrong and confusing. > > cs_etm_is_etmv4() is also misnamed because it also returns true for > ETE because ETE has a superset of the ETMv4 metadata files. Although > this was always done in the correct order so it wasn't a bug. > > Improve all this by making a single get version function which also > handles not present as a separate case. Change the ETMv3 error message > to only print when ETMv3 is detected, and add a new error message for > the not present case. > > Signed-off-by: James Clark Reviewed-by: Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel