From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B832C4345F for ; Thu, 2 May 2024 03:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJJWgGHfwrFsG0J9GupDdcfQ8QaUGLe85ENHuqn+u1s=; b=WBd/8Qsddjhbl3 I4p+YSlqU9hGsY6MatLOV1blXRBuwLVEBfJpZzMHnHcYVx0n1NyxfOizrZyaDX/YzZ21wvb0ESuvt wvZnxx0OQS8Nojxf9KdQTB2WgMcau4U53gZMGgXHu0nURD3VyF0TCS6H7vhac/erHeC3HngYOg4AR iLjiJeQCTD8sJG/FDBOZAEtYFbWHEdboUHrxW1Aq3qHU1W3n/MYOSffb007L+drCp1DnsJefGT6Xy MOqzSr5iYncNPsEYA+lBhMrzXEO7w89mg6tkEOxGjXlMPcoJ0AMV2XC23PlujBjiAYdpOjTvX3JsT Ri2IyNmIXXTRlvSjVrgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2NSS-0000000BKTP-3vVN; Thu, 02 May 2024 03:50:08 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2NSP-0000000BKSK-2cLv; Thu, 02 May 2024 03:50:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 02BB1619E1; Thu, 2 May 2024 03:50:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87CB8C116B1; Thu, 2 May 2024 03:49:59 +0000 (UTC) Date: Wed, 1 May 2024 23:50:44 -0400 From: Steven Rostedt To: "Tze-nan Wu (=?UTF-8?B?5ZCz5r6k5Y2X?=)" Cc: "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "Cheng-Jui Wang (=?UTF-8?B?546L5q2j552/?=)" , wsd_upstream , "Bobule Chang (=?UTF-8?B?5by1?= =?UTF-8?B?5byY576p?=)" , "linux-arm-kernel@lists.infradead.org" , "mhiramat@kernel.org" , "mathieu.desnoyers@efficios.com" Subject: Re: [PATCH] tracing: Fix uaf issue in tracing_open_file_tr Message-ID: <20240501235044.12fa3297@gandalf.local.home> In-Reply-To: <661f101456506db945ccbd94700a0f47b95f91e5.camel@mediatek.com> References: <20240426073410.17154-1-Tze-nan.Wu@mediatek.com> <20240428202837.0cabca17@rorschach.local.home> <20240429144626.7d868ad3@gandalf.local.home> <661f101456506db945ccbd94700a0f47b95f91e5.camel@mediatek.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_205005_797095_CB0734F9 X-CRM114-Status: GOOD ( 30.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyIE1heSAyMDI0IDAzOjEwOjI0ICswMDAwClR6ZS1uYW4gV3UgKOWQs+a+pOWNlykg PFR6ZS1uYW4uV3VAbWVkaWF0ZWsuY29tPiB3cm90ZToKCj4gPiAgIAo+IFNvcnJ5IGZvciBteSBs YXRlIHJlcGx5LCBJJ20gdGVzdGluZyB0aGUgcGF0Y2ggb24gbXkgbWFjaGluZSBub3cuIAo+IFRl c3Qgd2lsbCBiZSBkb25lIGluIGZvdXIgaG91cnMuCj4gCj4gVGhlcmUncyBzb21ldGhpbmcgSSdt IHdvcnJ5aW5nIGFib3V0IGluIHRoZSBwYXRjaCwKPiB3aGF0IEknbSB3b3JyeWluZyBhYm91dCBp cyBjb21tZW50ZWQgaW4gdGhlIGNvZGUgYmVsb3cuCj4gCj4gL2tlcm5lbC90cmFjZS90cmFjZV9l dmVudHMuYzoKPiAgIHN0YXRpYyBpbnQKPiAgIGV2ZW50X2NyZWF0ZV9kaXIoc3RydWN0IGV2ZW50 ZnNfaW5vZGUgKnBhcmVudCwgCj4gICBzdHJ1Y3QgdHJhY2VfZXZlbnRfZmlsZSAqZmlsZSkgCj4g ICB7Cj4gICAgICAgICAuLi4KPiAgICAgICAgIC4uLgo+ICAgICAgICAgLi4uCj4gICAgICAgICBu cl9lbnRyaWVzID0gQVJSQVlfU0laRShldmVudF9lbnRyaWVzKTsKPiAKPiAgICAgICAgIG5hbWUg PSB0cmFjZV9ldmVudF9uYW1lKGNhbGwpOwo+IAo+ICAgICAgICAgK2V2ZW50X2ZpbGVfZ2V0KGZp bGUpOyAgICAgICAgLy8gTGluZSBBCj4gICAgICAgICAgICAgXl5eXl5eXl5eXl5eXgo+ICAgICAg ICAgLy8gU2hvdWxkIHdlIG1vdmUgdGhlICJldmVudF9maWxlX2dldCIgdG8gaGVyZSwgaW5zdGVh ZCAgCj4gICAgICAgICAvLyBvZiBjYWxsaW5nIGl0IGF0IGxpbmUgQz8KPiAgICAgICAgIC8vIER1 ZSB0byBMaW5lIEIgY291bGQgZXZlbnR1YWxseSBpbnZva2UgImV2ZW50X2ZpbGVfcHV0Ii4KPiAg ICAgICAgIC8vICAgZXZlbnRmc19jcmVhdGVfZGlyIC0+IGZyZWVfZWkgLT5wdXRfZWkgLT4ga3Jl Zl9wdXQgCj4gICAgICAgICAvLyAgLT4gcmVsZWFzZV9laSAtPiBldmVudF9yZWxlYXNlIC0+IGV2 ZW50X2ZpbGVfcHV0Cj4gICAgICAgICAvLyBOb3Qgc3VyZSBpZiB0aGlzIGlzIGEgcG90ZW50aWFs IHJpc2s/IElmIExpbmUgQiBkbyBjYWxsICAgCj4gICAgICAgICAvLyBldmVudF9maWxlX3B1dCwi ZXZlbnRfZmlsZV9wdXQiIHdpbGwgYmUgY2FsbGVkIHByaW9yIHRvCj4gICAgICAgICAvLyAiZXZl bnRfZmlsZV9nZXQiLCBjb3VsZCBjb3JydXB0IHRoZSByZWZlcmVuY2Ugb2YgdGhlIGZpbGUuCgpO bywgYnV0IHlvdSBkbyBicmluZyB1cCBhIGdvb2QgcG9pbnQuIFRoZSByZWxlYXNlIHNob3VsZCBu b3QgYmUgY2FsbGVkIG9uCmVycm9yLCBidXQgaXQgbG9va3MgbGlrZSBpdCBwb3NzaWJseSBjYW4g YmUuCgo+IAo+ICAgICAgICAgZWkgPSBldmVudGZzX2NyZWF0ZV9kaXIobmFtZSwgZV9ldmVudHMs ICAgIC8vIExpbmUgQiAKPiAgICAgICAgICAgICAgZXZlbnRfZW50cmllcywgbnJfZW50cmllcywg ZmlsZSk7Cj4gICAgICAgICBpZiAoSVNfRVJSKGVpKSkgewo+ICAgICAgICAgICAgICAgICBwcl93 YXJuKCJDb3VsZCBub3QgY3JlYXRlIHRyYWNlZnMgJyVzJyBkaXJlY3RvcnlcbiIsIAo+ICAgICAg ICAgICAgICAgICBuYW1lKTsKPiAgICAgICAgICAgICAgICAgcmV0dXJuIC0xOwo+ICAgICAgICAg fQo+ICAgICAgICAgZmlsZS0+ZWkgPSBlaTsKPiAKPiAgICAgICAgIHJldCA9IGV2ZW50X2RlZmlu ZV9maWVsZHMoY2FsbCk7Cj4gICAgICAgICBpZiAocmV0IDwgMCkgewo+ICAgICAgICAgICAgICAg ICBwcl93YXJuKCJDb3VsZCBub3QgaW5pdGlhbGl6ZSB0cmFjZSBwb2ludCBldmVudHMvJXNcbiIs Cj4gbmFtZSk7Cj4gICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gICAgICAgICAgICAgICAg ICAgIF5eXl5eXl5eXiAgICAgICAgICAKPiAgICAgICAgLy8gTWF5YmUgd2UgY2hvdWxkIGhhdmUg c2ltaWxhciBjb25jZXJuIGlmIHdlIHJldHVybiBoZXJlLgo+ICAgICAgICAvLyBEdWUgdG8gdGhl IGV2ZW50X2lub2RlIGhhZCBiZWVuIGNyZWF0ZWQsIGJ1dCB3ZSBkaWQgbm90IGNhbGwgCj4gICAg ICAgIC8vIGV2ZW50X2ZpbGVfZ2V0LiAKPiAgICAgICAgLy8gQ291bGQgaXQgbGVhZCB0byBzb21l IGlzc3VlcyBpbiB0aGUgZnV0dXJlIHdoaWxlIGZyZWVpbmcgCj4gICAgICAgIC8vIGV2ZW50X2lu ZG9lPwo+ICAgICAgICAgfQo+IAo+IAo+ICAgICAgICAgLWV2ZW50X2ZpbGVfZ2V0KGZpbGUpOyAg ICAgICAvL0xpbmUgQwo+ICAgICAgICAgcmV0dXJuIDA7Cj4gICB9CgpUaGlzIHByZXZlbnRzIHRo ZSByZWxlYXNlKCkgZnVuY3Rpb24gZnJvbSBiZWluZyBjYWxsZWQgb24gZmFpbHVyZSBvZgpjcmVh dGluZyB0aGUgZWkuCgpDYW4geW91IHRyeSB0aGlzIHBhdGNoIGluc3RlYWQ/CgotLSBTdGV2ZQoK ZGlmZiAtLWdpdCBhL2ZzL3RyYWNlZnMvZXZlbnRfaW5vZGUuYyBiL2ZzL3RyYWNlZnMvZXZlbnRf aW5vZGUuYwppbmRleCA4OTRjNmNhMWU1MDAuLmY1NTEwZTI2ZjBmNiAxMDA2NDQKLS0tIGEvZnMv dHJhY2Vmcy9ldmVudF9pbm9kZS5jCisrKyBiL2ZzL3RyYWNlZnMvZXZlbnRfaW5vZGUuYwpAQCAt ODQsMTAgKzg0LDE3IEBAIGVudW0gewogc3RhdGljIHZvaWQgcmVsZWFzZV9laShzdHJ1Y3Qga3Jl ZiAqcmVmKQogewogCXN0cnVjdCBldmVudGZzX2lub2RlICplaSA9IGNvbnRhaW5lcl9vZihyZWYs IHN0cnVjdCBldmVudGZzX2lub2RlLCBrcmVmKTsKKwljb25zdCBzdHJ1Y3QgZXZlbnRmc19lbnRy eSAqZW50cnk7CiAJc3RydWN0IGV2ZW50ZnNfcm9vdF9pbm9kZSAqcmVpOwogCiAJV0FSTl9PTl9P TkNFKCFlaS0+aXNfZnJlZWQpOwogCisJZm9yIChpbnQgaSA9IDA7IGkgPCBlaS0+bnJfZW50cmll czsgaSsrKSB7CisJCWVudHJ5ID0gJmVpLT5lbnRyaWVzW2ldOworCQlpZiAoZW50cnktPnJlbGVh c2UpCisJCQllbnRyeS0+cmVsZWFzZShlbnRyeS0+bmFtZSwgZWktPmRhdGEpOworCX0KKwogCWtm cmVlKGVpLT5lbnRyeV9hdHRycyk7CiAJa2ZyZWVfY29uc3QoZWktPm5hbWUpOwogCWlmIChlaS0+ aXNfZXZlbnRzKSB7CkBAIC0xMTIsNiArMTE5LDE4IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBmcmVl X2VpKHN0cnVjdCBldmVudGZzX2lub2RlICplaSkKIAl9CiB9CiAKKy8qCisgKiBDYWxsZWQgd2hl biBjcmVhdGlvbiBvZiBhbiBlaSBmYWlscywgZG8gbm90IGNhbGwgcmVsZWFzZSgpIGZ1bmN0aW9u cy4KKyAqLworc3RhdGljIGlubGluZSB2b2lkIGNsZWFudXBfZWkoc3RydWN0IGV2ZW50ZnNfaW5v ZGUgKmVpKQoreworCWlmIChlaSkgeworCQkvKiBTZXQgbnJfZW50cmllcyB0byAwIHRvIHByZXZl bnQgcmVsZWFzZSgpIGZ1bmN0aW9uIGJlaW5nIGNhbGxlZCAqLworCQllaS0+bnJfZW50cmllcyA9 IDA7CisJCWZyZWVfZWkoZWkpOworCX0KK30KKwogc3RhdGljIGlubGluZSBzdHJ1Y3QgZXZlbnRm c19pbm9kZSAqZ2V0X2VpKHN0cnVjdCBldmVudGZzX2lub2RlICplaSkKIHsKIAlpZiAoZWkpCkBA IC03MzQsNyArNzUzLDcgQEAgc3RydWN0IGV2ZW50ZnNfaW5vZGUgKmV2ZW50ZnNfY3JlYXRlX2Rp cihjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgZXZlbnRmc19pbm9kZQogCiAJLyogV2FzIHRoZSBw YXJlbnQgZnJlZWQ/ICovCiAJaWYgKGxpc3RfZW1wdHkoJmVpLT5saXN0KSkgewotCQlmcmVlX2Vp KGVpKTsKKwkJY2xlYW51cF9laShlaSk7CiAJCWVpID0gTlVMTDsKIAl9CiAJcmV0dXJuIGVpOwpA QCAtODM1LDcgKzg1NCw3IEBAIHN0cnVjdCBldmVudGZzX2lub2RlICpldmVudGZzX2NyZWF0ZV9l dmVudHNfZGlyKGNvbnN0IGNoYXIgKm5hbWUsIHN0cnVjdCBkZW50cnkKIAlyZXR1cm4gZWk7CiAK ICBmYWlsOgotCWZyZWVfZWkoZWkpOworCWNsZWFudXBfZWkoZWkpOwogCXRyYWNlZnNfZmFpbGVk X2NyZWF0aW5nKGRlbnRyeSk7CiAJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7CiB9CmRpZmYgLS1n aXQgYS9pbmNsdWRlL2xpbnV4L3RyYWNlZnMuaCBiL2luY2x1ZGUvbGludXgvdHJhY2Vmcy5oCmlu ZGV4IDdhNWZlMTdiNmJmOS4uZDAzZjc0NjU4NzE2IDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4 L3RyYWNlZnMuaAorKysgYi9pbmNsdWRlL2xpbnV4L3RyYWNlZnMuaApAQCAtNjIsNiArNjIsOCBA QCBzdHJ1Y3QgZXZlbnRmc19maWxlOwogdHlwZWRlZiBpbnQgKCpldmVudGZzX2NhbGxiYWNrKShj b25zdCBjaGFyICpuYW1lLCB1bW9kZV90ICptb2RlLCB2b2lkICoqZGF0YSwKIAkJCQljb25zdCBz dHJ1Y3QgZmlsZV9vcGVyYXRpb25zICoqZm9wcyk7CiAKK3R5cGVkZWYgdm9pZCAoKmV2ZW50ZnNf cmVsZWFzZSkoY29uc3QgY2hhciAqbmFtZSwgdm9pZCAqZGF0YSk7CisKIC8qKgogICogc3RydWN0 IGV2ZW50ZnNfZW50cnkgLSBkeW5hbWljYWxseSBjcmVhdGVkIGV2ZW50ZnMgZmlsZSBjYWxsIGJh Y2sgaGFuZGxlcgogICogQG5hbWU6CVRoZW4gbmFtZSBvZiB0aGUgZHluYW1pYyBmaWxlIGluIGFu IGV2ZW50ZnMgZGlyZWN0b3J5CkBAIC03Miw2ICs3NCw3IEBAIHR5cGVkZWYgaW50ICgqZXZlbnRm c19jYWxsYmFjaykoY29uc3QgY2hhciAqbmFtZSwgdW1vZGVfdCAqbW9kZSwgdm9pZCAqKmRhdGEs CiBzdHJ1Y3QgZXZlbnRmc19lbnRyeSB7CiAJY29uc3QgY2hhcgkJCSpuYW1lOwogCWV2ZW50ZnNf Y2FsbGJhY2sJCWNhbGxiYWNrOworCWV2ZW50ZnNfcmVsZWFzZQkJCXJlbGVhc2U7CiB9OwogCiBz dHJ1Y3QgZXZlbnRmc19pbm9kZTsKZGlmZiAtLWdpdCBhL2tlcm5lbC90cmFjZS90cmFjZV9ldmVu dHMuYyBiL2tlcm5lbC90cmFjZS90cmFjZV9ldmVudHMuYwppbmRleCA1MmY3NWMzNmJiY2EuLjZl ZjI5ZWJhOTBjZSAxMDA2NDQKLS0tIGEva2VybmVsL3RyYWNlL3RyYWNlX2V2ZW50cy5jCisrKyBi L2tlcm5lbC90cmFjZS90cmFjZV9ldmVudHMuYwpAQCAtMjU1Miw2ICsyNTUyLDE0IEBAIHN0YXRp YyBpbnQgZXZlbnRfY2FsbGJhY2soY29uc3QgY2hhciAqbmFtZSwgdW1vZGVfdCAqbW9kZSwgdm9p ZCAqKmRhdGEsCiAJcmV0dXJuIDA7CiB9CiAKKy8qIFRoZSBmaWxlIGlzIGluY3JlbWVudGVkIG9u IGNyZWF0aW9uIGFuZCBmcmVlaW5nIHRoZSBlbmFibGUgZmlsZSBkZWNyZW1lbnRzIGl0ICovCitz dGF0aWMgdm9pZCBldmVudF9yZWxlYXNlKGNvbnN0IGNoYXIgKm5hbWUsIHZvaWQgKmRhdGEpCit7 CisJc3RydWN0IHRyYWNlX2V2ZW50X2ZpbGUgKmZpbGUgPSBkYXRhOworCisJZXZlbnRfZmlsZV9w dXQoZmlsZSk7Cit9CisKIHN0YXRpYyBpbnQKIGV2ZW50X2NyZWF0ZV9kaXIoc3RydWN0IGV2ZW50 ZnNfaW5vZGUgKnBhcmVudCwgc3RydWN0IHRyYWNlX2V2ZW50X2ZpbGUgKmZpbGUpCiB7CkBAIC0y NTY2LDYgKzI1NzQsNyBAQCBldmVudF9jcmVhdGVfZGlyKHN0cnVjdCBldmVudGZzX2lub2RlICpw YXJlbnQsIHN0cnVjdCB0cmFjZV9ldmVudF9maWxlICpmaWxlKQogCQl7CiAJCQkubmFtZQkJPSAi ZW5hYmxlIiwKIAkJCS5jYWxsYmFjawk9IGV2ZW50X2NhbGxiYWNrLAorCQkJLnJlbGVhc2UJPSBl dmVudF9yZWxlYXNlLAogCQl9LAogCQl7CiAJCQkubmFtZQkJPSAiZmlsdGVyIiwKQEAgLTI2MzQs NiArMjY0Myw5IEBAIGV2ZW50X2NyZWF0ZV9kaXIoc3RydWN0IGV2ZW50ZnNfaW5vZGUgKnBhcmVu dCwgc3RydWN0IHRyYWNlX2V2ZW50X2ZpbGUgKmZpbGUpCiAJCXJldHVybiByZXQ7CiAJfQogCisJ LyogR2V0cyBkZWNyZW1lbnRlZCBvbiBmcmVlaW5nIG9mIHRoZSAiZW5hYmxlIiBmaWxlICovCisJ ZXZlbnRfZmlsZV9nZXQoZmlsZSk7CisKIAlyZXR1cm4gMDsKIH0KIAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=