From: Kent Gibson <warthog618@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH] pinctrl: bcm2835: Make pin freeing behavior configurable
Date: Thu, 2 May 2024 19:04:42 +0800 [thread overview]
Message-ID: <20240502110442.GA315256@rigel> (raw)
In-Reply-To: <9a7fe0d8-ff44-4904-84cd-7b133f40a74b@gmx.net>
On Thu, May 02, 2024 at 12:22:07PM +0200, Stefan Wahren wrote:
> Am 19.04.24 um 22:40 schrieb Stefan Wahren:
> > Until now after a bcm2835 pin was freed its pinmux was set to GPIO_IN.
> > So in case it was configured as GPIO_OUT before the configured output
> > level also get lost. As long as GPIO sysfs was used this wasn't
> > actually a problem because the pins and their possible output level
> > were kept by sysfs.
> >
> > Since more and more Raspberry Pi users start using libgpiod they are
> > confused about this behavior. So make the pin freeing behavior of
> > GPIO_OUT configurable via module parameter. In case
> > pinctrl-bcm2835.strict_gpiod is set to 0, the output level is kept.
> >
> > This patch based on the downstream work of Phil Elwell.
> >
> > Link: https://github.com/raspberrypi/linux/pull/6117
> > Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> > ---
> > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 20 ++++++++++++++++----
> > 1 file changed, 16 insertions(+), 4 deletions(-)
> Gentle ping ...
I can't comment on the substance of the change as pinctrl is outside my
wheelhouse, but the "strict_gpiod" name could be better.
The point is to make GPIO outputs persist, right?
The name should better reflect that.
Cheers,
Kent.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-02 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 20:40 [PATCH] pinctrl: bcm2835: Make pin freeing behavior configurable Stefan Wahren
2024-05-02 10:22 ` Stefan Wahren
2024-05-02 11:04 ` Kent Gibson [this message]
2024-05-02 11:11 ` Stefan Wahren
2024-05-02 11:15 ` Kent Gibson
2024-05-02 12:20 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502110442.GA315256@rigel \
--to=warthog618@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=florian.fainelli@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox