From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04344C4345F for ; Thu, 2 May 2024 11:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4MxB9eQabck/mrmPjlR7EiZc7kuZH4MaltXN2+jy4mI=; b=mtFJQJIjYTlvON 9J2vxD7Pkh7gWYt5ct8GJdtHUZbtHw0Uvvfy48j+RZ0UZ7O+q0sZpJJDfaVc1mjieLSlo1j/Uz4GL lQ5wTZdVZdCPvgrx3AzqIhEsv3ccZ+pEWt4MZ0uPpMDqWnDVEciWmsGLTxejh2ZVRAdPdCvS9AQow czlAZfjcXfH2n89Uqc54+KbaIe3EgfY+Q64AtS1cSzUfTCwMLQ327nn5SfYwNoMOgZN99Qs6JRj7g 8TcycxRps+zPkp2r9aaV9fh95e0YEU2QBpE5ojy7NGVPnIfXWhrjRGGWm5N6fwcHyDPwoNKrTe2K5 2puOadY144PPU0BxS/ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UPw-0000000CUBT-1EiP; Thu, 02 May 2024 11:16:00 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UPs-0000000CUAb-4546 for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2024 11:15:58 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ee13f19e7eso7143248b3a.1 for ; Thu, 02 May 2024 04:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714648552; x=1715253352; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CGaACSE4MwJ6Pe+hdX/NkfL8aqvU77wkScT/ddvgb5o=; b=MwhfokMv4CkQ9DgUPd7zhcR8lwNuUuAHkgay6RNJrRmGlfhbyhPoad7aNsS7RJMsTK fPbJfqiVPa9+JOabiPIQO2ISXi/HnyqQJ3zwVKPeGlWEaJPODF6IZil9vb1tkJmzZFNj fZsBGokgZEoe7Bvw0LPvm833k6FgGsVsO1KLF6hScuyTfo1C9D6BDa+bHrhCIq2wmOCe pcydo6orYouPIjCstCXro6KfQ+2w5MoBWI6uCRQMLRn7Bc2TYnVrp/yxUEb+AbjTnQrP BbVPJvKUGnqD3Z9N2OjH1OxSKp84isTKQ/8scRSpbSsEqQbjWOmLJrF1TcaZg69BEwiA R+LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714648552; x=1715253352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CGaACSE4MwJ6Pe+hdX/NkfL8aqvU77wkScT/ddvgb5o=; b=sT0W3I4atG9tZyln4g/WvL3L6Bxuoj5QNV6oF0Y7w5MIQjj2jhLKfjHabaVpCfbQ8s ZPG/k03Cgmxmn2bKFKRUlf1B32MRYNBDALMxNyQY5LnZOngXqCaE5AvqKjZUyWhSrEn0 wp3cItueTyuHxQqTXcnT6I7ydUdfG2kaFQRDu6y13HgIDgqrRXxZUweJl0M9bzmidKHR AlUVXrVY8MlEKA/nm3kRQKhpVOULSer3GQgHvgS80nJ0pxHnC/lbnOiLGkLwDHBYr3MM Qh32x08a0xsem7I5s72X/DMF7EAoMtr3sjkQqMc3Zws4pRD+mQwqCtM/djFVQQOT45kj aeAw== X-Forwarded-Encrypted: i=1; AJvYcCVnZyhMYHYKDe3xlo+N0JjmCqTSNJpIZqxUfq3K2DxwtuK/xQmFNMJslWADPR42hMJfZJ24dQvr3LEoyZrHljDdPHs/I6DCWxcIN9dSepK/H+Q19/Q= X-Gm-Message-State: AOJu0YzExoKeK9GQu4w5HF8ZdJAB7S5syQZCEfuRxokDSPkoNm516Fmo 8XP2UTiJ83Aw+S+KHH8u08P/rwmfdVRopb1EiU4npkddFbn7mpJs X-Google-Smtp-Source: AGHT+IGZc80GHFLBZllCWwlzM6EGYuEmy8SeDHLVi/ENP3PPdYt+o9q7ax4W2SGhgt7a308rbnkMpg== X-Received: by 2002:a05:6a00:2daa:b0:6ea:c3bc:2031 with SMTP id fb42-20020a056a002daa00b006eac3bc2031mr6430186pfb.7.1714648552406; Thu, 02 May 2024 04:15:52 -0700 (PDT) Received: from rigel (14-200-166-65.static.tpgi.com.au. [14.200.166.65]) by smtp.gmail.com with ESMTPSA id m22-20020a056a00081600b006f2e10b00d6sm980877pfk.41.2024.05.02.04.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 04:15:52 -0700 (PDT) Date: Thu, 2 May 2024 19:15:46 +0800 From: Kent Gibson To: Stefan Wahren Cc: Linus Walleij , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Phil Elwell Subject: Re: [PATCH] pinctrl: bcm2835: Make pin freeing behavior configurable Message-ID: <20240502111546.GA325017@rigel> References: <20240419204057.86078-1-wahrenst@gmx.net> <9a7fe0d8-ff44-4904-84cd-7b133f40a74b@gmx.net> <20240502110442.GA315256@rigel> <79627aeb-8151-430c-98f4-5689fd61413f@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <79627aeb-8151-430c-98f4-5689fd61413f@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_041557_032851_C928F306 X-CRM114-Status: GOOD ( 25.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 01:11:06PM +0200, Stefan Wahren wrote: > Hi Kent, > > Am 02.05.24 um 13:04 schrieb Kent Gibson: > > On Thu, May 02, 2024 at 12:22:07PM +0200, Stefan Wahren wrote: > > > Am 19.04.24 um 22:40 schrieb Stefan Wahren: > > > > Until now after a bcm2835 pin was freed its pinmux was set to GPIO_IN. > > > > So in case it was configured as GPIO_OUT before the configured output > > > > level also get lost. As long as GPIO sysfs was used this wasn't > > > > actually a problem because the pins and their possible output level > > > > were kept by sysfs. > > > > > > > > Since more and more Raspberry Pi users start using libgpiod they are > > > > confused about this behavior. So make the pin freeing behavior of > > > > GPIO_OUT configurable via module parameter. In case > > > > pinctrl-bcm2835.strict_gpiod is set to 0, the output level is kept. > > > > > > > > This patch based on the downstream work of Phil Elwell. > > > > > > > > Link: https://github.com/raspberrypi/linux/pull/6117 > > > > Signed-off-by: Stefan Wahren > > > > --- > > > > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 20 ++++++++++++++++---- > > > > 1 file changed, 16 insertions(+), 4 deletions(-) > > > Gentle ping ... > > I can't comment on the substance of the change as pinctrl is outside my > > wheelhouse, but the "strict_gpiod" name could be better. > > The point is to make GPIO outputs persist, right? > Yes, correct. > > The name should better reflect that. > Finding good and short names is hard, do you have a suggestion? > How about "persist_gpio_outputs"? Cheers, Kent. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel