From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 672CDC4345F for ; Fri, 3 May 2024 13:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fnnmPLTN7HQ4jsKSUzP0Aaq3EAtnlllKrvd4P7Hi8T4=; b=szKOYta7osKRwH /kV+zqXl9v9yZBp6DuKNqiX3FZXp9JI8KZtxQ3dQuDWfRcNdjhL+w1wylLj7PbdnkPtSc9fnO4dJf x7UNIFHp5hX7hFPlGJmQ1/lZRTUiV32QNi0FmLKQgQZgpK5UDFbYxu9OjYbmYuzpCvAqosaUDAFVz WO0AX3FQMHe3oEkqAKdk23v6Jw8GLJeAiHVFyD0bmpz2qXw4wu3485SCFTO4D+Gh0SQLyi/MUUnXZ zHGMTSE8kapMQttxnphFvTYglj5bxxKS4C92x3Tsq9J9N8/t7mpEVovys8+AGMCk7RGgEOz0j4fOa GF+CjcNZquiJf0CViOBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2su2-0000000Geha-46Lt; Fri, 03 May 2024 13:24:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2su1-0000000Gegx-1L6x for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 13:24:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 92B8E61C83; Fri, 3 May 2024 13:24:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1172FC116B1; Fri, 3 May 2024 13:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714742679; bh=vBejc4y26BCn3jsVAONmf4WH+VOYO6P0hxMPw087VT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YAAMtZkaKaPmLIMMrzKy1xRAU9cA+SRW0uBiMhQw8xje/Yr3ZK0z7KC0jht54W2JL XZC8RfTVVrk3/1JMgs3RPDVIwmFEo5YTKI0iBMIng6dAPFXO7Icv3gjqDV19ewqjPa PVaF5CcsBVvmhf7pxREDdCvFGAMWTTaGc0/PBXx4EP3k3ksP53vOt0ejW5+ZXBjKIF wxkBbAHveeNqepoBEzwvbHRkX9GSrnZaufLn0d0e18xsNnWhVjKvdXYKAfn50xqbZD FdkPm770QijZ6/pRNvnar5RYKZ1/LEzhsRUlm3xoIfBdWufXjyY+iybWdgwHuVjAeQ Y0Rkk35uiMRiA== Date: Fri, 3 May 2024 08:24:38 -0500 From: Rob Herring To: Josua Mayer Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Conor Dooley , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Message-ID: <20240503132438.GA460984-robh@kernel.org> References: <20240502-cn9130-som-v4-0-0a2e2f1c70d8@solid-run.com> <20240502-cn9130-som-v4-4-0a2e2f1c70d8@solid-run.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_062441_472466_86F5DE4F X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 05:35:44PM +0000, Josua Mayer wrote: > Am 02.05.24 um 14:32 schrieb Josua Mayer: > > Add description for the SolidRun CN9131 SolidWAN, based on CN9130 SoM > > with an extra communication processor on the carrier board. > > > > This board differentiates itself from CN9130 Clearfog by providing > > additional SoC native network interfaces and pci buses: > > 2x 10Gbps SFP+ > > 4x 1Gbps RJ45 > > 1x miniPCI-E > > 1x m.2 b-key with sata, usb-2.0 and usb-3.0 > > 1x m.2 m-key with pcie and usb-2.0 > > 1x m.2 b-key with pcie, usb-2.0, usb-3.0 and 2x sim slots > > 1x mpcie with pcie only > > 2x type-a usb-2.0/3.0 > > > > Signed-off-by: Josua Mayer > > --- > > arch/arm64/boot/dts/marvell/Makefile | 1 + > > arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 643 +++++++++++++++++++++ > > 2 files changed, 644 insertions(+) > > > cut > > + /* Type-A port on J53 */ > > + reg_usb_a_vbus0: regulator-usb-a-vbus0 { > > + compatible = "regulator-fixed"; > > + pinctrl-0 = <&cp0_reg_usb_a_vbus0_pins>; > > + pinctrl-names = "default"; > > + regulator-name = "vbus0"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-oc-protection-microamp = <1000000>; > > Is it correct to specify over-current protection for a > regulator-fixed? It causes kernel messages: > > [ 7.988337] vbus0: IC does not support requested over-current limits > [ 7.994756] vbus0: IC does not support requested over voltage limits > [ 7.998796] vbus1: IC does not support requested over-current limits > ... Seems like you have your answer... > > The reason I put the property was that the 1A limit is a property of > the regulator component (NCP380-1.0A). Maybe that is the wrong property? > > It also generates an interrupt for which I found no suitable description. Then you should describe the actual device because it is not just a regulator-fixed. I suppose we could consider adding an interrupt to regulator-fixed, but then its function can only be for (presumably) over-current. Even details on how to handle it could vary as well. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel