From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99882C4345F for ; Fri, 3 May 2024 13:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v1iFV4ar0v6IjoegZ2QaHv6hRr1Pfj+McIKPw9wFdbk=; b=1SIdT7hGJ04+1T g6VTTMWqsHmniKiJtLU3r2lCVoaWG+VvASCpJLuhRTyrPhvmgCcvqDvwYgsuOafgS6UGPbJignRga i/a7TBanK3SFCEWOAUIWWxamraxOSwFz8JTnEwEWSd5SzSH/bxeVR5Zr9wmEjDX4XT1JKWaXp2ykH MiOMnMhoIu8BpV0/D4BWsT1NQP5UfLzUs9xRqgjMx85hG8eUhc5s5XlFOX5cN+h09/+mSmNFW7n8u sWyyzInB0CSvRRPYyRgPO+m4ECVbgOiEagps58vuxaKeu9tQFYpOjxfTou/0yicAPzQe6Z6AR4ElL nEv56lfZBRVlvH6BiV4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2tEs-0000000GiUB-2OHh; Fri, 03 May 2024 13:46:14 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2tEo-0000000GiTK-44Py for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 13:46:13 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E04E593; Fri, 3 May 2024 15:45:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1714743907; bh=P1392OE/D563sFcVxXWa6Sf/hW9rxpl/vL+Fg+RCMug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oa2frlkA0Xy97uj0P9LJaPM9zXN0ypCbVdn3TA42ZaykQHHDQPl7CwohtUSF+RdZ8 PvQbnjLqpT9pC/LwCkj605hnQz6GSDK3oCEiv4PtYMX6JodxKmCOR9irbrZYBrP8Ch rGQPt6xnOi+gUgJbiFCU0bTJM3OjslMrP+vj19R8= Date: Fri, 3 May 2024 16:45:57 +0300 From: Laurent Pinchart To: Alexander Stein Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Paul Elder , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock Message-ID: <20240503134557.GC13904@pendragon.ideasonboard.com> References: <20240416141914.9375-1-marex@denx.de> <2327389.ElGaqSPkdT@steina-w> <3311352.aeNJFYEL58@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3311352.aeNJFYEL58@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_064611_181751_DB983EFD X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 03, 2024 at 02:58:19PM +0200, Alexander Stein wrote: > Am Mittwoch, 17. April 2024, 11:12:04 CEST schrieb Alexander Stein: > > Am Dienstag, 16. April 2024, 16:19:10 CEST schrieb Marek Vasut: > > > Configure both CSI2 assigned-clock-rates the same way. > > > There does not seem to be any reason for keeping the > > > two CSI2 pixel clock set to different frequencies. > > > > > > This also reduces first CSI2 clock from overdrive mode > > > frequency which is 500 MHz down below the regular mode > > > frequency of 400 MHz. > > > > > > Signed-off-by: Marek Vasut > > > > Apparently there is no difference when using imx415 (3840x2160) sensor. > > Just for the records: While this change does not affect imx415 (3840x2160) > processing, reducing clock-frequency as well (v3) imx415 does not work. > So I assume that for this image size a higher than default frequency is > required. For the time being I expect sensor overlays to override the default clock setup. Ideally the clock frequencies should be configured automatically at runtime by the CSI-2 RX driver. > > Reviewed-by: Alexander Stein > > > > > --- > > > Cc: Conor Dooley > > > Cc: Fabio Estevam > > > Cc: Krzysztof Kozlowski > > > Cc: Laurent Pinchart > > > Cc: Paul Elder > > > Cc: Pengutronix Kernel Team > > > Cc: Rob Herring > > > Cc: Sascha Hauer > > > Cc: Shawn Guo > > > Cc: devicetree@vger.kernel.org > > > Cc: imx@lists.linux.dev > > > Cc: linux-arm-kernel@lists.infradead.org > > > --- > > > V2: Align both clock to 266 MHz and update commit message > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > index 1bb96e96639f2..7883f5c056f4e 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -1667,7 +1667,7 @@ mipi_csi_0: csi@32e40000 { > > > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > > > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > > > <&clk IMX8MP_CLK_24M>; > > > - assigned-clock-rates = <500000000>; > > > + assigned-clock-rates = <266000000>; > > > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > > > status = "disabled"; > > > > > > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel