From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AE48C4345F for ; Sat, 4 May 2024 00:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=pGNIOACUt1o7OSdjQ196XKCC9iHIEG3lRBARuP8OpSI=; b=qDaF+rhPnU7FI63hX7q1czQqcL Vsc+Q031FD43Krkn14CXfpW4dOSG8sq/rYRG/+MUcjr5O8tW6veFzvkRoB2mtc9KaSo4j9KNq1DIe STpBdNaGAmWJsYlVeyWD1o+ZVwAPF1iH9eiO4G4fz2qsx5QeyoYhmt8YBl92TnlUw0f8x3zUkfRbY VYSkvXckewJCLEbueno6l9x41ID0v6vNX3wyBJGt8vGmf0FFrb71hfpfd7NgWVW2f6wJJCjnEYrvS yMR/Nt2ysY9kLohm69jvqtg8bX0rfR7DINDiO7oyc/+1p7VQQlgTrQxRhjfQhYs739DzvdgzQXwpL tOOTCjDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s33TP-00000000tAN-0OUg; Sat, 04 May 2024 00:41:55 +0000 Received: from mail-am7eur03on20600.outbound.protection.outlook.com ([2a01:111:f403:260e::600] helo=EUR03-AM7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s33TH-00000000t3e-3qMF for linux-arm-kernel@lists.infradead.org; Sat, 04 May 2024 00:41:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CdXXZ+fqxUnZuecoBlyRWhPPrFbGqJLCUx7+sc8UIytdJX3TpVrsp8yDeFQ/W1fp2RgIO6wG3c0N0oEA4laKa0SkNSVRKYDKGBHoAXxLQAHpD5jrRFIuR4f5boyPO2ywhxkyW5T2vEIXNNhBBZ47mprICR8NLSxZj2oyT+DzivQ3PBB/6gtAX0+l+t7sAmqAEe/yj729NDePCqlNjXs/doAu8fAY1xJVeLwVQkujHcxgGhcF40KLYsUEoLcVGKI9+fb5/Ts19bVYox8H931b4GiXM/7NQsx/eswUFgOIS9TlAk0FImPqDaKCocwqdm9uXIWizk/JJoRbxvhfEG4Vuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gd6H0t/yI/bSoUA0/9la81Hj7KLRUVbJaaIyMyJ4tb4=; b=Kz32p+dufuC2WnmpECJ6bAsPEIXovRKfKDQze2vzYYnzgAoSZxG/0LJ0IKq95GTn3b2yBQ32Do/WbuhqoAPpZ4Zj7ojpb2ZKoLnDya1yE5eL8qtVpL2KR+sMkVTvU4afXfTz1faaul95P7w/wT/BrA1VufHOZVwSvT4J7BXgjQXceNzPGlLuzqKvkmyzKE28Nlxyy/mK0FvHO9Kj0I38bM2Uu1B5/UqFKEUaT3sGMXriQ3VEOwfKPJDZPlLkdwbqIf12/pbKAc4OseK1fgNl+Q7ogm1ktIK2NjwM/eIYZfgnH8uJLtqBfxv5S4RbeJZjc5yGjkIVZLf+j1dtdUqX6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gd6H0t/yI/bSoUA0/9la81Hj7KLRUVbJaaIyMyJ4tb4=; b=YTPSITgOd3akPj0oOnAfA/adnGYWU/jO/betVZMAttbHcYv2R+ZBpuvnfj9AdOn1hrD02XncqWyYpJ2lxxESBPhO/vBtTkx2d04aYDspuku/paUzuNgtfQ0Y69VxHKrLvPbDLlu9JFv3z0bAeeu4Wen1Acj7bmn5yEaeLCt1Weg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB7726.eurprd04.prod.outlook.com (2603:10a6:102:ea::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Sat, 4 May 2024 00:41:41 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.029; Sat, 4 May 2024 00:41:41 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 08:49:00 +0800 Subject: [PATCH 07/18] clk: imx: pll14xx: potential integer overflow eliminated by casting to u64 Message-Id: <20240504-imx-clk-v1-7-f7915489d58d@nxp.com> References: <20240504-imx-clk-v1-0-f7915489d58d@nxp.com> In-Reply-To: <20240504-imx-clk-v1-0-f7915489d58d@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Bai , Ye Li , Dong Aisheng Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abel Vesa , Peng Fan , Florin Pavelescu , Viorel Suman X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714783747; l=1012; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=2UdxVIeKUK80+gL9caamcVMcYBZoguh0p2StT5CJdjU=; b=mAWBjvNWQhykSMMFGDAo5tfYl/Ef1TVTWQ/b1pc2IojjxoOMZdo+qn6NZ8QaxHr9aXGVayd7v Q0i60dKL0cKDgxO5nNpxRvuLFOT4Q9f3lOZgdG0ldocHmY71YPh30+G X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0055.apcprd02.prod.outlook.com (2603:1096:4:1f5::16) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB7726:EE_ X-MS-Office365-Filtering-Correlation-Id: cf4feb8b-cbeb-4ead-615b-08dc6bd2f71a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|52116005|366007|1800799015|376005|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SU5FZlVXUDg1VkdhcDlQOE9wcERZTDFZclMwRDlxSUhOTWd3UVBodFYyUUhs?= =?utf-8?B?c3BrdXM1aW9aZmpZWC9pYndPandXQU5RK2FTaHFXV0UySGJxcnE1UWovc3VQ?= =?utf-8?B?TU8wU1BleXBQcWFqaWJaR0twOENhWkRPK3ZJWGJ5ZTFwZUp5TG4rdS9aTkZ0?= =?utf-8?B?SFcrM004RVp1Y0lIUlNXMWlMbmtTWE9PekJNWVZEaloycmhKdThRN3lJdXB3?= =?utf-8?B?SDc4engzazVEVnBHYURTelBIWVFrWnlUYjAwZ1VJY3dIa0lId2kwblpvV2lQ?= =?utf-8?B?RnFTb0VheW42bHpEWlJpNFhNMGFRQjk4NkhQNHE4dys0RldMaTRBbjdnY0FK?= =?utf-8?B?d3p1ajRZd3EvUDRQZG9VNmkwV0RhSElBMkIrMy82MlNJT1M3VzBHaDQxTk5R?= =?utf-8?B?a0FwcVlaOVduY21ONnF5L3V5UW1nVGJkdmZncDRkcnVGcFlKUjY5VUZMT0p3?= =?utf-8?B?NlEySURRUHpIVEgxTHVKUzJOcmxmSXgvUjVOWk5BSmVCN2N4NGNYSm45cHVt?= =?utf-8?B?N3dkL1BCZGVFM2NEajh0V0ZoV2piRXl4ZUZLRmg1bHBYdXRTT1dYczgwWFdM?= =?utf-8?B?RVJ4MHI0aEZ3RXFKdllFY1U3cmZ5bjl3VE1ZeCtxaG93WC9pa1JQQkNlbVJO?= =?utf-8?B?ZXpsZXRvREptMjN5ZWEzdUpWTnlzT3p2emJ2elp5ZEVPTDBIb05MVkEyUlVn?= =?utf-8?B?cGc5cXllNGIzNEhvUHM4ZTFNUzFpa1p6TDdRb1g0U1ZMQjYvaHdzcGxBN0Mv?= =?utf-8?B?U21tTCtXVFZpSGk1bktZanZlS09ockdjbmFOUGRFV3RJTHFkb04yby9xYU1a?= =?utf-8?B?TmRhWmZrUjgzZWxLU3dBbWZ2L2FETkZydHFWU2RTejNJeERaWkFhakxBdklO?= =?utf-8?B?d1NPQkhZdnQ2aEJLS05BY1JLdDBkT2hnZWIzZG5UWXFqTnZEUDQ4Yk1uWjRC?= =?utf-8?B?MDRyeDVtbHQvZ2dMVExSeVdCUW5RV0FyWHo4MVpidU9vTWF1WDNIV0dDcGJG?= =?utf-8?B?QzJqdXJIVS9pUlFBRGx2Wm0rZldaK0h6c3plSjQvVktpbUdQS0FONjJabmE2?= =?utf-8?B?ZzY0MzdBak93eng4NXM1NnJKYmgrWEpYOVFrNFU0My9CVGNXdEZ5RThnM29L?= =?utf-8?B?bEJMZkNRRWR3SDBDZkVzaDRXeURzWWNGNDBqajloL00wZTVCdlFRbmZXd2Zm?= =?utf-8?B?NXA0SnlRY2dJTkhxdGxrajJzRmk4d0RkYnQvbEtzVjgrZEZRYVg4OXJMK1Bu?= =?utf-8?B?K2RuRmpFUktZd0grVkdPdkJwSUgwQ08vd2dHT0lZTG5Ea2J4OGlsY0ZYSTRF?= =?utf-8?B?Qjl4aGR5VW5UTXEveXh5dXNVajlYK0dpaHVpWVlaYmZ3Y1RmZTJaU1BIZUNq?= =?utf-8?B?dVJ3MHVZUkM5TllKdC9Ia0VXcG1mMS9jZFprN2JBR3NZeVB6Z3dnakFITnBW?= =?utf-8?B?OFBnWjlneERaQmdrLzYzRUR4aUxOS0dGa1BNRHVwbUhEdE1tcVU0RVc0aFgy?= =?utf-8?B?U2VuTHNrZjVoT2sxN3I5LzhLcFpSK05HOXZ1WTNlaDFvWTUxUVRWcTZWMVhU?= =?utf-8?B?V0w3TERUcVJNTDdtcUsyZGt3c09UdUVHc2VueU1QQmJ3VVp0a3lzQXJJdnNx?= =?utf-8?B?Z25OYmhEZ1VUVE9PRmxmTENjNUxRT1VXdHpzcWFCRE5Yc3Jrait4OTludEFs?= =?utf-8?B?aENkL0JwK2pLZGI1NWUySDRXb1I5RWZURm5xdEEwRktKVlc5ek5DU3VjMkpi?= =?utf-8?B?ZzFBeDNCNGxRVGJhQ2FST0VWK1dpWnNqTmFTS3h3c3M2T3FvZW5tUUxwb2w5?= =?utf-8?Q?wEeLajY6c9roudl71DHvTkUJkZLtDUVz25b60=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(52116005)(366007)(1800799015)(376005)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWlENk9PcGJlUXVxUDgrNEZYaTBuc2I5amVHS2J3Z2tOTzdjY3RZQ1V3dGVE?= =?utf-8?B?QzdId01USXZERnQyaHhlRDArUGs4T3daZW1qTlZGOG9lUFd6V05obk1Ebk5q?= =?utf-8?B?MkRiSXZCbit1S2ZlcFFva3F1K3oxVkpTNFJTOHdRUUpiRjlrVzNNTkJzK3Nw?= =?utf-8?B?YWhxSnlzVHF1TzhOL3JHbGd6KzZoR0laV0JIVEZ6NmdxODEzdjJlMWtFVTN3?= =?utf-8?B?Y1BMTHdVeEVtaTc5TlRMYUg4Q3BlejhtSHBqR2lIZHVOdGJZWEV6UkU2MFZN?= =?utf-8?B?L3RQeTlwN1Y1ZG5UWXlPdTMxTFpYTUxiMmRSN2VoeTZMcndNSVV6VGJOando?= =?utf-8?B?bmdFOGVYRnhiSG9odzdaVjFVb2hZRVF0cXRxY3RqY2tpem9qOGljeWJMMTcr?= =?utf-8?B?c0F6RlZoTWp4N1VJRkZOUERBZlhlNXhtbGVpQmNuZzdSd01MdGxzYmZVcmpC?= =?utf-8?B?aGNQaTlVRlYvY3RxT01kMWRVZWpjZ2s4MjVOalBDVndyZldSL2g2RDBlYzdy?= =?utf-8?B?YjcwMmJHMmdzMW8zTDZ2N0Z6MkRjY1FOSGlXSWo3d1ZLbUZvQU1BeWUxcTJh?= =?utf-8?B?dDArNlBYQ0xmTlRNMDh4dEF4V1J4WFRIQ0FjeTNqc3NtaDRNK0tjSHNPZG95?= =?utf-8?B?WEErMG9MeXgwU1QzYzBaLytZcTNVVzFNWkI2azNVdXRjcDNVS3lRcU9DNE42?= =?utf-8?B?TlkyMVZ0WW0rSTQ1WnNjcTV0SzRlWTd5dEFEZWh3VHpWcERPelgrMWMxNitY?= =?utf-8?B?ZGpCZTlzRnRjd1RkZ0JNcVNMTGFHZmM4VG9FTnVLL1RZN1d1RkFZNFMzSGdM?= =?utf-8?B?aXl2Q2ovTlNaOS9udWlrbnVCNHNjWHVkS1g1WUxSa2pRTGhEZFJMSWNEQ0FX?= =?utf-8?B?Nmx4UEk5TEUrejdqNTBGZ1lrSXc0ZlJNeFZrRGJtV2hUa1Q2NWtoc0Z2ZFRW?= =?utf-8?B?RVNLYThMY1JZVVFCY0VYK0w3cTQ0cXNCRUdwb1ZMcWZWS0QwYTUzM2JYTUdm?= =?utf-8?B?cjhSQk9PeUJkS0VRUjlTKzRIaHpGRzdTV09IY21nTUc3YjFzbzJhS1pFdVV6?= =?utf-8?B?T1JoMWc4WEZSNjM0WnQ3RUlEbGNYVzJBZGowKzcwUitubmJ2NzhTM3BPSlNG?= =?utf-8?B?SDJPRmtXV0tyd253WXlxaVliNTZ2ekVpaFl3M25veFpLU0t2NG03c2pGU3JL?= =?utf-8?B?NjlaM2lGTHpJeDJCeWpVUStqRWhuZUtYL2R2bWtRT1Y2TmZVQmRTSTRXVTJy?= =?utf-8?B?WDdDdXVwWnBkYlJhZmhnQUlRMFRNTm1sQlEyU0F4VlJ3Q0tsS21QSkYvTW9u?= =?utf-8?B?Zk53TTRvajNwV3IzYjlUUFljN3FLbWUvRm5mQjFKOVg4bFFVZjhVTjVPUHln?= =?utf-8?B?aDc5bWVtRjBCSjIxK0xBMmNpclBKWjNFNUhCYXlHZkozenN0MVVHREc0U0RE?= =?utf-8?B?RWw3ZDJUendISS9nUlF2SHRLU3NRT3ozdFVHaUl2QUlJOTNrM3dHRCt4SUVX?= =?utf-8?B?Y203TXk5UlhzVS9zMmgyWnh0NTQvYnpKcWNFemFUdjFjQ2w3MmplMkNRSzA3?= =?utf-8?B?Q3l2b1FBYTZEL21Scnk0TTZEVkNqY0RYWEFVVUczeEtNNC9TVFR1QmIzY0NO?= =?utf-8?B?Y2NHMHlxN2taT0k5Q0FocktQVEpVc3JwRnVaSThYcmg2TGd1dUMydzhhSTRQ?= =?utf-8?B?TFBLN0cyM1ZJOUswV2lqd2dqVlp6MXV1ek5pKy9ZeU5XTHVjcDNyOXJTZTA0?= =?utf-8?B?WWhtdHA1dGpXYXJBRFBDbUhzK21Gbnk4VUdhUDNMcnFTeVNiakNNeGJpdmpP?= =?utf-8?B?SzVTZFRWSyt6NDZySlFVeTdsVFRKSU9JekZ2UTVoUngrZnZ2OUJMbXlIRXY5?= =?utf-8?B?N1E0dHdRenduWmF5a3hpWFY3SWRVdWdpbnJ1RGpBclUvWml2NEEyelFBS0xQ?= =?utf-8?B?KzQram9xa3NNNnVKTmkrS1BJTHQrTFl3a0s5WitCdU1yTC8vRFdTdklidTlX?= =?utf-8?B?M0ZjQnE0VTRXZE5oL2hjVGxoZnlXcnI0QzBEYS95QnFUSGQ5U016VFNIK1dQ?= =?utf-8?B?N0dvVmhKVllCa3VzOS94ZXlDWWtSZ3pWYXRrWTllcmVvVloyMlJlQTZoZzhI?= =?utf-8?Q?vPJ7vaAHkZJfcwEhFZor1bNf6?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf4feb8b-cbeb-4ead-615b-08dc6bd2f71a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 00:41:41.3516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9+HsixEc4V9jtZdHKnMuJjLkDUP1W3YovuQgWleVt96+zD7bgI27hR1VCxTGxOLcxayfyr0jG04oji6FWsLAsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7726 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_174148_403322_3E6C9433 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Florin Pavelescu Cast to u64, so that multiplications and additions will be done in 64-bit arithmetic (and the results will also be 64-bit) and the possibility of integer overflow is eliminated. Fix Unintentional integer overflow reported by Coverity Reviewed-by: Viorel Suman Signed-off-by: Florin Pavelescu Signed-off-by: Peng Fan --- drivers/clk/imx/clk-pll14xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 6b2c849f8b71..78eedb1f4a79 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -118,7 +118,7 @@ static long pll14xx_calc_rate(struct clk_pll14xx *pll, int mdiv, int pdiv, u64 fout = prate; /* fout = (m * 65536 + k) * Fin / (p * 65536) / (1 << sdiv) */ - fout *= (mdiv * 65536 + kdiv); + fout *= ((u64)mdiv * 65536 + (u64)kdiv); pdiv *= 65536; do_div(fout, pdiv << sdiv); -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel